ansible-collections/git-events
2
0
Fork 0
Code Issues 1 Pull Requests Actions Projects Releases Wiki Activity

Compare commits

base: ansible-collections:5e69fb2807b86dcbd5d28089a2f8482beca3a93b
Branches Tags
ansible-collections:development ansible-collections:master
..
compare: ansible-collections:development
Branches Tags
ansible-collections:development ansible-collections:master

5 Commits
5e69fb2807 ... developmen

Author SHA1 Message Date
Jon Lockwood
5feba1c27c Merge pull request 'fix: No problems found' (#6) from fix-5-no-promlems-approve-pr into development 
Reviewed-on: #6
 2025-07-12 14:11:40 +00:00
Jon
e03a201c30 chore: linting fix
All checks were successful
Lint (Pull Request) / lint (pull_request) Successful in 29s
Details 
ref: #6
 2025-07-12 23:38:11 +09:30
Jon
ec9304fdc5 fix(problem_matcher): correct regex for when pylint content is not available
All checks were successful
Lint (Pull Request) / lint (pull_request) Successful in 29s
Details 
ref: #6
 2025-07-12 23:35:04 +09:30
Jon
f10663a2d5 ci: add ansible-lint
All checks were successful
Lint (Pull Request) / lint (pull_request) Successful in 43s
Details 
ref: #6
 2025-07-12 22:43:03 +09:30
Jon
eb11625b66 fix(problem_matcher): On approval body is required contrary to docs
All checks were successful
Lint (Pull Request) / lint (pull_request) Successful in 9s
Details 
ref: #6 #5
 2025-07-12 22:35:02 +09:30
3 changed files with 18 additions and 5 deletions
Expand all files Collapse all files

14
.gitea/workflows/pull_request.yaml
View File

@ -13,16 +13,30 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- name: Enable Matcher Service - name: Enable Matcher Service
run: | run: |
echo "NFC_PROBLEM_MATCHER=${GITHUB_REF_NAME}"; echo "NFC_PROBLEM_MATCHER=${GITHUB_REF_NAME}";
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- name: Install YAMLLint - name: Install YAMLLint
run: pip install yamllint run: pip install yamllint
- name: Run YAMLLint - name: Run YAMLLint
run: | run: |
echo "NFC_PROBLEM_MATCHER_TYPE=YAML-Lint" echo "NFC_PROBLEM_MATCHER_TYPE=YAML-Lint"
yamllint -f github . || true yamllint -f github . || true
- name: Install Ansible-Lint
run: pip install ansible-lint
- name: Run Ansible-Lint
run: |
echo "NFC_PROBLEM_MATCHER_TYPE=pylint-json";
ansible-lint -f json . || true

2
.yamllint
View File

@ -74,4 +74,4 @@ rules:
level: error level: error
type: unix type: unix
truthy: disable truthy: disable

7
includes/usr/bin/annotations.py
View File

@ -144,8 +144,8 @@ regex = {
r'"description":\s*"(?P<description>[^"]+)",\s*' r'"description":\s*"(?P<description>[^"]+)",\s*'
r'"fingerprint":\s*"(?P<fingerprint>[^"]+)",\s*' r'"fingerprint":\s*"(?P<fingerprint>[^"]+)",\s*'
r'"location":\s*\{\s*"path":\s*"(?P<path>[^"]+)".+?' r'"location":\s*\{\s*"path":\s*"(?P<path>[^"]+)".+?'
r'"line[s]?":.+?(?P<line>\d+).*?\}},' r'"line[s]?":.+?(?P<line>\d+).*?\}}'
r'(?:\s"content":\s\{"body":\s"(?P<body>.+?)")?' r'(?:,\s"content":\s\{"body":\s"(?P<body>.+?)")?'
) )
} }
@ -284,10 +284,9 @@ for msg_type, value in review_body.items():
if len(api_body['comments']) == 0: if len(api_body['comments']) == 0:
api_body.update({ api_body.update({
'body': "G'day, I didn't find any problems to report on",
'event': 'APPROVE' 'event': 'APPROVE'
}) })
del api_body['body']
data = { data = {