gitlab release on master should only occur on_success #16

New Issue

2022-01-25T08:43:46Z

jon_nfc commented

2022-01-25 08:43:46 +00:00

(Migrated from gitlab.com)

no release should occur on master branch if previous step fails, i.e a unit test.

    rules:
        - if: "$CI_COMMIT_AUTHOR =='NFC CI <CI@nfc-gitlab>'"
          when: never
        - if: "$CI_COMMIT_AUTHOR =='NFC CI <helpdesk@nofusscomputing.com>'"
          when: never
        - if: '$CI_COMMIT_BRANCH == "master"'
          when: on_success
          allow_failure: false
        - if: '$CI_COMMIT_BRANCH == "development"'
          when: manual
          allow_failure: true
        - when: never

fix as part of mr !17

no release should occur on master branch if previous step fails, i.e a unit test. adjust [lines 45-54](https://gitlab.com/nofusscomputing/projects/gitlab-ci/-/blob/34582a79e1749fcebae107d275d9d2bd530e5250/gitlab_release/.gitlab-ci.yml#L45-L54) ```yaml rules: - if: "$CI_COMMIT_AUTHOR =='NFC CI <CI@nfc-gitlab>'" when: never - if: "$CI_COMMIT_AUTHOR =='NFC CI <helpdesk@nofusscomputing.com>'" when: never - if: '$CI_COMMIT_BRANCH == "master"' when: on_success allow_failure: false - if: '$CI_COMMIT_BRANCH == "development"' when: manual allow_failure: true - when: never ``` fix as part of mr !17

jon_nfc commented

2022-01-25 08:45:13 +00:00

(Migrated from gitlab.com)

mentioned in merge request !17