infrastructure/gitlab-ci
2
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Projects Releases 21 Wiki Activity

docker hub publish on master using dev tag #36

New Issue
Closed
opened 2023-06-15 05:10:22 +00:00 by jon_nfc · 14 comments
jon_nfc commented 2023-06-15 05:10:22 +00:00 (Migrated from gitlab.com)
Copy Link

the following patch needs to be applied to fix

docker-publish job

  script:
    - docker login docker.io -u $NFC_DOCKERHUB_USERNAME -p $NFC_DOCKERHUB_TOKEN
    - docker image ls
    - |
      DOCKER_HUB_TAG=dev

-      if [ "0$CI_COMMIT_TAG" != "0" ]; then

-        DOCKER_HUB_TAG=latest


-        if [[ "0$CI_COMMIT_TAG" == *"rc"* ]]; then

-          DOCKER_HUB_TAG=dev

-        fi

-      fi
+      if [ "0$CI_COMMIT_BRANCH" == "0master" ]; then

+        DOCKER_HUB_TAG=latest

+      fi
the following patch needs to be applied to fix docker-publish job ``` diff script: - docker login docker.io -u $NFC_DOCKERHUB_USERNAME -p $NFC_DOCKERHUB_TOKEN - docker image ls - | DOCKER_HUB_TAG=dev - if [ "0$CI_COMMIT_TAG" != "0" ]; then - DOCKER_HUB_TAG=latest - if [[ "0$CI_COMMIT_TAG" == *"rc"* ]]; then - DOCKER_HUB_TAG=dev - fi - fi + if [ "0$CI_COMMIT_BRANCH" == "0master" ]; then + DOCKER_HUB_TAG=latest + fi ```
jon_nfc commented 2023-06-15 05:19:56 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue #37

mentioned in issue #37
jon_nfc commented 2023-06-15 05:20:57 +00:00 (Migrated from gitlab.com)
Copy Link

marked this issue as blocking #37

marked this issue as blocking #37
jon_nfc commented 2023-06-15 05:23:03 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue nofusscomputing/projects/ansible/execution_environment#11

mentioned in issue nofusscomputing/projects/ansible/execution_environment#11
jon_nfc commented 2023-06-15 05:23:16 +00:00 (Migrated from gitlab.com)
Copy Link

marked this issue as blocking nofusscomputing/projects/ansible/execution_environment#11

marked this issue as blocking nofusscomputing/projects/ansible/execution_environment#11
jon_nfc commented 2023-09-02 05:19:07 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jon_nfc

assigned to @jon_nfc
jon_nfc commented 2023-09-02 05:20:13 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit fded28742c5da0c258279714243290a48f1cf7e9

mentioned in commit fded28742c5da0c258279714243290a48f1cf7e9
jon_nfc commented 2023-09-02 05:22:21 +00:00 (Migrated from gitlab.com)
Copy Link

For Review ✅

it's unknown if this issue is still of concern. commit fded2874 was added so that additional logging should show if an issue.

# For Review :white_check_mark: it's unknown if this issue is still of concern. commit fded2874 was added so that additional logging should show if an issue.
jon_nfc commented 2023-09-02 05:34:37 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 0d7974152c

mentioned in commit 0d7974152c26200c8beaa3a1ddecf504f4406ee3
jon_nfc commented 2023-09-02 05:37:18 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !68

mentioned in merge request !68
jon_nfc commented 2023-09-02 06:45:13 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request nofusscomputing/projects/ansible/execution_environment!92

mentioned in merge request nofusscomputing/projects/ansible/execution_environment!92
jon_nfc commented 2023-09-02 06:46:07 +00:00 (Migrated from gitlab.com)
Copy Link

nofusscomputing/projects/gitlab-ci!68 should confirm if this issue is still of concern.

nofusscomputing/projects/gitlab-ci!68 should confirm if this issue is still of concern.
jon_nfc commented 2023-09-02 06:46:07 +00:00 (Migrated from gitlab.com)
Copy Link

added 1m of time spent

added 1m of time spent
jon_nfc commented 2023-09-02 06:49:35 +00:00 (Migrated from gitlab.com)
Copy Link

issue will be closed as pipeline https://gitlab.com/nofusscomputing/projects/ansible/execution_environment/-/pipelines/989767035 was successful.

issue will be closed as pipeline https://gitlab.com/nofusscomputing/projects/ansible/execution_environment/-/pipelines/989767035 was successful.
jon_nfc commented 2023-09-02 06:49:36 +00:00 (Migrated from gitlab.com)
Copy Link

added 3m of time spent

added 3m of time spent
jon_nfc (Migrated from gitlab.com) closed this issue 2023-09-02 06:49:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
impact::5
priority::4
type::bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infrastructure/gitlab-ci#36
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?