From 01c6cd4bdf3a167179be4a7e07ed59751ccf44ed Mon Sep 17 00:00:00 2001 From: Jon Date: Wed, 29 May 2024 05:06:10 +0930 Subject: [PATCH] fix(itam): Add correct permissions for operating system view/update !13 --- app/itam/views/operating_system.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/itam/views/operating_system.py b/app/itam/views/operating_system.py index 70dd52cb..049b769e 100644 --- a/app/itam/views/operating_system.py +++ b/app/itam/views/operating_system.py @@ -1,6 +1,7 @@ -from django.contrib.auth.mixins import PermissionRequiredMixin +from django.contrib.auth import decorators as auth_decorator from django.db.models import Q, Count from django.urls import reverse +from django.utils.decorators import method_decorator from django.views import generic from access.mixin import OrganizationPermission @@ -15,7 +16,7 @@ from itam.forms.operating_system.update import Update from settings.models.user_settings import UserSettings -class IndexView(PermissionRequiredMixin, OrganizationPermission, generic.ListView): +class IndexView(OrganizationPermission, generic.ListView): model = OperatingSystem permission_required = 'itam.view_operating_system' template_name = 'itam/operating_system_index.html.j2' @@ -38,7 +39,8 @@ class IndexView(PermissionRequiredMixin, OrganizationPermission, generic.ListVie class View(OrganizationPermission, generic.UpdateView): model = OperatingSystem permission_required = [ - 'itam.view_operating_system' + 'itam.view_operatingsystem', + 'itam.change_operatingsystem', ] template_name = 'itam/operating_system.html.j2' @@ -69,6 +71,7 @@ class View(OrganizationPermission, generic.UpdateView): return context + @method_decorator(auth_decorator.permission_required("itam.change_operatingsystem", raise_exception=True)) def post(self, request, *args, **kwargs): operatingsystem = OperatingSystem.objects.get(pk=self.kwargs['pk'])