chore(core): TicketBase model fn cleanup

ref: #871 #863
This commit is contained in:
2025-07-15 21:11:13 +09:30
parent fd5b223632
commit 15cf7096f2
2 changed files with 7 additions and 59 deletions

View File

@ -6,14 +6,11 @@ from django.apps import apps
from django.conf import settings
from django.db import models
from rest_framework.reverse import reverse
from access.fields import AutoLastModifiedField
from access.models.entity import Entity
from core import exceptions as centurion_exceptions
from core.classes.badge import Badge
from core.lib.feature_not_used import FeatureNotUsed
from core.lib.slash_commands import SlashCommands
from core.middleware.get_request import get_request
from core.models.centurion import CenturionModel
@ -51,6 +48,8 @@ class TicketBase(
save_model_history: bool = False
url_model_name = 'ticket'
class Ticket_ExternalSystem(models.IntegerChoices): # <null|github|gitlab>
GITHUB = TicketValues.ExternalSystem._GITHUB_INT, TicketValues.ExternalSystem._GITHUB_VALUE
GITLAB = TicketValues.ExternalSystem._GITLAB_INT, TicketValues.ExternalSystem._GITLAB_VALUE
@ -832,61 +831,6 @@ class TicketBase(
return related_model
def get_url( self, request = None ) -> str:
ticket_type = self.ticket_type
kwargs = self.get_url_kwargs()
if ticket_type == 'project_task':
kwargs.update({
'project_id': self.project.id
})
if request:
return reverse(f"v2:_api_ticket_sub-detail", request=request, kwargs = kwargs )
return reverse(f"v2:_api_ticket_sub-detail", kwargs = kwargs )
def get_url_kwargs(self) -> dict:
model = self.get_related_model()
# if len(self._meta.parents) == 0 and model is None:
# return {
# 'pk': self.id
# }
if model is None:
model = self
kwargs = {
'ticket_model': self.ticket_type,
}
if model.pk:
kwargs.update({
'pk': model.id
})
return kwargs
def get_url_kwargs_notes(self):
return FeatureNotUsed
def create_action_comment(self) -> None:
from core.models.ticket_comment_action import TicketCommentAction

View File

@ -48,7 +48,11 @@ router.register(
router.register(
prefix=f'ticket/(?P<ticket_model>[{ticket_type_names}]+)', viewset = ticket.ViewSet,
prefix=f'ticket', viewset = ticket.ViewSet,
feature_flag = '2025-00006', basename = '_api_ticket'
)
router.register(
prefix=f'ticket/(?P<model_name>[{ticket_type_names}]+)', viewset = ticket.ViewSet,
feature_flag = '2025-00006', basename = '_api_ticket_sub'
)
router.register(