From 1b7d108a29d5e2683026e1b4f726bd6abcecf0f8 Mon Sep 17 00:00:00 2001 From: Jon Date: Thu, 7 Aug 2025 13:44:07 +0930 Subject: [PATCH] refactor(devops): Remove old test suites no longer required model SoftwareEnableFeatureFlag ref: #946 closes #945 --- .../software_enable_feature_flag/conftest.py | 6 + ...nit_software_enable_feature_flag_api_v2.py | 268 ------------------ 2 files changed, 6 insertions(+), 268 deletions(-) delete mode 100644 app/devops/tests/unit/software_enable_feature_flag/test_unit_software_enable_feature_flag_api_v2.py diff --git a/app/devops/tests/unit/software_enable_feature_flag/conftest.py b/app/devops/tests/unit/software_enable_feature_flag/conftest.py index 0d1b1667..f0ee2a5f 100644 --- a/app/devops/tests/unit/software_enable_feature_flag/conftest.py +++ b/app/devops/tests/unit/software_enable_feature_flag/conftest.py @@ -17,3 +17,9 @@ def model_kwargs(request, kwargs_softwareenablefeatureflag): if hasattr(request.cls, 'kwargs_create_item'): del request.cls.kwargs_create_item + + +@pytest.fixture( scope = 'class') +def model_serializer(serializer_softwareenablefeatureflag): + + yield serializer_softwareenablefeatureflag diff --git a/app/devops/tests/unit/software_enable_feature_flag/test_unit_software_enable_feature_flag_api_v2.py b/app/devops/tests/unit/software_enable_feature_flag/test_unit_software_enable_feature_flag_api_v2.py deleted file mode 100644 index 8faa7a5d..00000000 --- a/app/devops/tests/unit/software_enable_feature_flag/test_unit_software_enable_feature_flag_api_v2.py +++ /dev/null @@ -1,268 +0,0 @@ -import django - -from django.contrib.auth.models import Permission -from django.contrib.contenttypes.models import ContentType -from django.shortcuts import reverse -from django.test import Client, TestCase - -from rest_framework.relations import Hyperlink - -from access.models.tenant import Tenant as Organization -from access.models.team import Team -from access.models.team_user import TeamUsers - -from api.tests.abstract.api_fields import APITenancyObject - -from devops.models.software_enable_feature_flag import SoftwareEnableFeatureFlag - -from itam.models.software import Software - -User = django.contrib.auth.get_user_model() - - - -class API( - TestCase, - APITenancyObject -): - - model = SoftwareEnableFeatureFlag - - @classmethod - def setUpTestData(self): - """Setup Test - - 1. Create an organization for user and item - 2. Create an item - - """ - - self.organization = Organization.objects.create(name='test_org') - - - self.item = self.model.objects.create( - organization = self.organization, - # name = 'one', - software = Software.objects.create( - organization = self.organization, - name = 'soft', - ), - # description = 'desc', - # model_notes = 'text', - enabled = True - ) - - self.url_view_kwargs = { - 'software_id': self.item.software.id, - 'pk': self.item.id, - } - - view_permissions = Permission.objects.get( - codename = 'view_' + self.model._meta.model_name, - content_type = ContentType.objects.get( - app_label = self.model._meta.app_label, - model = self.model._meta.model_name, - ) - ) - - view_team = Team.objects.create( - team_name = 'view_team', - organization = self.organization, - ) - - view_team.permissions.set([view_permissions]) - - self.view_user = User.objects.create_user(username="test_user_view", password="password") - TeamUsers.objects.create( - team = view_team, - user = self.view_user - ) - - client = Client() - url = reverse('v2:_api_softwareenablefeatureflag-detail', kwargs=self.url_view_kwargs) - - - client.force_login(self.view_user) - response = client.get(url) - - self.api_data = response.data - - - - def test_api_field_exists_name(self): - """ Test for existance of API Field - - name field must exist - """ - - assert 'name' not in self.api_data - - - def test_api_field_type_name(self): - """ Test for type for API Field - - name field must be str - """ - - assert 'name' not in self.api_data - - - - # def test_api_field_exists_url_history(self): - # """ Test for existance of API Field - - # _urls.history field must exist - # """ - - # assert 'history' not in self.api_data['_urls'] - - - # def test_api_field_type_url_history(self): - # """ Test for type for API Field - - # _urls.history field must be str - # """ - - # assert 'history' not in self.api_data['_urls'] - - - def test_api_field_exists_description(self): - """ Test for existance of API Field - - description field must exist - """ - - assert 'description' not in self.api_data - - - def test_api_field_type_description(self): - """ Test for type for API Field - - description field must be str - """ - - assert 'description' not in self.api_data - - - - - def test_api_field_exists_model_notes(self): - """ Test for existance of API Field - - model_notes field must exist - """ - - assert 'model_notes' not in self.api_data - - - def test_api_field_type_model_notes(self): - """ Test for type for API Field - - model_notes field must be str - """ - - assert 'model_notes' not in self.api_data - - - - - - - - - - - - - - - - def test_api_field_exists_enabled(self): - """ Test for existance of API Field - - enabled field must exist - """ - - assert 'enabled' in self.api_data - - - def test_api_field_type_enabled(self): - """ Test for type for API Field - - enabled field must be bool - """ - - assert type(self.api_data['enabled']) is bool - - - - def test_api_field_exists_software(self): - """ Test for existance of API Field - - software field must exist - """ - - assert 'software' in self.api_data - - - def test_api_field_type_enabled(self): - """ Test for type for API Field - - software field must be dict - """ - - assert type(self.api_data['software']) is dict - - - def test_api_field_exists_software_id(self): - """ Test for existance of API Field - - software.id field must exist - """ - - assert 'id' in self.api_data['software'] - - - def test_api_field_type_software_id(self): - """ Test for type for API Field - - software.id field must be int - """ - - assert type(self.api_data['software']['id']) is int - - - def test_api_field_exists_software_display_name(self): - """ Test for existance of API Field - - software.display_name field must exist - """ - - assert 'display_name' in self.api_data['software'] - - - def test_api_field_type_software_display_name(self): - """ Test for type for API Field - - software.display_name field must be str - """ - - assert type(self.api_data['software']['display_name']) is str - - - def test_api_field_exists_software_url(self): - """ Test for existance of API Field - - software.url field must exist - """ - - assert 'url' in self.api_data['software'] - - - def test_api_field_type_software_url(self): - """ Test for type for API Field - - software.url field must be Hyperlink - """ - - assert type(self.api_data['software']['url']) is Hyperlink