refactor(devops): Serializer Unit Test Suite re-written to Pytest for model SoftwareEnableFeatureFlag
ref: #946 #945 closes #874
This commit is contained in:
@ -1,122 +0,0 @@
|
||||
import django
|
||||
import pytest
|
||||
|
||||
from django.test import TestCase
|
||||
|
||||
from rest_framework.exceptions import ValidationError
|
||||
|
||||
from access.models.tenant import Tenant as Organization
|
||||
|
||||
from centurion.tests.abstract.mock_view import MockView
|
||||
|
||||
from devops.serializers.software_enable_feature_flag import SoftwareEnableFeatureFlag, ModelSerializer
|
||||
|
||||
from itam.models.software import Software
|
||||
|
||||
User = django.contrib.auth.get_user_model()
|
||||
|
||||
|
||||
|
||||
class ValidationAPI(
|
||||
TestCase,
|
||||
):
|
||||
|
||||
model = SoftwareEnableFeatureFlag
|
||||
|
||||
@classmethod
|
||||
def setUpTestData(self):
|
||||
"""Setup Test
|
||||
|
||||
1. Create an org
|
||||
2. Create an item
|
||||
"""
|
||||
|
||||
organization = Organization.objects.create(name='test_org')
|
||||
|
||||
self.other_organization = Organization.objects.create(name='test_org_other')
|
||||
|
||||
self.organization = organization
|
||||
|
||||
software = Software.objects.create(
|
||||
organization = self.organization,
|
||||
name = 'soft',
|
||||
)
|
||||
|
||||
self.item = self.model.objects.create(
|
||||
organization = self.organization,
|
||||
software = software,
|
||||
enabled = True
|
||||
)
|
||||
|
||||
self.valid_data = {
|
||||
'organization': self.organization.id,
|
||||
# 'name': 'two',
|
||||
'software': software.id,
|
||||
# 'description': 'a description',
|
||||
# 'model_notes': 'dfsdfsd',
|
||||
'enabled': True
|
||||
}
|
||||
|
||||
|
||||
self.user = User.objects.create(
|
||||
username = 'user',
|
||||
password = 'password',
|
||||
is_superuser = True,
|
||||
)
|
||||
|
||||
self.mock_view = MockView(
|
||||
model = self.model,
|
||||
user = self.user,
|
||||
)
|
||||
|
||||
self.mock_view.kwargs = {
|
||||
'software_id': software.id
|
||||
}
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
def test_serializer_validation_valid_data(self):
|
||||
"""Serializer Validation Check
|
||||
|
||||
Ensure that if creating and no name is provided a validation error occurs
|
||||
"""
|
||||
|
||||
serializer = ModelSerializer(
|
||||
context = {
|
||||
'view': self.mock_view,
|
||||
'request': self.mock_view.request
|
||||
},
|
||||
data = self.valid_data
|
||||
)
|
||||
|
||||
|
||||
assert serializer.is_valid( raise_exception = True )
|
||||
|
||||
|
||||
def test_serializer_validation_no_organization_exception(self):
|
||||
"""Serializer Validation Check
|
||||
|
||||
Ensure that when creating and field organization is not provided a
|
||||
validation error occurs
|
||||
"""
|
||||
|
||||
valid_data = self.valid_data.copy()
|
||||
|
||||
del valid_data['organization']
|
||||
|
||||
with pytest.raises(django.core.exceptions.ValidationError) as err:
|
||||
|
||||
serializer = ModelSerializer(
|
||||
context = {
|
||||
'view': self.mock_view,
|
||||
'request': self.mock_view.request
|
||||
},
|
||||
data = valid_data
|
||||
)
|
||||
|
||||
serializer.is_valid(raise_exception = True)
|
||||
serializer.save()
|
||||
|
||||
assert err.value.args[0]['organization'][0].code == 'null'
|
||||
@ -0,0 +1,182 @@
|
||||
import pytest
|
||||
|
||||
from django.db import models
|
||||
|
||||
from rest_framework.exceptions import ValidationError
|
||||
|
||||
from api.tests.unit.test_unit_serializer import (
|
||||
SerializerTestCases
|
||||
)
|
||||
|
||||
from centurion.tests.abstract.mock_view import MockView
|
||||
|
||||
|
||||
|
||||
@pytest.mark.model_softwareenablefeatureflag
|
||||
class SoftwareEnableFeatureFlagSerializerTestCases(
|
||||
SerializerTestCases
|
||||
):
|
||||
|
||||
|
||||
@pytest.fixture( scope = 'function' )
|
||||
def created_model(self, django_db_blocker, model, model_kwargs):
|
||||
|
||||
with django_db_blocker.unblock():
|
||||
|
||||
kwargs_many_to_many = {}
|
||||
|
||||
kwargs = {}
|
||||
|
||||
for key, value in model_kwargs.items():
|
||||
|
||||
field = model._meta.get_field(key)
|
||||
|
||||
if isinstance(field, models.ManyToManyField):
|
||||
|
||||
kwargs_many_to_many.update({
|
||||
key: value
|
||||
})
|
||||
|
||||
else:
|
||||
|
||||
kwargs.update({
|
||||
key: value
|
||||
})
|
||||
|
||||
|
||||
item = model.objects.create( **kwargs )
|
||||
|
||||
for key, value in kwargs_many_to_many.items():
|
||||
|
||||
field = getattr(item, key)
|
||||
|
||||
for entry in value:
|
||||
|
||||
field.add(entry)
|
||||
|
||||
yield item
|
||||
|
||||
item.delete()
|
||||
|
||||
|
||||
|
||||
def test_serializer_is_valid(self, kwargs_api_create, model, model_serializer, request_user):
|
||||
""" Serializer Check
|
||||
|
||||
Confirm that using valid data the object validates without exceptions.
|
||||
"""
|
||||
|
||||
mock_view = MockView(
|
||||
user = request_user,
|
||||
model = model,
|
||||
action = 'create',
|
||||
)
|
||||
|
||||
kwargs = kwargs_api_create.copy()
|
||||
|
||||
mock_view.kwargs = {
|
||||
'software_id': kwargs['software']
|
||||
}
|
||||
|
||||
serializer = model_serializer['model'](
|
||||
context = {
|
||||
'request': mock_view.request,
|
||||
'view': mock_view,
|
||||
},
|
||||
data = kwargs
|
||||
)
|
||||
|
||||
assert serializer.is_valid(raise_exception = True)
|
||||
|
||||
|
||||
|
||||
@pytest.mark.regression
|
||||
def test_serializer_create_calls_model_full_clean(self,
|
||||
kwargs_api_create, mocker, model, model_serializer, request_user
|
||||
):
|
||||
""" Serializer Check
|
||||
|
||||
Confirm that using valid data the object validates without exceptions.
|
||||
"""
|
||||
|
||||
mock_view = MockView(
|
||||
user = request_user,
|
||||
model = model,
|
||||
action = 'create',
|
||||
)
|
||||
|
||||
kwargs = kwargs_api_create.copy()
|
||||
|
||||
mock_view.kwargs = {
|
||||
'software_id': kwargs['software']
|
||||
}
|
||||
|
||||
serializer = model_serializer['model'](
|
||||
context = {
|
||||
'request': mock_view.request,
|
||||
'view': mock_view,
|
||||
},
|
||||
data = kwargs
|
||||
)
|
||||
|
||||
serializer.is_valid(raise_exception = True)
|
||||
|
||||
full_clean = mocker.spy(model, 'full_clean')
|
||||
|
||||
serializer.save()
|
||||
|
||||
full_clean.assert_called_once()
|
||||
|
||||
|
||||
|
||||
def test_serializer_validation_no_organization_exception(self,
|
||||
kwargs_api_create, model, model_serializer, request_user
|
||||
):
|
||||
"""Serializer Validation Check
|
||||
|
||||
Ensure that when creating and field organization is not provided a
|
||||
validation error occurs
|
||||
"""
|
||||
|
||||
mock_view = MockView(
|
||||
user = request_user,
|
||||
model = model,
|
||||
action = 'create',
|
||||
)
|
||||
|
||||
kwargs = kwargs_api_create.copy()
|
||||
del kwargs['organization']
|
||||
|
||||
mock_view.kwargs = {
|
||||
'software_id': kwargs['software']
|
||||
}
|
||||
|
||||
with pytest.raises(ValidationError) as err:
|
||||
|
||||
serializer = model_serializer['model'](
|
||||
context = {
|
||||
'request': mock_view.request,
|
||||
'view': mock_view,
|
||||
},
|
||||
data = kwargs
|
||||
)
|
||||
|
||||
serializer.is_valid(raise_exception = True)
|
||||
serializer.save()
|
||||
|
||||
assert err.value.args[0]['organization'][0].code == 'null'
|
||||
|
||||
|
||||
|
||||
class SoftwareEnableFeatureFlagSerializerInheritedCases(
|
||||
SoftwareEnableFeatureFlagSerializerTestCases
|
||||
):
|
||||
pass
|
||||
|
||||
|
||||
|
||||
@pytest.mark.module_devops
|
||||
class SoftwareEnableFeatureFlagSerializerPyTest(
|
||||
SoftwareEnableFeatureFlagSerializerTestCases
|
||||
):
|
||||
pass
|
||||
1
app/tests/fixtures/__init__.py
vendored
1
app/tests/fixtures/__init__.py
vendored
@ -298,6 +298,7 @@ from .model_softwarecategory import (
|
||||
from .model_softwareenablefeatureflag import (
|
||||
model_softwareenablefeatureflag,
|
||||
kwargs_softwareenablefeatureflag,
|
||||
serializer_softwareenablefeatureflag,
|
||||
)
|
||||
|
||||
from .model_softwareversion import (
|
||||
|
||||
@ -2,7 +2,11 @@ import datetime
|
||||
import pytest
|
||||
|
||||
from devops.models.software_enable_feature_flag import SoftwareEnableFeatureFlag
|
||||
|
||||
from devops.serializers.software_enable_feature_flag import (
|
||||
BaseSerializer,
|
||||
ModelSerializer,
|
||||
ViewSerializer
|
||||
)
|
||||
|
||||
|
||||
@pytest.fixture( scope = 'class')
|
||||
@ -41,3 +45,14 @@ def kwargs_softwareenablefeatureflag(django_db_blocker,
|
||||
with django_db_blocker.unblock():
|
||||
|
||||
software.delete()
|
||||
|
||||
|
||||
|
||||
@pytest.fixture( scope = 'class')
|
||||
def serializer_softwareenablefeatureflag():
|
||||
|
||||
yield {
|
||||
'base': BaseSerializer,
|
||||
'model': ModelSerializer,
|
||||
'view': ViewSerializer
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user