From 36f314fc6f55b4e8490c122731e27d3ebe265de7 Mon Sep 17 00:00:00 2001 From: Jon Date: Sat, 29 Mar 2025 12:35:45 +0930 Subject: [PATCH] test(api): Correct test cases for view_name and view_description cheking type is N/A due to those attributes being set via a getter ref: #696 #672 --- .../tests/unit/test_unit_common_viewset.py | 32 ++++++------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/app/api/tests/unit/test_unit_common_viewset.py b/app/api/tests/unit/test_unit_common_viewset.py index 86ab0431..92a0f67b 100644 --- a/app/api/tests/unit/test_unit_common_viewset.py +++ b/app/api/tests/unit/test_unit_common_viewset.py @@ -558,22 +558,16 @@ class CommonViewSetCases( assert hasattr(self.viewset, 'view_description') - def test_view_attr_view_description_not_empty(self): - """Attribute Test - - Attribute `view_description` must return a value that is not None - """ - - assert self.viewset.view_description is not None - - def test_view_attr_view_description_type(self): """Attribute Test - Attribute `view_description` must be of type str + Attribute `view_description` must be of type str if defined or None otherwise """ - assert type(self.viewset.view_description) is str + assert( + type(self.viewset.view_description) is str + or type(self.viewset.view_description) is type(None) + ) def test_view_attr_view_name_exists(self): @@ -585,24 +579,18 @@ class CommonViewSetCases( assert hasattr(self.viewset, 'view_name') - def test_view_attr_view_name_not_empty(self): - """Attribute Test - - Attribute `view_name` must return a value that is not None - """ - - assert self.viewset.view_name is not None - - def test_view_attr_view_name_type(self): """Attribute Test - Attribute `view_name` must be of type str + Attribute `view_name` must be of type str if defined or None otherwise """ view_set = self.viewset() - assert type(view_set.view_name) is str + assert( + type(view_set.view_name) is str + or type(view_set.view_name) is type(None) + ) # ToDo: get_back_url