From 97f99abe2c65b3c732d8e26c6f7f012cf7c05cc3 Mon Sep 17 00:00:00 2001 From: Jon Date: Mon, 7 Jul 2025 18:49:42 +0930 Subject: [PATCH 1/2] chore: ensure api post items for tests is the correct type ref: #856 --- .../ticket_base/test_functional_ticket_base_viewset.py | 2 +- .../test_functional_software_enable_feature_flag_viewset.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/core/tests/functional/ticket_base/test_functional_ticket_base_viewset.py b/app/core/tests/functional/ticket_base/test_functional_ticket_base_viewset.py index 320be4f7..7353c448 100644 --- a/app/core/tests/functional/ticket_base/test_functional_ticket_base_viewset.py +++ b/app/core/tests/functional/ticket_base/test_functional_ticket_base_viewset.py @@ -97,7 +97,7 @@ class ViewSetBase: self.add_data.update({ 'organization': self.organization.id, - 'opened_by': self.view_user + 'opened_by': self.view_user.id }) diff --git a/app/devops/tests/functional/software_enable_feature_flag/test_functional_software_enable_feature_flag_viewset.py b/app/devops/tests/functional/software_enable_feature_flag/test_functional_software_enable_feature_flag_viewset.py index ee20adbc..86d8438d 100644 --- a/app/devops/tests/functional/software_enable_feature_flag/test_functional_software_enable_feature_flag_viewset.py +++ b/app/devops/tests/functional/software_enable_feature_flag/test_functional_software_enable_feature_flag_viewset.py @@ -214,7 +214,7 @@ class ViewSetBase: self.add_data = { 'enabled': True, 'organization': self.add_organization.id, - 'software': self.software_add, + 'software': self.software_add.id, } From 303cc31f6a309183b0eb5ea3390e25a7b3d727df Mon Sep 17 00:00:00 2001 From: Jon Date: Mon, 7 Jul 2025 20:55:22 +0930 Subject: [PATCH 2/2] test(devops): skip Model History entry test as it should be done as part of serializer and viewset ref: #856 #781 --- .../git_group/test_functional_git_group_model.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/devops/tests/functional/git_group/test_functional_git_group_model.py b/app/devops/tests/functional/git_group/test_functional_git_group_model.py index d576c412..253c28e7 100644 --- a/app/devops/tests/functional/git_group/test_functional_git_group_model.py +++ b/app/devops/tests/functional/git_group/test_functional_git_group_model.py @@ -28,6 +28,16 @@ class GitGroupModelTestCases( } + @pytest.mark.skip( reason = 'test must be as part of serializer and viewset tests, not model' ) + def test_model_create_has_history_entry(self, model_contenttype, created_model, model): + """Model Created + + Ensure that the model when created, added a `create` Audit History + entry. + """ + + pass + def test_model_create_with_parent_sets_tenancy(self, created_model, model): """Model Created