From b5147e24482c9f34a59a48ef5eed5aa5ced21308 Mon Sep 17 00:00:00 2001
From: Jon <jonathon.lockwood@networkedweb.com>
Date: Sun, 25 May 2025 02:59:19 +0930
Subject: [PATCH] refactor(core): Loading of meta models should not be hidden
 behind program start ags

Meta Models must always exist

ref: #772 #759
---
 app/core/models/meta.py | 72 ++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 37 deletions(-)

diff --git a/app/core/models/meta.py b/app/core/models/meta.py
index 0c9db3e8..822baa16 100644
--- a/app/core/models/meta.py
+++ b/app/core/models/meta.py
@@ -14,49 +14,47 @@ if module_path not in sys.modules:
     sys.modules[module_path] = types.ModuleType(module_path)
 
 
-if any(cmd in sys.argv for cmd in ['runserver', 'makemigrations', 'migrate']):
+if apps.models_ready:
 
-    if apps.models_ready:
+    existing_models = { m.__name__ for m in apps.get_models() }
 
-        existing_models = { m.__name__ for m in apps.get_models() }
+    for model in apps.get_models():
 
-        for model in apps.get_models():
+        if not getattr(model, '_audit_enabled', False):
+            continue
 
-            if not getattr(model, '_audit_enabled', False):
-                continue
+        name = model.__name__
 
-            name = model.__name__
+        audit_meta_name = model().get_history_model_name()
 
-            audit_meta_name = model().get_history_model_name()
-
-            if audit_meta_name in existing_models:
-                continue
+        if audit_meta_name in existing_models:
+            continue
 
 
-            AuditMetaModel = type(
-                audit_meta_name,
-                ( import_string("core.models.audit.AuditMetaModel"), ),
-                {
-                    '__module__': module_path,
-                    '__qualname__': audit_meta_name,
-                    '__doc__': f'Auto-generated meta model for {name} Audit History.',
-                    'Meta': type('Meta', (), {
-                                'app_label': model._meta.app_label,
-                                'db_table': model._meta.db_table + '_history',
-                                'managed': True,
-                                'verbose_name': model._meta.verbose_name + ' History',
-                                'verbose_name_plural': model._meta.verbose_name + ' Histories',
-                            }),
-                    'model': models.ForeignKey(
-                        model,
-                        blank = False,
-                        help_text = 'Model this history belongs to',
-                        null = False,
-                        on_delete = models.CASCADE,
-                        related_name = 'audit_history',
-                        verbose_name = 'Model',
-                    )
-                }
-            )
+        AuditMetaModel = type(
+            audit_meta_name,
+            ( import_string("core.models.audit.AuditMetaModel"), ),
+            {
+                '__module__': module_path,
+                '__qualname__': audit_meta_name,
+                '__doc__': f'Auto-generated meta model for {name} Audit History.',
+                'Meta': type('Meta', (), {
+                            'app_label': model._meta.app_label,
+                            'db_table': model._meta.db_table + '_history',
+                            'managed': True,
+                            'verbose_name': model._meta.verbose_name + ' History',
+                            'verbose_name_plural': model._meta.verbose_name + ' Histories',
+                        }),
+                'model': models.ForeignKey(
+                    model,
+                    blank = False,
+                    help_text = 'Model this history belongs to',
+                    null = False,
+                    on_delete = models.CASCADE,
+                    related_name = 'audit_history',
+                    verbose_name = 'Model',
+                )
+            }
+        )
 
-            setattr(sys.modules[module_path], audit_meta_name, AuditMetaModel)
+        setattr(sys.modules[module_path], audit_meta_name, AuditMetaModel)