From be3ce404719de0dd72cd8fd7c394d2faa91c5992 Mon Sep 17 00:00:00 2001
From: Jon <jonathon.lockwood@networkedweb.com>
Date: Wed, 4 Jun 2025 09:09:30 +0930
Subject: [PATCH] chore(assistance): Remove KnowledgeBase Note ViewSet

ref: #783 #785
---
 app/assistance/urls_api.py                    | 10 +---
 .../viewsets/knowledge_base_notes.py          | 60 -------------------
 2 files changed, 3 insertions(+), 67 deletions(-)
 delete mode 100644 app/assistance/viewsets/knowledge_base_notes.py

diff --git a/app/assistance/urls_api.py b/app/assistance/urls_api.py
index 373a2358..df81aa2b 100644
--- a/app/assistance/urls_api.py
+++ b/app/assistance/urls_api.py
@@ -1,7 +1,6 @@
 from assistance.viewsets import (
     index as assistance_index_v2,
     knowledge_base as knowledge_base_v2,
-    knowledge_base_notes,
     model_knowledge_base_article,
     request as request_ticket_v2,
 )
@@ -21,14 +20,11 @@ router.register(
 )
 router.register(
     prefix = 'knowledge_base', viewset = knowledge_base_v2.ViewSet,
-    basename = '_api_v2_knowledge_base'
+    basename = '_api_knowledgebase'
 )
 router.register(
-    prefix = 'knowledge_base/(?P<model_id>[0-9]+)/notes', viewset = knowledge_base_notes.ViewSet,
-    basename = '_api_v2_knowledge_base_note'
-)
-router.register(
-    prefix = '(?P<model>.+)/(?P<model_pk>[0-9]+)/knowledge_base', viewset = model_knowledge_base_article.ViewSet,
+    prefix = '(?P<model>.+)/(?P<model_pk>[0-9]+)/knowledge_base',
+    viewset = model_knowledge_base_article.ViewSet,
     basename = '_api_v2_model_kb'
 )
 router.register(
diff --git a/app/assistance/viewsets/knowledge_base_notes.py b/app/assistance/viewsets/knowledge_base_notes.py
deleted file mode 100644
index 84f31086..00000000
--- a/app/assistance/viewsets/knowledge_base_notes.py
+++ /dev/null
@@ -1,60 +0,0 @@
-from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
-
-from assistance.serializers.knowledge_base_notes import (
-    KnowledgeBaseNotes,
-    KnowledgeBaseNoteModelSerializer,
-    KnowledgeBaseNoteViewSerializer,
-)
-
-from core.viewsets.model_notes import ModelNoteViewSet
-
-
-
-@extend_schema_view(
-    create=extend_schema(
-        summary = 'Add a note to a knowledge base article',
-        description = '',
-        responses = {
-            201: OpenApiResponse(description='created', response=KnowledgeBaseNoteViewSerializer),
-            400: OpenApiResponse(description='Validation failed.'),
-            403: OpenApiResponse(description='User is missing create permissions'),
-        }
-    ),
-    destroy = extend_schema(
-        summary = 'Delete a knowledge base article note',
-        description = ''
-    ),
-    list = extend_schema(
-        summary = 'Fetch all knowledge base article notes',
-        description='',
-    ),
-    retrieve = extend_schema(
-        summary = 'Fetch a single knowledge base article note',
-        description='',
-    ),
-    update = extend_schema(exclude = True),
-    partial_update = extend_schema(
-        summary = 'Update a knowledge base article note',
-        description = ''
-    ),
-)
-class ViewSet(ModelNoteViewSet):
-
-    model = KnowledgeBaseNotes
-
-
-    def get_serializer_class(self):
-
-        if (
-            self.action == 'list'
-            or self.action == 'retrieve'
-        ):
-
-            self.serializer_class = KnowledgeBaseNoteViewSerializer
-
-
-        else:
-            
-            self.serializer_class = KnowledgeBaseNoteModelSerializer
-
-        return self.serializer_class