From becb1eef26bbe8b82573c31121a1b76e8a8e0f1d Mon Sep 17 00:00:00 2001
From: Jon <jonathon.lockwood@networkedweb.com>
Date: Mon, 17 Mar 2025 12:52:10 +0930
Subject: [PATCH] fix(devops): After fetching feature flags dont attempt to
 access results unless status=200

ref: #688 #687
---
 app/centurion_feature_flag/lib/feature_flag.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/app/centurion_feature_flag/lib/feature_flag.py b/app/centurion_feature_flag/lib/feature_flag.py
index 0194b159..8e94368f 100644
--- a/app/centurion_feature_flag/lib/feature_flag.py
+++ b/app/centurion_feature_flag/lib/feature_flag.py
@@ -258,16 +258,21 @@ class CenturionFeatureFlagging:
 
                     self._response = response
 
-                fetched_flags += resp.json()['results']
 
                 if resp.status_code == 304:    # Nothing has changed, exit the loop
 
                     url = None
 
-                else:    # Fetch next page of results
+                elif resp.ok:    # Fetch next page of results
+
+                    fetched_flags += resp.json()['results']
 
                     url = resp.json()['next']
 
+                else:
+
+                    url = None
+
             except requests.exceptions.ConnectionError as err:
 
                 print(f'Error Connecting to {url}')