From da865fd5a8ed8f83bd907721513329e23bb8c8df Mon Sep 17 00:00:00 2001 From: Jon Date: Tue, 10 Jun 2025 13:25:30 +0930 Subject: [PATCH] refactor(tests): make all `parameterized_` vars properties ref: #813 --- .../test_unit_tenancy_abstract_model.py | 10 ++++++++-- app/access/tests/unit/tenant/test_unit_tenant_model.py | 5 ++++- .../knowledge_base/test_unit_knowledge_base_model.py | 5 ++++- .../test_unit_knowledge_base_category_model.py | 5 ++++- app/centurion/tests/unit_models.py | 5 ++++- .../test_unit_config_group_hosts_model.py | 5 ++++- .../config_groups/test_unit_config_groups_model.py | 5 ++++- .../test_unit_config_groups_software_model.py | 5 ++++- .../centurion_audit/test_unit_centurion_audit_model.py | 10 ++++++++-- .../test_unit_centurion_model_note_model.py | 10 ++++++++-- .../unit/manufacturer/test_unit_manufacturer_model.py | 5 ++++- .../ticket_category/test_unit_ticket_category_model.py | 5 ++++- .../test_unit_ticket_comment_category_model.py | 5 ++++- .../tests/unit/check_ins/test_unit_check_ins_model.py | 5 ++++- .../unit/feature_flag/test_unit_feature_flag_model.py | 5 ++++- .../tests/unit/git_group/test_unit_git_group_model.py | 5 ++++- .../git_repository/test_unit_git_repository_model.py | 5 ++++- .../test_unit_github_repository_model.py | 5 ++++- .../test_unit_gitlab_repository_model.py | 5 ++++- app/itam/tests/unit/device/test_unit_device_model.py | 5 ++++- 20 files changed, 92 insertions(+), 23 deletions(-) diff --git a/app/access/tests/unit/tenancy_abstract/test_unit_tenancy_abstract_model.py b/app/access/tests/unit/tenancy_abstract/test_unit_tenancy_abstract_model.py index 4179f894..284af781 100644 --- a/app/access/tests/unit/tenancy_abstract/test_unit_tenancy_abstract_model.py +++ b/app/access/tests/unit/tenancy_abstract/test_unit_tenancy_abstract_model.py @@ -14,10 +14,16 @@ class TenancyAbstractModelTestCases( ): - parameterized_class_attributes = {} + @property + def parameterized_class_attributes(self): + + return {} - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'organization': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/access/tests/unit/tenant/test_unit_tenant_model.py b/app/access/tests/unit/tenant/test_unit_tenant_model.py index 1cbe5357..0b90e574 100644 --- a/app/access/tests/unit/tenant/test_unit_tenant_model.py +++ b/app/access/tests/unit/tenant/test_unit_tenant_model.py @@ -25,7 +25,10 @@ class TenantModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'id': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/assistance/tests/unit/knowledge_base/test_unit_knowledge_base_model.py b/app/assistance/tests/unit/knowledge_base/test_unit_knowledge_base_model.py index be9bee8a..92dcf164 100644 --- a/app/assistance/tests/unit/knowledge_base/test_unit_knowledge_base_model.py +++ b/app/assistance/tests/unit/knowledge_base/test_unit_knowledge_base_model.py @@ -26,7 +26,10 @@ class KnowledgeBaseModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'title': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/assistance/tests/unit/knowledge_base_category/test_unit_knowledge_base_category_model.py b/app/assistance/tests/unit/knowledge_base_category/test_unit_knowledge_base_category_model.py index fbc3ddf1..2e714378 100644 --- a/app/assistance/tests/unit/knowledge_base_category/test_unit_knowledge_base_category_model.py +++ b/app/assistance/tests/unit/knowledge_base_category/test_unit_knowledge_base_category_model.py @@ -26,7 +26,10 @@ class KnowledgeBaseCategoryModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'parent_category': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/centurion/tests/unit_models.py b/app/centurion/tests/unit_models.py index 1f86812a..aedb345b 100644 --- a/app/centurion/tests/unit_models.py +++ b/app/centurion/tests/unit_models.py @@ -23,7 +23,10 @@ class ModelTestCases( ``` py - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { '': { 'blank': , 'default': , diff --git a/app/config_management/tests/unit/config_group_hosts/test_unit_config_group_hosts_model.py b/app/config_management/tests/unit/config_group_hosts/test_unit_config_group_hosts_model.py index 744d969c..4e4c05a8 100644 --- a/app/config_management/tests/unit/config_group_hosts/test_unit_config_group_hosts_model.py +++ b/app/config_management/tests/unit/config_group_hosts/test_unit_config_group_hosts_model.py @@ -31,7 +31,10 @@ class ConfigGroupHostModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'host': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/config_management/tests/unit/config_groups/test_unit_config_groups_model.py b/app/config_management/tests/unit/config_groups/test_unit_config_groups_model.py index 194a4443..e0ddb9f4 100644 --- a/app/config_management/tests/unit/config_groups/test_unit_config_groups_model.py +++ b/app/config_management/tests/unit/config_groups/test_unit_config_groups_model.py @@ -103,7 +103,10 @@ class ConfigGroupModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'parent': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/config_management/tests/unit/config_groups_software/test_unit_config_groups_software_model.py b/app/config_management/tests/unit/config_groups_software/test_unit_config_groups_software_model.py index 06c8b197..fd3237fb 100644 --- a/app/config_management/tests/unit/config_groups_software/test_unit_config_groups_software_model.py +++ b/app/config_management/tests/unit/config_groups_software/test_unit_config_groups_software_model.py @@ -79,7 +79,10 @@ class ConfigGroupSoftwareModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'config_group': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/core/tests/unit/centurion_audit/test_unit_centurion_audit_model.py b/app/core/tests/unit/centurion_audit/test_unit_centurion_audit_model.py index d16217f8..46f407a1 100644 --- a/app/core/tests/unit/centurion_audit/test_unit_centurion_audit_model.py +++ b/app/core/tests/unit/centurion_audit/test_unit_centurion_audit_model.py @@ -21,7 +21,10 @@ class CenturionAuditModelTestCases( ): - parameterized_class_attributes = { + @property + def parameterized_class_attributes(self): + + return { '_audit_enabled': { 'value': False, }, @@ -39,7 +42,10 @@ class CenturionAuditModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'content_type': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/core/tests/unit/centurion_model_note/test_unit_centurion_model_note_model.py b/app/core/tests/unit/centurion_model_note/test_unit_centurion_model_note_model.py index 79dd3ec6..0377cbdd 100644 --- a/app/core/tests/unit/centurion_model_note/test_unit_centurion_model_note_model.py +++ b/app/core/tests/unit/centurion_model_note/test_unit_centurion_model_note_model.py @@ -14,7 +14,10 @@ class CenturionNoteModelTestCases( ): - parameterized_class_attributes = { + @property + def parameterized_class_attributes(self): + + return { '_audit_enabled': { 'value': False, }, @@ -32,7 +35,10 @@ class CenturionNoteModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'body': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/core/tests/unit/manufacturer/test_unit_manufacturer_model.py b/app/core/tests/unit/manufacturer/test_unit_manufacturer_model.py index f256d213..85cced7a 100644 --- a/app/core/tests/unit/manufacturer/test_unit_manufacturer_model.py +++ b/app/core/tests/unit/manufacturer/test_unit_manufacturer_model.py @@ -26,7 +26,10 @@ class ManufacturerModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'name': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/core/tests/unit/ticket_category/test_unit_ticket_category_model.py b/app/core/tests/unit/ticket_category/test_unit_ticket_category_model.py index 30dfaf90..3d9ad247 100644 --- a/app/core/tests/unit/ticket_category/test_unit_ticket_category_model.py +++ b/app/core/tests/unit/ticket_category/test_unit_ticket_category_model.py @@ -26,7 +26,10 @@ class TicketCategoryModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'parent': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/core/tests/unit/ticket_comment_category/test_unit_ticket_comment_category_model.py b/app/core/tests/unit/ticket_comment_category/test_unit_ticket_comment_category_model.py index 78261057..9cf9bc54 100644 --- a/app/core/tests/unit/ticket_comment_category/test_unit_ticket_comment_category_model.py +++ b/app/core/tests/unit/ticket_comment_category/test_unit_ticket_comment_category_model.py @@ -26,7 +26,10 @@ class TicketCommentCategoryModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'parent': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/devops/tests/unit/check_ins/test_unit_check_ins_model.py b/app/devops/tests/unit/check_ins/test_unit_check_ins_model.py index 7ea50722..bdeb1d2d 100644 --- a/app/devops/tests/unit/check_ins/test_unit_check_ins_model.py +++ b/app/devops/tests/unit/check_ins/test_unit_check_ins_model.py @@ -35,7 +35,10 @@ class CheckInModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'model_notes': { 'blank': models.fields.NOT_PROVIDED, 'default': models.fields.NOT_PROVIDED, diff --git a/app/devops/tests/unit/feature_flag/test_unit_feature_flag_model.py b/app/devops/tests/unit/feature_flag/test_unit_feature_flag_model.py index 4990bf4b..97848a0e 100644 --- a/app/devops/tests/unit/feature_flag/test_unit_feature_flag_model.py +++ b/app/devops/tests/unit/feature_flag/test_unit_feature_flag_model.py @@ -25,7 +25,10 @@ class FeatureFlagModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'software': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/devops/tests/unit/git_group/test_unit_git_group_model.py b/app/devops/tests/unit/git_group/test_unit_git_group_model.py index 9e93af27..7ea53421 100644 --- a/app/devops/tests/unit/git_group/test_unit_git_group_model.py +++ b/app/devops/tests/unit/git_group/test_unit_git_group_model.py @@ -26,7 +26,10 @@ class GitGroupModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'parent_group': { 'blank': True, 'default': models.fields.NOT_PROVIDED, diff --git a/app/devops/tests/unit/git_repository/test_unit_git_repository_model.py b/app/devops/tests/unit/git_repository/test_unit_git_repository_model.py index 4d98418d..26d86169 100644 --- a/app/devops/tests/unit/git_repository/test_unit_git_repository_model.py +++ b/app/devops/tests/unit/git_repository/test_unit_git_repository_model.py @@ -30,7 +30,10 @@ class GitRepositoryBaseModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'provider': { 'blank': False, 'default': models.fields.NOT_PROVIDED, diff --git a/app/devops/tests/unit/github_repository/test_unit_github_repository_model.py b/app/devops/tests/unit/github_repository/test_unit_github_repository_model.py index 30e9aa66..a14d8cbe 100644 --- a/app/devops/tests/unit/github_repository/test_unit_github_repository_model.py +++ b/app/devops/tests/unit/github_repository/test_unit_github_repository_model.py @@ -29,7 +29,10 @@ class GitHubRepositoryBaseModelTestCases( # }, # } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'wiki': { 'blank': False, 'default': False, diff --git a/app/devops/tests/unit/gitlab_repository/test_unit_gitlab_repository_model.py b/app/devops/tests/unit/gitlab_repository/test_unit_gitlab_repository_model.py index 38a2ef56..fa071543 100644 --- a/app/devops/tests/unit/gitlab_repository/test_unit_gitlab_repository_model.py +++ b/app/devops/tests/unit/gitlab_repository/test_unit_gitlab_repository_model.py @@ -18,7 +18,10 @@ class GitLabRepositoryBaseModelTestCases( GitRepositoryBaseModelInheritedCases, ): - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'visibility': { 'blank': False, 'default': models.NOT_PROVIDED, diff --git a/app/itam/tests/unit/device/test_unit_device_model.py b/app/itam/tests/unit/device/test_unit_device_model.py index c1b0f1d8..a683ffa9 100644 --- a/app/itam/tests/unit/device/test_unit_device_model.py +++ b/app/itam/tests/unit/device/test_unit_device_model.py @@ -26,7 +26,10 @@ class DeviceModelTestCases( } - parameterized_model_fields = { + @property + def parameterized_model_fields(self): + + return { 'name': { 'blank': False, 'default': models.fields.NOT_PROVIDED,