nofusscomputing/centurion_erp
1
0
Fork 0
Code Issues Wiki Activity

fix(config_management): Config Groups Serializer Validation checks

Browse Source 
ref: #15 #248 #353
This commit is contained in:
Jon Lockwood
2024-10-16 16:05:34 +09:30
parent 518142492f
commit fae48f2c5a
3 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
app/config_management/serializers/config_group.py
View File

@ -129,17 +129,38 @@ class ConfigGroupModelSerializer(ConfigGroupBaseSerializer):
is_valid = super().is_valid(raise_exception=raise_exception)
if 'parent_group' in self._context['view'].kwargs:
if 'view' in self._context:
self.validated_data['parent_id'] = int(self._context['view'].kwargs['parent_group'])
if 'parent_group' in self._context['view'].kwargs:
organization = self.Meta.model.objects.get(pk = int(self._context['view'].kwargs['parent_group']))
self.validated_data['parent_id'] = int(self._context['view'].kwargs['parent_group'])
self.validated_data['organization_id'] = organization.id
organization = self.Meta.model.objects.get(pk = int(self._context['view'].kwargs['parent_group']))
self.validated_data['organization_id'] = organization.id
return is_valid
def validate(self, attrs):
if self.instance:
if hasattr(self.instance, 'parent_id') and 'parent' in self.initial_data:
if self.initial_data['parent'] == self.instance.id:
raise serializers.ValidationError(
detail = {
'parent': 'Can not assign self as parent'
},
code = 'self_not_parent'
)
return super().validate(attrs)
class ConfigGroupViewSerializer(ConfigGroupModelSerializer):
parent = ConfigGroupBaseSerializer( read_only = True )