chore(api): correct pylint errors

ref: #765

app/access/models/entity.py

@@ -105,7 +105,6 @@ class Entity(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/accounting/models/asset_base.py

@@ -255,7 +255,6 @@ class AssetBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/api/serializers/core/ticket.py

@@ -3,8 +3,6 @@ from django.urls import reverse
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from api.serializers.core.ticket_comment import TicketCommentSerializer
-
 from core import exceptions as centurion_exception
 from core.forms.validate_ticket import TicketValidation
 from core.models.ticket.ticket import Ticket

app/api/serializers/core/ticket_category.py

@@ -1,11 +1,6 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from api.serializers.core.ticket_comment import TicketCommentSerializer
-
-from core.forms.validate_ticket import TicketValidation
 from core.models.ticket.ticket_category import TicketCategory
 
 

app/api/serializers/core/ticket_comment_category.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/itam/device.py

@@ -2,8 +2,6 @@ from django.urls import reverse
 
 from rest_framework import serializers
 
-from api.serializers.config import ParentGroupSerializer
-
 from config_management.models.groups import ConfigGroups
 
 from itam.models.device import Device

app/api/serializers/itam/inventory.py

@@ -1,6 +1,3 @@
-from django.urls import reverse
-
-from itam.models.device import Device
 from rest_framework import serializers
 
 

app/api/serializers/project_management/project_state.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/project_management/project_type.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/project_management/projects.py

@@ -1,7 +1,6 @@
 from django.urls import reverse
 
 from rest_framework import serializers
-from rest_framework.fields import empty
 
 from project_management.models.projects import Project
 

app/config_management/serializers/config_group.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer

app/config_management/serializers/config_group_notes.py

@@ -1,11 +1,4 @@
-from rest_framework import serializers
-
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/config_management/serializers/config_group_software.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer

app/config_management/viewsets/config_group.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.serializers.config_group import (
+from config_management.serializers.config_group import (    # pylint: disable=W0611:unused-import
     ConfigGroups,
     ConfigGroupModelSerializer,
     ConfigGroupViewSerializer

app/config_management/viewsets/config_group_software.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.serializers.config_group_software import (
+from config_management.serializers.config_group_software import (    # pylint: disable=W0611:unused-import
     ConfigGroupSoftware,
     ConfigGroupSoftwareModelSerializer,
     ConfigGroupSoftwareViewSerializer

app/core/exceptions.py

@@ -1,11 +1,11 @@
-from django.core.exceptions import (
+from django.core.exceptions import (    # pylint: disable=W0611:unused-import
     ObjectDoesNotExist
 )
 
-from django.http import Http404
+from django.http import Http404    # pylint: disable=W0611:unused-import
 
 from rest_framework import exceptions, status
-from rest_framework.exceptions import (
+from rest_framework.exceptions import (    # pylint: disable=W0611:unused-import
     MethodNotAllowed,
     NotFound,
     NotAuthenticated,

app/core/fields/__init__.py

@@ -1,2 +1,2 @@
-from .char import CharField
+from .char import CharField    # pylint: disable=W0611:unused-import
-from .markdown import MarkdownField
+from .markdown import MarkdownField    # pylint: disable=W0611:unused-import

app/core/fields/badge.py

@@ -3,8 +3,6 @@ from rest_framework.fields import empty
 
 from core.classes.badge import Badge
 
-from core.fields.icon import Icon, IconField
-
 
 
 class BadgeField(serializers.DictField):

app/core/fields/markdown.py

@@ -1,5 +1,3 @@
-from rest_framework import serializers
-
 from core.fields import CharField
 
 

app/core/lib/markdown_plugins/model_reference.py

@@ -2,7 +2,6 @@
 import re
 
 from django.template import Context, Template
-from django.template.loader import render_to_string
 from django.urls import reverse
 
 from markdown_it import MarkdownIt

app/core/lib/slash_commands/duration.py

@@ -1,4 +1,4 @@
-import re
+
 
 
 class Duration:

app/core/management/commands/manufacturer.py

@@ -1,6 +1,5 @@
 from django.core.management.base import BaseCommand
 from django.db.models import Q
-from django.utils import timezone
 
 from core.models.manufacturer import Manufacturer
 

app/core/models/__init__.py

@@ -1,4 +1,4 @@
-from .history import History
+from .history import History    # pylint: disable=W0611:unused-import
-from . import ticket_comment_action
+from . import ticket_comment_action    # pylint: disable=W0611:unused-import
-from . import ticket_comment_base
+from . import ticket_comment_base    # pylint: disable=W0611:unused-import
-from . import ticket_comment_solution
+from . import ticket_comment_solution    # pylint: disable=W0611:unused-import

app/core/models/audit.py

@@ -9,7 +9,7 @@ from access.models.tenant import Tenant
 from access.models.tenancy import TenancyObject
 
 from core.models.centurion import (
-    CenturionModel,
+    # CenturionModel,
     CenturionSubModel,
     ValidationError,
 )

app/core/models/centurion.py

@@ -1,4 +1,4 @@
-from django.db import models
+# from django.db import models
 from django.conf import settings
 from django.core.exceptions import (
     ValidationError

app/core/models/model_history.py

@@ -1,3 +1,3 @@
-from core.models.audit import (
+from core.models.audit import (    # pylint: disable=W0611:unused-import
     ModelHistory
 )

app/core/models/model_notes.py

@@ -4,21 +4,11 @@ from django.conf import settings
 from django.contrib.auth.models import ContentType
 from django.db import models
 
-from rest_framework.reverse import reverse
-
 from access.fields import *
 from access.models.tenancy import TenancyObject
 
-from config_management.models.groups import ConfigGroups
-
 from core.lib.feature_not_used import FeatureNotUsed
 
-from itam.models.device import Device
-from itam.models.software import Software
-from itam.models.operating_system import OperatingSystem
-
-from itim.models.services import Service
-
 User = django.contrib.auth.get_user_model()
 
 

app/core/models/ticket/ticket.py

@@ -18,7 +18,7 @@ from core import exceptions as centurion_exceptions
 from core.lib.feature_not_used import FeatureNotUsed
 from core.lib.slash_commands import SlashCommands
 from core.middleware.get_request import get_request
-from core.models.ticket.ticket_category import TicketCategory, KnowledgeBase
+from core.models.ticket.ticket_category import TicketCategory
 
 from project_management.models.project_milestone import Project, ProjectMilestone
 
@@ -1529,12 +1529,6 @@ class RelatedTickets(TenancyObject):
         return FeatureNotUsed
 
 
-    def __str__(self):
-
-        # return '#' + str( self.id )
-
-        return '#'
-
 
     @property
     def parent_object(self):

app/core/models/ticket/ticket_category.py

@@ -1,7 +1,6 @@
 from django.db import models
 
 from access.fields import AutoCreatedField, AutoLastModifiedField
-from access.models.team import Team
 from access.models.tenancy import TenancyObject
 
 from assistance.models.knowledge_base import KnowledgeBase

app/core/models/ticket/ticket_comment_category.py

@@ -1,7 +1,6 @@
 from django.db import models
 
 from access.fields import AutoCreatedField, AutoLastModifiedField
-from access.models.team import Team
 from access.models.tenancy import TenancyObject
 
 from assistance.models.knowledge_base import KnowledgeBase

app/core/models/ticket/ticket_linked_items.py

@@ -5,13 +5,13 @@ from django.dispatch import receiver
 
 from rest_framework.reverse import reverse
 
-from .ticket_enum_values import TicketValues
-
 from access.models.tenancy import TenancyObject
 
+from assistance.models.knowledge_base import KnowledgeBase
+
 from core.lib.feature_not_used import FeatureNotUsed
 from core.middleware.get_request import get_request
-from core.models.ticket.ticket import Ticket, KnowledgeBase
+from core.models.ticket.ticket import Ticket
 
 deleted_model = dispatch.Signal()
 

app/core/models/ticket_base.py

@@ -780,7 +780,6 @@ class TicketBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/core/models/ticket_comment_action.py

@@ -1,7 +1,3 @@
-import datetime
-
-
-from core import exceptions as centurion_exception
 from core.models.ticket_comment_base import TicketCommentBase
 
 

app/core/models/ticket_comment_base.py

@@ -335,7 +335,6 @@ class TicketCommentBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/core/serializers/celery_log.py

@@ -1,14 +1,8 @@
-import json
-
 from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from django_celery_results.models import TaskResult
 
-from access.serializers.organization import TenantBaseSerializer
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core import fields as centurion_field
 
 

app/core/serializers/manufacturer.py

@@ -1,10 +1,7 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
-from centurion.serializers.user import UserBaseSerializer
-
 from api.serializers import common
 
 from core.models.manufacturer import Manufacturer

app/core/serializers/manufacturer_notes.py

@@ -1,7 +1,6 @@
 from core.models.manufacturer_notes import ManufacturerNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/model_notes.py

@@ -1,5 +1,4 @@
 from django.contrib.auth.models import ContentType
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/core/serializers/ticket_category.py

@@ -1,4 +1,3 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/core/serializers/ticket_category_notes.py

@@ -1,7 +1,6 @@
 from core.models.ticket.ticket_category_notes import TicketCategoryNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/ticket_comment.py

@@ -1,5 +1,3 @@
-import datetime
-
 from rest_framework.reverse import reverse
 
 from rest_framework import serializers

app/core/serializers/ticket_comment_category.py

@@ -1,10 +1,7 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
-from centurion.serializers.user import UserBaseSerializer
-
 from api.serializers import common
 
 from core.models.ticket.ticket_comment_category import TicketCommentCategory

app/core/serializers/ticket_comment_category_notes.py

@@ -1,7 +1,6 @@
 from core.models.ticket.ticket_comment_category_notes import TicketCommentCategoryNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/ticket_comment_depreciated.py

@@ -3,7 +3,7 @@ from rest_framework.reverse import reverse
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from access.serializers.organization import Organization, TenantBaseSerializer
+from access.serializers.organization import TenantBaseSerializer
 from access.serializers.teams import TeamBaseSerializer
 
 from api.serializers import common

app/core/serializers/ticket_depreciated.py

@@ -14,7 +14,7 @@ from core import exceptions as centurion_exception
 from core import fields as centurion_field
 from core.models.ticket.ticket import Ticket
 
-from core.fields.badge import Badge, BadgeField
+from core.fields.badge import BadgeField
 from core.serializers.ticket_category import TicketCategoryBaseSerializer
 
 from project_management.serializers.project import ProjectBaseSerializer
@@ -232,11 +232,10 @@ class TicketModelSerializer(
                 if self.instance.project is None:
 
                     raise centurion_exception.ValidationError(
-                        details = 'Milestones require a project',
+                        detail = 'Milestones require a project',
                         code = 'milestone_requires_project',
                     )
 
-                    return False
 
                 if self.instance.project.id == self.instance.milestone.project.id:
 

app/core/serializers/ticket_linked_item.py

@@ -1,5 +1,3 @@
-from rest_framework.fields import empty
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
@@ -7,7 +5,6 @@ from access.serializers.organization import TenantBaseSerializer
 from assistance.serializers.request import TicketBaseSerializer
 
 from core import fields as centurion_field
-from core.fields.badge import BadgeField
 from core.models.ticket.ticket import Ticket
 from core.models.ticket.ticket_linked_items import TicketLinkedItem
 

app/core/serializers/ticket_related.py

@@ -1,12 +1,10 @@
-from rest_framework.fields import empty
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
 from api.serializers import common
 
-from core.serializers.ticket_depreciated import Ticket, TicketBaseSerializer
+from core.serializers.ticket_depreciated import TicketBaseSerializer
 
 from core import exceptions as centurion_exceptions
 from core import fields as centurion_field

app/core/tests/functional/related_ticket/test_related_ticket_serializer.py

@@ -9,8 +9,8 @@ from access.models.tenant import Tenant as Organization
 
 from centurion.tests.abstract.mock_view import MockView
 
+from core.models.ticket.ticket import Ticket
 from core.serializers.ticket_related import (
-    Ticket,
     RelatedTickets,
     RelatedTicketModelSerializer,
 )

app/core/viewsets/celery_log.py

@@ -1,6 +1,6 @@
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
 
-from core.serializers.celery_log import (
+from core.serializers.celery_log import (    # pylint: disable=W0611:unused-import
     TaskResult,
     TaskResultModelSerializer,
     TaskResultViewSerializer

app/core/viewsets/manufacturer.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from core.models.manufacturer_history import ManufacturerAuditHistory    # pylint: disable=W0611:unused-import
-from core.serializers.manufacturer import (
+from core.serializers.manufacturer import (    # pylint: disable=W0611:unused-import
     Manufacturer,
     ManufacturerModelSerializer,
     ManufacturerViewSerializer

app/core/viewsets/model_notes.py

@@ -1,8 +1,6 @@
 from django.contrib.auth.models import ContentType
 
-from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
+from core.serializers.model_notes import (    # pylint: disable=W0611:unused-import
-
-from core.serializers.model_notes import (
     ModelNotes,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer
@@ -10,14 +8,6 @@ from core.serializers.model_notes import (
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.models.groups import ConfigGroups
-
-from itam.models.device import Device
-from itam.models.operating_system import OperatingSystem
-from itam.models.software import Software
-
-from itim.models.services import Service
-
 
 
 class ModelNoteViewSet(ModelViewSet):

app/core/viewsets/related_ticket.py

@@ -2,12 +2,10 @@ from django.db.models import Q
 
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from access.mixin import OrganizationMixin
-
 from api.viewsets.common import ModelListRetrieveDeleteViewSet
 
-from core.serializers.ticket_related import (
+from core.models.ticket.ticket import Ticket
-    Ticket,
+from core.serializers.ticket_related import (    # pylint: disable=W0611:unused-import
     RelatedTickets,
     RelatedTicketModelSerializer,
     RelatedTicketViewSerializer,

app/core/viewsets/ticket_category.py

@@ -4,7 +4,7 @@ from api.viewsets.common import ModelViewSet
 
 # THis import only exists so that the migrations can be created
 from core.models.ticket.ticket_category_history import TicketCategoryHistory    # pylint: disable=W0611:unused-import
-from core.serializers.ticket_category import (
+from core.serializers.ticket_category import (    # pylint: disable=W0611:unused-import
     TicketCategory,
     TicketCategoryModelSerializer,
     TicketCategoryViewSerializer

app/core/viewsets/ticket_comment_category.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from core.models.ticket.ticket_comment_category_history import TicketCommentCategoryHistory    # pylint: disable=W0611:unused-import
-from core.serializers.ticket_comment_category import (
+from core.serializers.ticket_comment_category import (    # pylint: disable=W0611:unused-import
     TicketCommentCategory,
     TicketCommentCategoryModelSerializer,
     TicketCommentCategoryViewSerializer

app/core/viewsets/ticket_comment_depreciated.py

@@ -1,18 +1,9 @@
-from django.db.models import Q
-from django.shortcuts import get_object_or_404
-
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse, PolymorphicProxySerializer
 
-from rest_framework import generics, viewsets
-from rest_framework.response import Response
-
-from access.mixin import OrganizationMixin
-
-from api.views.mixin import OrganizationPermissionAPI
 from api.viewsets.common import ModelViewSet
 
 from core import exceptions as centurion_exceptions
-from core.serializers.ticket_comment_depreciated import (
+from core.serializers.ticket_comment_depreciated import (    # pylint: disable=W0611:unused-import
     Ticket,
     TicketComment,
     TicketCommentImportModelSerializer,
@@ -35,8 +26,6 @@ from core.serializers.ticket_comment_depreciated import (
     TicketCommentViewSerializer
 )
 
-from settings.models.user_settings import UserSettings
-
 
 
 @extend_schema_view(

app/core/viewsets/ticket_depreciated.py

@@ -3,7 +3,7 @@ from api.viewsets.common import ModelViewSet
 
 from access.models.tenant import Tenant as Organization
 
-from assistance.serializers.request import (
+from assistance.serializers.request import (    # pylint: disable=W0611:unused-import
     RequestAddTicketModelSerializer,
     RequestChangeTicketModelSerializer,
     RequestTriageTicketModelSerializer,
@@ -16,7 +16,7 @@ from core.serializers.ticket_depreciated import (
     Ticket,
 )
 
-from itim.serializers.change import (
+from itim.serializers.change import (    # pylint: disable=W0611:unused-import
     ChangeAddTicketModelSerializer,
     ChangeChangeTicketModelSerializer,
     ChangeImportTicketModelSerializer,
@@ -25,7 +25,7 @@ from itim.serializers.change import (
     ChangeTicketViewSerializer,
 )
 
-from itim.serializers.incident import (
+from itim.serializers.incident import (    # pylint: disable=W0611:unused-import
     IncidentAddTicketModelSerializer,
     IncidentChangeTicketModelSerializer,
     IncidentImportTicketModelSerializer,
@@ -34,7 +34,7 @@ from itim.serializers.incident import (
     IncidentTicketViewSerializer,
 )
 
-from itim.serializers.problem import (
+from itim.serializers.problem import (    # pylint: disable=W0611:unused-import
     ProblemAddTicketModelSerializer,
     ProblemChangeTicketModelSerializer,
     ProblemImportTicketModelSerializer,
@@ -43,7 +43,7 @@ from itim.serializers.problem import (
     ProblemTicketViewSerializer,
 )
 
-from project_management.serializers.project_task import (
+from project_management.serializers.project_task import (    # pylint: disable=W0611:unused-import
     ProjectTaskAddTicketModelSerializer,
     ProjectTaskChangeTicketModelSerializer,
     ProjectTaskImportTicketModelSerializer,
@@ -52,8 +52,6 @@ from project_management.serializers.project_task import (
     ProjectTaskTicketViewSerializer,
 )
 
-from settings.models.user_settings import UserSettings
-
 
 
 class TicketViewSet(ModelViewSet):

app/core/viewsets/ticket_linked_item.py

@@ -1,6 +1,5 @@
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from api.views.mixin import OrganizationPermissionAPI
 from api.viewsets.common import ModelViewSet
 
 from assistance.models.knowledge_base import KnowledgeBase
@@ -9,7 +8,7 @@ from config_management.models.groups import ConfigGroups
 
 from core.models.ticket.ticket_category import TicketCategory
 from core.models.ticket.ticket_comment_category import TicketCommentCategory
-from core.serializers.ticket_linked_item import (
+from core.serializers.ticket_linked_item import (    # pylint: disable=W0611:unused-import
     Ticket,
     TicketLinkedItem,
     TicketLinkedItemModelSerializer,

app/devops/models/__init__.py

@@ -1,5 +1,5 @@
-from . import check_ins
+from . import check_ins    # pylint: disable=W0611:unused-import
-from . import git_group
+from . import git_group    # pylint: disable=W0611:unused-import
-from . import git_repository
+from . import git_repository    # pylint: disable=W0611:unused-import
-from . import feature_flag
+from . import feature_flag    # pylint: disable=W0611:unused-import
-from . import software_enable_feature_flag
+from . import software_enable_feature_flag    # pylint: disable=W0611:unused-import

app/devops/models/git_repository/__init__.py

@@ -1,2 +1,2 @@
-from . import github
+from . import github    # pylint: disable=W0611:unused-import
-from . import gitlab
+from . import gitlab    # pylint: disable=W0611:unused-import

app/devops/models/software_enable_feature_flag.py

@@ -1,6 +1,6 @@
 import pytz
 
-from datetime import date, datetime
+from datetime import datetime
 
 from django.db import models
 

app/devops/serializers/git_repository/base.py

@@ -8,7 +8,7 @@ from api.serializers import common
 
 from core.fields.badge import BadgeField
 
-from devops.models.git_repository.base import GitRepository, GitGroup
+from devops.models.git_repository.base import GitRepository
 from devops.serializers.git_group import BaseSerializer as GitGroupBaseSerializer
 
 

app/devops/serializers/git_repository/github.py

@@ -2,11 +2,9 @@ from drf_spectacular.utils import extend_schema_serializer
 
 from rest_framework import serializers
 
-from api.serializers import common
-
 from devops.models.git_group import GitGroup
 from devops.models.git_repository.github import GitHubRepository
-from devops.serializers.git_repository.base import (
+from devops.serializers.git_repository.base import (    # pylint: disable=W0611:unused-import
     BaseSerializer,
     ModelSerializer as GitModelSerializer,
     ViewSerializer as GitViewSerializer

app/devops/serializers/git_repository/gitlab.py

@@ -2,15 +2,9 @@ from drf_spectacular.utils import extend_schema_serializer
 
 from rest_framework import serializers
 
-from access.serializers.organization import TenantBaseSerializer
-
-from api.serializers import common
-
-from core import exceptions as centurion_exceptions
-
 from devops.models.git_group import GitGroup
 from devops.models.git_repository.gitlab import GitLabRepository
-from devops.serializers.git_repository.base import (
+from devops.serializers.git_repository.base import (    # pylint: disable=W0611:unused-import
     BaseSerializer,
     ModelSerializer as GitModelSerializer,
     ViewSerializer as GitViewSerializer

app/devops/urls_public.py

@@ -1,4 +1,4 @@
-from rest_framework.routers import DefaultRouter, SimpleRouter
+from rest_framework.routers import SimpleRouter
 
 from devops.viewsets import (
     feature_flag_endpoints,

app/devops/viewsets/git_repository.py

@@ -11,8 +11,7 @@ from drf_spectacular.utils import (
 # THis import only exists so that the migrations can be created
 from devops.models.git_repository.github_history import GitHubAuditHistory    # pylint: disable=W0611:unused-import
 from devops.models.git_repository.gitlab_history import GitlabAuditHistory    # pylint: disable=W0611:unused-import
-from devops.models.git_group import GitGroup
+from devops.serializers.git_repository.base import (    # pylint: disable=W0611:unused-import
-from devops.serializers.git_repository.base import (
     GitRepository,
     ModelSerializer,
     ViewSerializer,

app/human_resources/models/__init__.py

@@ -1 +1 @@
-from . import employee
+from . import employee    # pylint: disable=W0611:unused-import

app/itam/models/__init__.py

@@ -1,2 +1,2 @@
-from .device_software_history import DeviceSoftwareHistory
+from .device_software_history import DeviceSoftwareHistory    # pylint: disable=W0611:unused-import
-from .itam_asset_base import ITAMAssetBase
+from .itam_asset_base import ITAMAssetBase    # pylint: disable=W0611:unused-import

app/itam/models/device.py

@@ -9,10 +9,8 @@ from django.dispatch import receiver
 from django.forms import ValidationError
 
 from rest_framework import serializers
-from rest_framework.reverse import reverse
 
 from access.fields import *
-from access.models.tenancy import TenancyObject
 
 from centurion.helpers.merge_software import merge_software
 

app/itam/models/device_models.py

@@ -2,8 +2,6 @@ from django.db import models
 
 from itam.models.device_common import DeviceCommonFieldsName
 
-from access.models.tenancy import TenancyObject
-
 from core.mixin.history_save import SaveHistory
 from core.models.manufacturer import Manufacturer
 

app/itam/serializers/device.py

@@ -1,16 +1,13 @@
 import json
 
-from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
-
 from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
 from api.serializers import common
-from api.viewsets.common import ModelViewSet
 
-from core.fields.icon import Icon, IconField
+from core.fields.icon import IconField
 
 from itam.models.device import Device
 from itam.serializers.device_model import DeviceModelBaseSerializer

app/itam/serializers/device_model.py

@@ -1,5 +1,3 @@
-from rest_framework.reverse import reverse
-
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/itam/serializers/device_model_notes.py

@@ -1,7 +1,4 @@
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/serializers/device_notes.py

@@ -1,14 +1,4 @@
-from rest_framework.reverse import reverse
-from rest_framework import serializers
-
-from access.serializers.organization import TenantBaseSerializer
-
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer
@@ -17,7 +7,6 @@ from core.serializers.model_notes import (
 from itam.models.device_notes import (
     DeviceNotes
 )
-from itam.serializers.device import DeviceBaseSerializer
 
 
 

app/itam/serializers/device_operating_system.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer
@@ -7,11 +6,10 @@ from access.serializers.organization import TenantBaseSerializer
 from api.serializers import common
 
 from core import exceptions as centurion_exception
-from core.fields.badge import Badge, BadgeField
 
 from itam.models.device import Device, DeviceOperatingSystem
 from itam.serializers.device import DeviceBaseSerializer
-from itam.serializers.operating_system_version import OperatingSystem, OperatingSystemVersionBaseSerializer
+from itam.serializers.operating_system_version import OperatingSystemVersionBaseSerializer
 
 
 

app/itam/serializers/device_software.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer
@@ -7,7 +6,7 @@ from access.serializers.organization import TenantBaseSerializer
 from api.serializers import common
 
 from core import exceptions as centurion_exception
-from core.fields.badge import Badge, BadgeField
+from core.fields.badge import BadgeField
 
 from itam.models.device import Device, DeviceSoftware
 from itam.serializers.device import DeviceBaseSerializer

app/itam/serializers/device_type.py

@@ -1,4 +1,3 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/itam/serializers/device_type_notes.py

@@ -1,7 +1,4 @@
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer
@@ -10,7 +7,6 @@ from core.serializers.model_notes import (
 from itam.models.device_type_notes import (
     DeviceTypeNotes
 )
-from itam.serializers.device import DeviceBaseSerializer
 
 
 

app/itam/serializers/inventory.py

@@ -1,5 +1,4 @@
 from django.db.models import Q
-from django.urls import reverse
 
 from rest_framework import serializers
 

app/itam/serializers/operating_system_notes.py

@@ -1,8 +1,4 @@
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/serializers/operating_system_version.py

@@ -1,13 +1,9 @@
-from rest_framework.reverse import reverse
-
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
 from api.serializers import common
 
-from core.serializers.manufacturer import ManufacturerBaseSerializer
-
 from itam.models.operating_system import OperatingSystem, OperatingSystemVersion
 from itam.serializers.operating_system import OperatingSystemBaseSerializer
 

app/itam/serializers/operating_system_version_notes.py

@@ -1,8 +1,4 @@
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/serializers/software_category.py

@@ -1,12 +1,9 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
 from api.serializers import common
 
-from core.serializers.manufacturer import ManufacturerBaseSerializer
-
 from itam.models.software import SoftwareCategory
 
 

app/itam/serializers/software_category_notes.py

@@ -1,5 +1,4 @@
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/serializers/software_notes.py

@@ -1,5 +1,4 @@
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/serializers/software_version_notes.py

@@ -1,5 +1,4 @@
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/itam/tasks/inventory.py

@@ -3,15 +3,14 @@ import re
 
 from django.utils import timezone
 
-from celery import shared_task, current_task
+from celery import shared_task
 from celery.utils.log import get_task_logger
-from celery import states
 
 from access.models.tenant import Tenant as Organization
 
 from itam.serializers.inventory import InventorySerializer
 
-from itam.models.device import Device, DeviceType, DeviceOperatingSystem, DeviceSoftware
+from itam.models.device import Device, DeviceOperatingSystem, DeviceSoftware
 from itam.models.operating_system import OperatingSystem, OperatingSystemVersion
 from itam.models.software import Software, SoftwareCategory, SoftwareVersion
 
@@ -449,5 +448,3 @@ def process_inventory(self, data, organization: int):
         logger.critical('Exception')
 
         raise Exception(e)
-
-        return str(f'Exception Occured: {e}')

app/itam/urls.py

@@ -1,7 +1,6 @@
 from django.urls import path
 
-from . import views
+from .views import device, software, software_version, operating_system, operating_system_version
-from .views import device, device_type, software, software_category, software_version, operating_system, operating_system_version
 
 app_name = "ITAM"
 urlpatterns = [

app/itam/viewsets/device.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from itam.serializers.device import (
+from itam.serializers.device import (    # pylint: disable=W0611:unused-import
     Device,
     DeviceModelSerializer,
     DeviceViewSerializer

app/itam/viewsets/device_model.py

@@ -4,14 +4,12 @@ from api.viewsets.common import ModelViewSet
 
 # THis import only exists so that the migrations can be created
 from itam.models.device_model_history import DeviceModelHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.device_model import (
+from itam.serializers.device_model import (    # pylint: disable=W0611:unused-import
     DeviceModel,
     DeviceModelModelSerializer,
     DeviceModelViewSerializer
 )
 
-from api.views.mixin import OrganizationPermissionAPI
-
 
 
 @extend_schema_view(

app/itam/viewsets/device_operating_system.py

@@ -1,29 +1,15 @@
-from django_filters.rest_framework import DjangoFilterBackend
-from rest_framework import filters
-
-from django.db.models import Q
-from django.shortcuts import get_object_or_404
-
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from rest_framework.fields import empty
-from rest_framework import generics, viewsets
-from rest_framework.response import Response
-
-from access.mixin import OrganizationMixin
-
-from api.views.mixin import OrganizationPermissionAPI
-
 from api.viewsets.common import ModelViewSet
 
 # THis import only exists so that the migrations can be created
 from itam.models.device_operating_system_history import DeviceOperatingSystemHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.device_operating_system import (
+from itam.models.operating_system import OperatingSystem
+from itam.serializers.device_operating_system import (    # pylint: disable=W0611:unused-import
     Device,
     DeviceOperatingSystem,
     DeviceOperatingSystemModelSerializer,
     DeviceOperatingSystemViewSerializer,
-    OperatingSystem,
 )
 
 

app/itam/viewsets/device_software.py

@@ -1,22 +1,8 @@
-from django_filters.rest_framework import DjangoFilterBackend
-from rest_framework import filters
-
-from django.db.models import Q
-from django.shortcuts import get_object_or_404
-
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from rest_framework.fields import empty
-from rest_framework import generics, viewsets
-from rest_framework.response import Response
-
-from access.mixin import OrganizationMixin
-
-from api.views.mixin import OrganizationPermissionAPI
-
 from api.viewsets.common import ModelViewSet
 
-from itam.serializers.device_software import (
+from itam.serializers.device_software import (    # pylint: disable=W0611:unused-import
     Device,
     DeviceSoftware,
     DeviceSoftwareModelSerializer,

app/itam/viewsets/device_type.py

@@ -4,14 +4,12 @@ from api.viewsets.common import ModelViewSet
 
 # THis import only exists so that the migrations can be created
 from itam.models.device_type_history import DeviceTypeHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.device_type import (
+from itam.serializers.device_type import (    # pylint: disable=W0611:unused-import
     DeviceType,
     DeviceTypeModelSerializer,
     DeviceTypeViewSerializer
 )
 
-from api.views.mixin import OrganizationPermissionAPI
-
 
 
 @extend_schema_view(

app/itam/viewsets/inventory.py

@@ -1,5 +1,3 @@
-import json
-
 from django.db.models import Q
 
 from kombu.exceptions import OperationalError

app/itam/viewsets/operating_system.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from itam.models.operating_system_history import OperatingSystemHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.operating_system import (
+from itam.serializers.operating_system import (    # pylint: disable=W0611:unused-import
     OperatingSystem,
     OperatingSystemModelSerializer,
     OperatingSystemViewSerializer

app/itam/viewsets/operating_system_version.py

@@ -4,7 +4,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiPara
 
 # THis import only exists so that the migrations can be created
 from itam.models.operating_system_version_history import OperatingSystemVersionHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.operating_system_version import (
+from itam.serializers.operating_system_version import (    # pylint: disable=W0611:unused-import
     OperatingSystem,
     OperatingSystemVersion,
     OperatingSystemVersionModelSerializer,

app/itam/viewsets/software.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from itam.models.software_history import SoftwareHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.software import (
+from itam.serializers.software import (    # pylint: disable=W0611:unused-import
     Software,
     SoftwareModelSerializer,
     SoftwareViewSerializer

app/itam/viewsets/software_category.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from itam.models.software_category_history import SoftwareCategoryHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.software_category import (
+from itam.serializers.software_category import (    # pylint: disable=W0611:unused-import
     SoftwareCategory,
     SoftwareCategoryModelSerializer,
     SoftwareCategoryViewSerializer

app/itam/viewsets/software_version.py

@@ -4,7 +4,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiPara
 
 # THis import only exists so that the migrations can be created
 from itam.models.software_version_history import SoftwareVersionHistory    # pylint: disable=W0611:unused-import
-from itam.serializers.software_version import (
+from itam.serializers.software_version import (    # pylint: disable=W0611:unused-import
     Software,
     SoftwareVersion,
     SoftwareVersionModelSerializer,

app/itim/models/__init__.py

@@ -1,4 +1,4 @@
-from . import clusters
+from . import clusters    # pylint: disable=W0611:unused-import
-from . import services
+from . import services    # pylint: disable=W0611:unused-import
-from . import slm_ticket_base
+from . import slm_ticket_base    # pylint: disable=W0611:unused-import
-from . import request_ticket
+from . import request_ticket    # pylint: disable=W0611:unused-import

app/itim/models/clusters.py

@@ -1,13 +1,10 @@
-from django.contrib.auth.models import User
 from django.db import models
 from django.db.models.signals import post_delete
 from django.dispatch import receiver
-from django.forms import ValidationError
 
 from rest_framework.reverse import reverse
 
 from access.fields import *
-from access.models.team import Team
 from access.models.tenancy import TenancyObject
 
 from core.signal.ticket_linked_item_delete import TicketLinkedItem, deleted_model