ansible-collections/kubernetes
2
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Projects Releases 28 Wiki Activity

fix(kebernetes): Apply fixes listed in issues #108

Closed
jasonpage.tas wants to merge 0 commits from fixes into development
pull from: fixes
merge into: ansible-collections:development
Conversation 77 Commits - Files Changed - +15 -5
jasonpage.tas commented 2024-07-04 02:56:49 +00:00 (Migrated from gitlab.com)
Copy Link

📚 Summary

  • nofusscomputing/projects/ansible/collections/kubernetes#33 var 'kubernetes_config.cluster.prime.name' still used in templates

  • nofusscomputing/projects/ansible/collections/kubernetes#32 ip6tables not set to legacy mode

🔗 Links / References

👷 Tasks

  • Add your tasks here if required (delete)
### :books: Summary <!-- your summary here emojis ref: https://github.com/yodamad/gitlab-emoji --> - nofusscomputing/projects/ansible/collections/kubernetes#33 var 'kubernetes_config.cluster.prime.name' still used in templates - nofusscomputing/projects/ansible/collections/kubernetes#32 ip6tables not set to legacy mode ### :link: Links / References <!-- using a list as any links to other references or links as required. if relevent, describe the link/reference --> ### :construction_worker: Tasks - [ ] Add your tasks here if required (delete) <!-- dont remove tasks below strike through including the checkbox by enclosing in double tidle '~~' --> - [ ] Playbook Update This collection has a [corresponding playbook](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/role.yaml) that may need to be updated (Ansible Role), specifically [Role Validation](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/tasks/role/validation/nfc_kubernetes.yaml). - [ ] NetBox Rendered Config Update This Collection has a [NetBox Rendered Config template](https://gitlab.com/nofusscomputing/infrastructure/configuration-management/netbox/-/blob/development/templates/cluster.json.j2) that may need to be updated. Specifically Section `cluster.type == 'kubernetes'`
jasonpage.tas commented 2024-07-04 02:57:51 +00:00 (Migrated from gitlab.com)
Copy Link

changed the description

changed the description
jon_nfc commented 2024-07-04 03:04:20 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jasonpage.tas

assigned to @jasonpage.tas
jasonpage.tas commented 2024-07-04 03:11:06 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 00df3416 - fix(kubernetes): IP6Tables to legacy mode

Compare with previous version

added 1 commit <ul><li>00df3416 - fix(kubernetes): IP6Tables to legacy mode</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055154266&start_sha=5a188407fe801f0d88292656695d2ee824eeb7c0)
jasonpage.tas commented 2024-07-04 03:27:25 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • b829b0c6 - fix(template): remove depreciated variables

Compare with previous version

added 1 commit <ul><li>b829b0c6 - fix(template): remove depreciated variables</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055159082&start_sha=00df34167bfd314d329b8338a7286ab8f560e806)
jon_nfc commented 2024-07-04 03:51:25 +00:00 (Migrated from gitlab.com)
Copy Link

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is nfc_role_kubernetes_prime, which is of type boolean

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is `nfc_role_kubernetes_prime`, which is of type `boolean`
jon_nfc commented 2024-07-04 03:51:25 +00:00 (Migrated from gitlab.com)
Copy Link

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is nfc_role_kubernetes_prime, which is of type boolean

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is `nfc_role_kubernetes_prime`, which is of type `boolean`
jon_nfc commented 2024-07-04 03:51:25 +00:00 (Migrated from gitlab.com)
Copy Link

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is nfc_role_kubernetes_prime, which is of type boolean

you have removed the checks to determin if the node is the prime node. these need to remain for obvious reasons. the variable to determine if the host is a prime node is `nfc_role_kubernetes_prime`, which is of type `boolean`
jon_nfc commented 2024-07-04 03:51:26 +00:00 (Migrated from gitlab.com)
Copy Link

fix commits


fix(template): remove depreciated variables 

remove kubernetes_config.cluster.prime.name variable from template

!1 fixes issue nofusscomputing/projects/ansible/collections/kubernetes#33



fix(kubernetes): IP6Tables to legacy mode 

Add task for setting IP6Tables to legacy mode

!1 fixes issue nofusscomputing/projects/ansible/collections/kubernetes#32
  • scope needs to be correctly set, in this case the scope is the role kubernetes_role
  • as for the description, aptly use the "what" you've done and to "what" it was done to.
  • the notes part of the commit message is optional and not to specify the "what" you've done, it's for the "why" it was done and generally if not obvious.
  • footer references dont need to be the full ref if the referenced item is within the same repo as the commit. i.e. nofusscomputing/projects/ansible/collections/kubernetes#32 = #32
  • footer MR reference does not match this MR which can be found at the end of the URL.
# fix commits ``` txt fix(template): remove depreciated variables remove kubernetes_config.cluster.prime.name variable from template !1 fixes issue nofusscomputing/projects/ansible/collections/kubernetes#33 ``` ``` txt fix(kubernetes): IP6Tables to legacy mode Add task for setting IP6Tables to legacy mode !1 fixes issue nofusscomputing/projects/ansible/collections/kubernetes#32 ``` - scope needs to be correctly set, in this case the scope is the role `kubernetes_role` - as for the description, aptly use the "what" you've done and to "what" it was done to. - the notes part of the commit message is optional and not to specify the "what" you've done, it's for the "why" it was done and generally if not obvious. - footer references dont need to be the full ref if the referenced item is within the same repo as the commit. i.e. `nofusscomputing/projects/ansible/collections/kubernetes#32` = `#32` - footer MR reference does not match this MR which can be found at the end of the URL.
jon_nfc commented 2024-07-04 03:51:26 +00:00 (Migrated from gitlab.com)
Copy Link

added 10m of time spent

added 10m of time spent
jon_nfc commented 2024-07-04 03:51:26 +00:00 (Migrated from gitlab.com)
Copy Link

requested changes

requested changes
jasonpage.tas commented 2024-07-04 04:06:49 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055173779&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_197_208)
jasonpage.tas commented 2024-07-04 04:06:50 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055173779&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_231_244)
jasonpage.tas commented 2024-07-04 04:06:50 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055173779&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_11_12)
jasonpage.tas commented 2024-07-04 04:06:51 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • be67abb1 - Revert "fix(template): remove depreciated variables"
  • 67341ce1 - Merge branch 'revert-b829b0c6' into 'fixes'

Compare with previous version

added 2 commits <ul><li>be67abb1 - Revert &quot;fix(template): remove depreciated variables&quot;</li><li>67341ce1 - Merge branch &#39;revert-b829b0c6&#39; into &#39;fixes&#39;</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055173779&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6)
jon_nfc commented 2024-07-04 05:11:28 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055203446&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_197_208)
jon_nfc commented 2024-07-04 05:11:28 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055203446&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_231_244)
jon_nfc commented 2024-07-04 05:11:28 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 5 of the diff

changed this line in [version 5 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055203446&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6#cce8a4eb24927eec9e1e73ced526440013e017c5_11_12)
jon_nfc commented 2024-07-04 05:11:29 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • f5bba112 - feat(kubernetes_role): set ip6tables to legacy mode

Compare with previous version

added 1 commit <ul><li>f5bba112 - feat(kubernetes_role): set ip6tables to legacy mode</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055203446&start_sha=b829b0c62737fb5c377994dacfb4348a7034b4d6)
jasonpage.tas commented 2024-07-04 05:23:32 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 255cc01b - fix(kubernetes_role): update var kubernetes_config.cluster.prime.name -> nfc_role_kubernetes_prime

Compare with previous version

added 1 commit <ul><li>255cc01b - fix(kubernetes_role): update var kubernetes_config.cluster.prime.name -&gt; nfc_role_kubernetes_prime</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055209861&start_sha=f5bba112cf9858b3935c3fa66aea7e46183901fa)
jasonpage.tas commented 2024-07-04 05:25:22 +00:00 (Migrated from gitlab.com)
Copy Link

@jon_nfc

review 255cc01b79591acb9a889be1905439a75f6155e9

@jon_nfc review 255cc01b79591acb9a889be1905439a75f6155e9
jasonpage.tas commented 2024-07-04 05:26:02 +00:00 (Migrated from gitlab.com)
Copy Link

@jon_nfc

this variable has also been found in another location roles/nfc_kubernetes/tasks/k3s/migrate_to_operator.yaml


    - name: Remove calico migration label
      ansible.builtin.shell:
        cmd: |-
          kubectl label \
            {{ inventory_hostname }} \
            projectcalico.org/operator-node-migration-
        executable: bash
      become: true
      delegate_to: "{{ kubernetes_config.cluster.prime.name | default(inventory_hostname) }}"
      changed_when: false
      failed_when: false
      loop: "{{ groups[kubernetes_config.cluster.group_name | default('make_me_optional')] | default([]) }}"

Should this be adjusted as well?

@jon_nfc this variable has also been found in another location roles/nfc_kubernetes/tasks/k3s/migrate_to_operator.yaml ```yaml - name: Remove calico migration label ansible.builtin.shell: cmd: |- kubectl label \ {{ inventory_hostname }} \ projectcalico.org/operator-node-migration- executable: bash become: true delegate_to: "{{ kubernetes_config.cluster.prime.name | default(inventory_hostname) }}" changed_when: false failed_when: false loop: "{{ groups[kubernetes_config.cluster.group_name | default('make_me_optional')] | default([]) }}" ``` Should this be adjusted as well?
jon_nfc commented 2024-07-04 05:31:37 +00:00 (Migrated from gitlab.com)
Copy Link

nfc_role_kubernetes_prime is boolean

`nfc_role_kubernetes_prime` is boolean
jon_nfc commented 2024-07-04 05:31:37 +00:00 (Migrated from gitlab.com)
Copy Link

nfc_role_kubernetes_prime is boolean

`nfc_role_kubernetes_prime` is boolean
jon_nfc commented 2024-07-04 05:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

nfc_role_kubernetes_prime is boolean

`nfc_role_kubernetes_prime` is boolean
jon_nfc commented 2024-07-04 05:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

nfc_role_kubernetes_prime is boolean

`nfc_role_kubernetes_prime` is boolean
jon_nfc commented 2024-07-04 05:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

added 3m of time spent

added 3m of time spent
jon_nfc commented 2024-07-04 05:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

requested changes

requested changes
jasonpage.tas commented 2024-07-04 05:37:57 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 576ab623 - fix(kubernetes_role): update var kubernetes_config.cluster.prime.name -> nfc_role_kubernetes_prime

Compare with previous version

added 1 commit <ul><li>576ab623 - fix(kubernetes_role): update var kubernetes_config.cluster.prime.name -&gt; nfc_role_kubernetes_prime</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055216542&start_sha=255cc01b79591acb9a889be1905439a75f6155e9)
jasonpage.tas commented 2024-07-04 05:55:16 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055224205&start_sha=576ab623d8a44cafe9f6a043468014c695931a10#cce8a4eb24927eec9e1e73ced526440013e017c5_12_12)
jasonpage.tas commented 2024-07-04 05:55:17 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055224205&start_sha=576ab623d8a44cafe9f6a043468014c695931a10#cce8a4eb24927eec9e1e73ced526440013e017c5_200_200)
jasonpage.tas commented 2024-07-04 05:55:18 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055224205&start_sha=576ab623d8a44cafe9f6a043468014c695931a10#cce8a4eb24927eec9e1e73ced526440013e017c5_244_244)
jasonpage.tas commented 2024-07-04 05:55:18 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 28c4e3bb - feat(kubernetes_role): set var nfc_role_kubernetes_prime type boolean

Compare with previous version

added 1 commit <ul><li>28c4e3bb - feat(kubernetes_role): set var nfc_role_kubernetes_prime type boolean</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055224205&start_sha=576ab623d8a44cafe9f6a043468014c695931a10)
jasonpage.tas commented 2024-07-04 05:57:08 +00:00 (Migrated from gitlab.com)
Copy Link

@jon_nfc

tentatively requesting a review

@jon_nfc tentatively requesting a review
jasonpage.tas commented 2024-07-04 06:00:10 +00:00 (Migrated from gitlab.com)
Copy Link

missed that one. Also not sure how to do that......

would it be


 `https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443"`
missed that one. Also not sure how to do that...... would it be ```yaml `https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443"` ```
jon_nfc commented 2024-07-04 06:07:02 +00:00 (Migrated from gitlab.com)
Copy Link

requested review from @jon_nfc

requested review from @jon_nfc
jon_nfc commented 2024-07-04 06:18:40 +00:00 (Migrated from gitlab.com)
Copy Link

inventory_hostname is of type string and nfc_role_kubernetes_prime is of type boolean a non-strict logical comparison will fail.

`inventory_hostname` is of type string and `nfc_role_kubernetes_prime` is of type boolean a non-strict logical comparison will fail.
jon_nfc commented 2024-07-04 06:18:40 +00:00 (Migrated from gitlab.com)
Copy Link

review the failed test jobs logs as there is an error in the playbook. if the job fails (there are 4 different os's tested), the deployment should at least pass.

review the failed test jobs logs as there is an error in the playbook. if the job fails (there are 4 different os's tested), the deployment should at least pass.
jon_nfc commented 2024-07-04 06:18:40 +00:00 (Migrated from gitlab.com)
Copy Link

inventory_hostname is of type string and nfc_role_kubernetes_prime is of type boolean a non-strict logical comparison will fail.

`inventory_hostname` is of type string and `nfc_role_kubernetes_prime` is of type boolean a non-strict logical comparison will fail.
jon_nfc commented 2024-07-04 06:18:41 +00:00 (Migrated from gitlab.com)
Copy Link

would it be


`https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443"`

no, as currently https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443" will produce an error which more than likely will crash ansible. however when correctly defined would expand to https://false:6443 or https://true:6443 for non-prime and prime respectively.

inventory_hostname is of type string and nfc_role_kubernetes_prime is of type boolean a non-strict logical comparison will fail.

> would it be > ```yaml > > `https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443"` > ``` no, as currently `https://" + hostvars[nfc_role_kubernetes_prime |default(false) | boolean].ansible_host + ":6443"` will produce an error which more than likely will crash ansible. however when correctly defined would expand to `https://false:6443` or `https://true:6443` for non-prime and prime respectively. `inventory_hostname` is of type string and `nfc_role_kubernetes_prime` is of type boolean a non-strict logical comparison will fail.
jon_nfc commented 2024-07-04 06:18:41 +00:00 (Migrated from gitlab.com)
Copy Link

inventory_hostname is of type string and nfc_role_kubernetes_prime is of type boolean a non-strict logical comparison will fail.

`inventory_hostname` is of type string and `nfc_role_kubernetes_prime` is of type boolean a non-strict logical comparison will fail.
jon_nfc commented 2024-07-04 06:18:42 +00:00 (Migrated from gitlab.com)
Copy Link

point of note when working with logical comparisons is to consider what the values are left and right of the comparitor. if they are not of the same type, generally the comparison will fail without an error, as is the case with python-it will crash and return a stack trace.

point of note when working with logical comparisons is to consider what the values are left and right of the comparitor. if they are not of the same type, generally the comparison will fail without an error, as is the case with python-it will crash and return a stack trace.
jon_nfc commented 2024-07-04 06:18:42 +00:00 (Migrated from gitlab.com)
Copy Link

added 13m of time spent

added 13m of time spent
jon_nfc commented 2024-07-04 06:18:42 +00:00 (Migrated from gitlab.com)
Copy Link

requested changes

requested changes
jasonpage.tas commented 2024-07-04 06:58:43 +00:00 (Migrated from gitlab.com)
Copy Link

Genuinely got no idea

Genuinely got no idea
jasonpage.tas commented 2024-07-04 07:12:31 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055286264&start_sha=28c4e3bbca25c0a86241bc9bff524b03a70d126e#cce8a4eb24927eec9e1e73ced526440013e017c5_12_12)
jasonpage.tas commented 2024-07-04 07:12:32 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055286264&start_sha=28c4e3bbca25c0a86241bc9bff524b03a70d126e#cce8a4eb24927eec9e1e73ced526440013e017c5_200_200)
jasonpage.tas commented 2024-07-04 07:12:32 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 9 of the diff

changed this line in [version 9 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055286264&start_sha=28c4e3bbca25c0a86241bc9bff524b03a70d126e#cce8a4eb24927eec9e1e73ced526440013e017c5_244_244)
jasonpage.tas commented 2024-07-04 07:12:32 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • a2580f93 - fix(kubernetes_roles): update variable nfc_role_kubernetes_prime type to boolean

Compare with previous version

added 1 commit <ul><li>a2580f93 - fix(kubernetes_roles): update variable nfc_role_kubernetes_prime type to boolean</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055286264&start_sha=28c4e3bbca25c0a86241bc9bff524b03a70d126e)
jasonpage.tas commented 2024-07-04 07:41:05 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 10 of the diff

changed this line in [version 10 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055319804&start_sha=a2580f93283317ad9dad8aab50c74020059083b4#cce8a4eb24927eec9e1e73ced526440013e017c5_206_210)
jasonpage.tas commented 2024-07-04 07:41:06 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 14a2cbed - fix(kubernetes_role): set variable prime_hostname

Compare with previous version

added 1 commit <ul><li>14a2cbed - fix(kubernetes_role): set variable prime_hostname</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055319804&start_sha=a2580f93283317ad9dad8aab50c74020059083b4)
jasonpage.tas commented 2024-07-04 07:51:31 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 4d51d3ca - fix(kubernetes_roles): update variable nfc_role_kubernetes_prime |...

Compare with previous version

added 1 commit <ul><li>4d51d3ca - fix(kubernetes_roles): update variable nfc_role_kubernetes_prime |...</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055333615&start_sha=14a2cbed98323bd30c5416a320b8c7622e0e024c)
jasonpage.tas commented 2024-07-04 08:13:03 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 17792262 - tmp test

Compare with previous version

added 1 commit <ul><li>17792262 - tmp test</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055363320&start_sha=4d51d3ca00bb4b2105f5851cd81e792a6533c697)
jasonpage.tas commented 2024-07-04 08:40:42 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 2d5eb7c3 - fix(kubernetes_roles): update cmd for setting ip6tables

Compare with previous version

added 1 commit <ul><li>2d5eb7c3 - fix(kubernetes_roles): update cmd for setting ip6tables</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1055403107&start_sha=4d51d3ca00bb4b2105f5851cd81e792a6533c697)
jasonpage.tas commented 2024-07-05 03:04:07 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 044c9146 - feat(kubernetes_role): nfc_role_kubernetes_prime cast type to bool
  • 55cc0075 - fix(kubernetes_roles): use inventory_hostname

Compare with previous version

added 2 commits <ul><li>044c9146 - feat(kubernetes_role): nfc_role_kubernetes_prime cast type to bool</li><li>55cc0075 - fix(kubernetes_roles): use inventory_hostname</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1056196325&start_sha=2d5eb7c3759a83c67886b081cc8f03aff24cce0e)
jasonpage.tas commented 2024-07-05 03:21:18 +00:00 (Migrated from gitlab.com)
Copy Link

Pipeline passed with errors. The issue is I do not even understand the errors to be able to begin fault finding this.

I did not expect that the changes in 55cc0075 would work. However the error log has confused me further as I cannot see where the unexpected char is.

See error log below:

Error log 

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: . unexpected char '#' at 258
failed: [localhost] (item={'src': 'k3s-config.yaml.j2', 'dest': '/etc/rancher/k3s/config.yaml', 'notify': 'kubernetes_restart'}) => {"ansible_loop_var": "item", "changed": false, "item": {"dest": "/etc/rancher/k3s/config.yaml", "notify": "kubernetes_restart", "src": "k3s-config.yaml.j2"}, "msg": "AnsibleError: template error while templating string: unexpected char '#' at 258. String: #\n# K3s Configuration for running Kubernetes\n#\n# Managed By ansible/role/nfc_kubernetes\n#\n# Dont edit this file directly as it will be overwritten.\n#\n\n{%- if \n  nfc_role_kubernetes_master\n    or\n  nfc_role_kubernetes_prime | default(false) | bool\n-%}\n##  {%\n##\n##  set prime_hostname = inventory_hostname\n##\n##  -%}\n  {%\n\n  set kube_apiserver_arg = [\n        \"audit-log-path=/var/lib/rancher/k3s/server/logs/audit.log\",\n        \"audit-log-maxage=\" + kube_apiserver_arg_audit_log_maxage | string,\n        \"audit-policy-file=/var/lib/rancher/k3s/server/audit.yaml\",\n      ]\n\n\n  -%}\n    {%\n    set servers_config = {\n        \"cluster-cidr\": nfc_role_kubernetes_pod_subnet,\n        \"disable\": [\n          \"traefik\"\n        ],\n        \"disable-network-policy\": true,\n        \"flannel-backend\": \"none\",\n        \"service-cidr\": nfc_role_kubernetes_service_subnet\n      }\n    -%}\n\n    {%- if nfc_role_kubernetes_etcd_enabled -%}\n\n        {%- set servers_config = servers_config | combine({\n          \"etcd-snapshot-retention\": kubernetes_etcd_snapshot_retention | int,\n          \"etcd-snapshot-schedule-cron\":  kubernetes_etcd_snapshot_cron_schedule | string,\n        }) -%}\n\n    {%- endif -%}\n\n    {%- if \n          kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain) is defined\n            and\n          kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain) != ''\n    -%}\n\n        {%- set servers_config = servers_config | combine({\n          \"cluster-domain\": kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain)\n        }) -%}\n\n    {%- endif -%}\n\n    {%- if kubernetes_config.cluster.oidc.enabled | default(nfc_role_kubernetes_oidc_enabled) | default(false) | bool -%}\n\n      {%- \n        set kube_apiserver_arg = kube_apiserver_arg + [\n        \"oidc-client-id=\" + kubernetes_config.cluster.oidc.client_id,\n        \"oidc-groups-claim=\" + kubernetes_config.cluster.oidc.groups_claim,\n        \"oidc-issuer-url=\" + kubernetes_config.cluster.oidc.issuer_url,\n        \"oidc-username-claim=\" + kubernetes_config.cluster.oidc.username_claim\n      ] -%}\n\n      {%- if kubernetes_config.cluster.oidc.oidc_username_prefix | default('') != '' -%}\n\n        {%- set kube_apiserver_arg = kube_apiserver_arg + [\n          \"oidc-username-prefix=\" + kubernetes_config.cluster.oidc.oidc_username_prefix\n        ] -%}\n\n      {%- endif -%}\n\n      {%- if kubernetes_config.cluster.oidc.groups_prefix | default('') != '' -%}\n\n        {%- set kube_apiserver_arg = kube_apiserver_arg + [\n          \"oidc-groups-prefix=\" + kubernetes_config.cluster.oidc.groups_prefix\n        ]\n        -%}\n\n      {%- endif -%}\n\n    {%- endif -%}\n\n\n    {%- if (\n      nfc_kubernetes_enable_metallb | default(false) \n        or \n      not nfc_kubernetes_enable_servicelb | default(false)\n    ) -%}\n\n      {%- set disable = servers_config.disable + [ \"servicelb\" ] -%}\n\n      {%\n      set servers_config = servers_config | combine({\n          \"disable\": disable \n        })\n      -%}\n\n\n    {%- endif -%} \n\n    {%- if (\n      not nfc_kubernetes_enable_metallb | default(false)\n        and\n      nfc_kubernetes_enable_servicelb | default(false)\n    ) -%}\n      \n      {%- set servers_config = servers_config | combine({\n        \"servicelb-namespace\": kubernetes_config.cluster.networking.service_load_balancer_namespace | default('kube-system')\n      }) -%}\n\n    {%- endif -%}\n\n\n{# Combine Remaining Server Objects #}\n\n{%\n  set servers_config = servers_config | combine({\n    \"kube-apiserver-arg\": kube_apiserver_arg\n  })\n-%}\n\n{%- endif -%}\n{# Eof Server Nodes #}\n\n{# SoF All Nodes #}\n\n{%- if inventory_hostname == 'localhost' -%}\n\n  {%- set node_name = hostname_to_check.stdout -%}\n\n{%- else -%}\n\n  {%- set node_name = inventory_hostname -%}\n\n{%- endif -%}\n\n{%\n\n  set all_nodes_config = {\n    \"kubelet-arg\": [\n      \"system-reserved=cpu=\" + kubelet_arg_system_reserved_cpu  + \",memory=\" + kubelet_arg_system_reserved_memory + \n      \",ephemeral-storage=\" + kubelet_arg_system_reserved_storage\n    ],\n    \"node-name\": node_name,\n    \"resolv-conf\": nfc_role_kubernetes_resolv_conf_file,\n  }\n\n-%}\n\n\n{%- if groups[kubernetes_config.cluster.group_name | default('make_me_optional')] | default([]) | list | length > 0 -%}\n  \n  {%- if node_k3s.installed -%}\n\n    {%- set ns = namespace(server=[]) -%}\n\n    {%- for cluster_node in groups[kubernetes_config.cluster.group_name] -%}\n\n      {%- if cluster_node in groups['kubernetes_master'] | default([]) -%}\n\n        {%- if hostvars[cluster_node].host_external_ip is defined -%}\n\n          {%- if\n            hostvars[cluster_node].host_external_ip != ansible_default_ipv4.address\n              and\n            cluster_node == inventory_hostname\n          -%} {# Server self, use internal ip if external ip exists #}\n\n            {%- set server_node = ansible_default_ipv4.address -%}\n\n          {%- else -%}\n\n            {%- set server_node = hostvars[cluster_node].host_external_ip -%}\n          \n          {%- endif -%}\n\n        {%- else -%}\n\n          {%- set server_node = hostvars[cluster_node].ansible_host -%}\n\n        {%- endif -%}\n\n        {%- set ns.server = (ns.server | default([])) + [\n          \"https://\" + server_node + \":6443\"\n        ] -%}\n\n      {%- endif -%}\n\n    {%- endfor -%}\n\n    {%- set all_nodes_config = all_nodes_config | combine({\n      \"server\": ns.server,\n    }) -%}\n\n  {%- elif \n    nfc_role_kubernetes_prime | default(false) | bool\n      and\n    not node_k3s.installed\n  -%}\n\n    {%- set server = (server | default([])) + [\n      \"https://\" + hostvars[inventory_hostname].ansible_host + \":6443\"\n    ] -%}\n\n    {%- set all_nodes_config = all_nodes_config | combine({\n      \"server\": server,\n    }) -%}\n\n  {%- endif -%}\n\n{%- endif -%}\n\n\n\n{%- if\n  host_external_ip is defined\n    and \n  ansible_default_ipv4.address != host_external_ip\n-%}\n  \n  {%- set all_nodes_config = all_nodes_config | combine({\n    \"node-external-ip\": host_external_ip\n   }) -%}\n\n{%- else -%}\n\n  {%- set all_nodes_config = all_nodes_config | combine({\n    \"node-ip\": ansible_default_ipv4.address\n   }) -%}\n  \n\n{%- endif -%}\n\n\n{# EoF All Nodes #}\n\n\n{%- if \n  nfc_role_kubernetes_master\n    or\n  nfc_role_kubernetes_prime | default(false) | bool\n-%}\n\n  {%- set servers_config = servers_config | combine( all_nodes_config ) -%}\n\n  {{ servers_config | to_nice_yaml(indent=2) }}\n\n{%- else -%}\n\n  {{ all_nodes_config | to_nice_yaml(indent=2) }}\n\n{%- endif -%}\n. unexpected char '#' at 258"}
Pipeline passed with errors. The issue is I do not even understand the errors to be able to begin fault finding this. I did not expect that the changes in 55cc0075 would work. However the error log has confused me further as I cannot see where the unexpected char is. See error log below: <details><summary>Error log</summary> ``` An exception occurred during task execution. To see the full traceback, use -vvv. The error was: . unexpected char '#' at 258 failed: [localhost] (item={'src': 'k3s-config.yaml.j2', 'dest': '/etc/rancher/k3s/config.yaml', 'notify': 'kubernetes_restart'}) => {"ansible_loop_var": "item", "changed": false, "item": {"dest": "/etc/rancher/k3s/config.yaml", "notify": "kubernetes_restart", "src": "k3s-config.yaml.j2"}, "msg": "AnsibleError: template error while templating string: unexpected char '#' at 258. String: #\n# K3s Configuration for running Kubernetes\n#\n# Managed By ansible/role/nfc_kubernetes\n#\n# Dont edit this file directly as it will be overwritten.\n#\n\n{%- if \n nfc_role_kubernetes_master\n or\n nfc_role_kubernetes_prime | default(false) | bool\n-%}\n## {%\n##\n## set prime_hostname = inventory_hostname\n##\n## -%}\n {%\n\n set kube_apiserver_arg = [\n \"audit-log-path=/var/lib/rancher/k3s/server/logs/audit.log\",\n \"audit-log-maxage=\" + kube_apiserver_arg_audit_log_maxage | string,\n \"audit-policy-file=/var/lib/rancher/k3s/server/audit.yaml\",\n ]\n\n\n -%}\n {%\n set servers_config = {\n \"cluster-cidr\": nfc_role_kubernetes_pod_subnet,\n \"disable\": [\n \"traefik\"\n ],\n \"disable-network-policy\": true,\n \"flannel-backend\": \"none\",\n \"service-cidr\": nfc_role_kubernetes_service_subnet\n }\n -%}\n\n {%- if nfc_role_kubernetes_etcd_enabled -%}\n\n {%- set servers_config = servers_config | combine({\n \"etcd-snapshot-retention\": kubernetes_etcd_snapshot_retention | int,\n \"etcd-snapshot-schedule-cron\": kubernetes_etcd_snapshot_cron_schedule | string,\n }) -%}\n\n {%- endif -%}\n\n {%- if \n kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain) is defined\n and\n kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain) != ''\n -%}\n\n {%- set servers_config = servers_config | combine({\n \"cluster-domain\": kubernetes_config.cluster.domain_name | default(nfc_role_kubernetes_cluster_domain)\n }) -%}\n\n {%- endif -%}\n\n {%- if kubernetes_config.cluster.oidc.enabled | default(nfc_role_kubernetes_oidc_enabled) | default(false) | bool -%}\n\n {%- \n set kube_apiserver_arg = kube_apiserver_arg + [\n \"oidc-client-id=\" + kubernetes_config.cluster.oidc.client_id,\n \"oidc-groups-claim=\" + kubernetes_config.cluster.oidc.groups_claim,\n \"oidc-issuer-url=\" + kubernetes_config.cluster.oidc.issuer_url,\n \"oidc-username-claim=\" + kubernetes_config.cluster.oidc.username_claim\n ] -%}\n\n {%- if kubernetes_config.cluster.oidc.oidc_username_prefix | default('') != '' -%}\n\n {%- set kube_apiserver_arg = kube_apiserver_arg + [\n \"oidc-username-prefix=\" + kubernetes_config.cluster.oidc.oidc_username_prefix\n ] -%}\n\n {%- endif -%}\n\n {%- if kubernetes_config.cluster.oidc.groups_prefix | default('') != '' -%}\n\n {%- set kube_apiserver_arg = kube_apiserver_arg + [\n \"oidc-groups-prefix=\" + kubernetes_config.cluster.oidc.groups_prefix\n ]\n -%}\n\n {%- endif -%}\n\n {%- endif -%}\n\n\n {%- if (\n nfc_kubernetes_enable_metallb | default(false) \n or \n not nfc_kubernetes_enable_servicelb | default(false)\n ) -%}\n\n {%- set disable = servers_config.disable + [ \"servicelb\" ] -%}\n\n {%\n set servers_config = servers_config | combine({\n \"disable\": disable \n })\n -%}\n\n\n {%- endif -%} \n\n {%- if (\n not nfc_kubernetes_enable_metallb | default(false)\n and\n nfc_kubernetes_enable_servicelb | default(false)\n ) -%}\n \n {%- set servers_config = servers_config | combine({\n \"servicelb-namespace\": kubernetes_config.cluster.networking.service_load_balancer_namespace | default('kube-system')\n }) -%}\n\n {%- endif -%}\n\n\n{# Combine Remaining Server Objects #}\n\n{%\n set servers_config = servers_config | combine({\n \"kube-apiserver-arg\": kube_apiserver_arg\n })\n-%}\n\n{%- endif -%}\n{# Eof Server Nodes #}\n\n{# SoF All Nodes #}\n\n{%- if inventory_hostname == 'localhost' -%}\n\n {%- set node_name = hostname_to_check.stdout -%}\n\n{%- else -%}\n\n {%- set node_name = inventory_hostname -%}\n\n{%- endif -%}\n\n{%\n\n set all_nodes_config = {\n \"kubelet-arg\": [\n \"system-reserved=cpu=\" + kubelet_arg_system_reserved_cpu + \",memory=\" + kubelet_arg_system_reserved_memory + \n \",ephemeral-storage=\" + kubelet_arg_system_reserved_storage\n ],\n \"node-name\": node_name,\n \"resolv-conf\": nfc_role_kubernetes_resolv_conf_file,\n }\n\n-%}\n\n\n{%- if groups[kubernetes_config.cluster.group_name | default('make_me_optional')] | default([]) | list | length > 0 -%}\n \n {%- if node_k3s.installed -%}\n\n {%- set ns = namespace(server=[]) -%}\n\n {%- for cluster_node in groups[kubernetes_config.cluster.group_name] -%}\n\n {%- if cluster_node in groups['kubernetes_master'] | default([]) -%}\n\n {%- if hostvars[cluster_node].host_external_ip is defined -%}\n\n {%- if\n hostvars[cluster_node].host_external_ip != ansible_default_ipv4.address\n and\n cluster_node == inventory_hostname\n -%} {# Server self, use internal ip if external ip exists #}\n\n {%- set server_node = ansible_default_ipv4.address -%}\n\n {%- else -%}\n\n {%- set server_node = hostvars[cluster_node].host_external_ip -%}\n \n {%- endif -%}\n\n {%- else -%}\n\n {%- set server_node = hostvars[cluster_node].ansible_host -%}\n\n {%- endif -%}\n\n {%- set ns.server = (ns.server | default([])) + [\n \"https://\" + server_node + \":6443\"\n ] -%}\n\n {%- endif -%}\n\n {%- endfor -%}\n\n {%- set all_nodes_config = all_nodes_config | combine({\n \"server\": ns.server,\n }) -%}\n\n {%- elif \n nfc_role_kubernetes_prime | default(false) | bool\n and\n not node_k3s.installed\n -%}\n\n {%- set server = (server | default([])) + [\n \"https://\" + hostvars[inventory_hostname].ansible_host + \":6443\"\n ] -%}\n\n {%- set all_nodes_config = all_nodes_config | combine({\n \"server\": server,\n }) -%}\n\n {%- endif -%}\n\n{%- endif -%}\n\n\n\n{%- if\n host_external_ip is defined\n and \n ansible_default_ipv4.address != host_external_ip\n-%}\n \n {%- set all_nodes_config = all_nodes_config | combine({\n \"node-external-ip\": host_external_ip\n }) -%}\n\n{%- else -%}\n\n {%- set all_nodes_config = all_nodes_config | combine({\n \"node-ip\": ansible_default_ipv4.address\n }) -%}\n \n\n{%- endif -%}\n\n\n{# EoF All Nodes #}\n\n\n{%- if \n nfc_role_kubernetes_master\n or\n nfc_role_kubernetes_prime | default(false) | bool\n-%}\n\n {%- set servers_config = servers_config | combine( all_nodes_config ) -%}\n\n {{ servers_config | to_nice_yaml(indent=2) }}\n\n{%- else -%}\n\n {{ all_nodes_config | to_nice_yaml(indent=2) }}\n\n{%- endif -%}\n. unexpected char '#' at 258"} ``` </details>
jasonpage.tas commented 2024-07-05 03:24:12 +00:00 (Migrated from gitlab.com)
Copy Link

Changed

Changed
jon_nfc commented 2024-07-05 03:39:13 +00:00 (Migrated from gitlab.com)
Copy Link

to comment out an item in jinga substitute the % for #. i.e. {% jinja %} would become {# jinja #}.

any jinja placed within a standard comment line (prefixed with #), will still be parsed by the jinja templating engine.

to comment out an item in jinga substitute the `%` for `#`. i.e. `{% jinja %}` would become `{# jinja #}`. any jinja placed within a standard comment line (prefixed with `#`), will still be parsed by the jinja templating engine.
jon_nfc commented 2024-07-05 03:39:13 +00:00 (Migrated from gitlab.com)
Copy Link

added 5m of time spent

added 5m of time spent
jon_nfc commented 2024-07-05 03:39:13 +00:00 (Migrated from gitlab.com)
Copy Link

requested changes

requested changes
jasonpage.tas commented 2024-07-05 04:51:15 +00:00 (Migrated from gitlab.com)
Copy Link

I can make that change but it will likely use my remaining compute usage. I'm at 346 of 400 for this month.

I can make that change but it will likely use my remaining compute usage. I'm at 346 of 400 for this month.
jasonpage.tas commented 2024-07-06 02:23:56 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1057147703&start_sha=55cc007575301aa732052f3afcc55069bf7d92e3#cce8a4eb24927eec9e1e73ced526440013e017c5_18_14)
jasonpage.tas commented 2024-07-06 02:23:56 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 23808704 - fix(kubernetes_role): remove commented out section

Compare with previous version

added 1 commit <ul><li>23808704 - fix(kubernetes_role): remove commented out section</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1057147703&start_sha=55cc007575301aa732052f3afcc55069bf7d92e3)
jasonpage.tas commented 2024-07-06 03:03:36 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • d59f2007 - test(kubernetes_role): set prime default value to true

Compare with previous version

added 1 commit <ul><li>d59f2007 - test(kubernetes_role): set prime default value to true</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/74/diffs?diff_id=1057151286&start_sha=23808704aefc1594bbfccf8562115dc1923c7fb8)
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 576ab623d8

mentioned in commit 576ab623d8a44cafe9f6a043468014c695931a10
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 14a2cbed98

mentioned in commit 14a2cbed98323bd30c5416a320b8c7622e0e024c
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 55cc007575

mentioned in commit 55cc007575301aa732052f3afcc55069bf7d92e3
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 4d51d3ca00

mentioned in commit 4d51d3ca00bb4b2105f5851cd81e792a6533c697
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 2d5eb7c375

mentioned in commit 2d5eb7c3759a83c67886b081cc8f03aff24cce0e
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a2580f9328

mentioned in commit a2580f93283317ad9dad8aab50c74020059083b4
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 044c914617

mentioned in commit 044c914617460b2bd48644d6ee3420160bf52fb4
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 28c4e3bbca

mentioned in commit 28c4e3bbca25c0a86241bc9bff524b03a70d126e
jasonpage.tas commented 2024-07-06 03:25:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit f5bba112cf

mentioned in commit f5bba112cf9858b3935c3fa66aea7e46183901fa
jon_nfc commented 2024-07-06 03:30:22 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !75

mentioned in merge request !75
jon_nfc commented 2024-07-06 03:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

closing in favour of !75

closing in favour of !75
jon_nfc commented 2024-07-06 03:31:38 +00:00 (Migrated from gitlab.com)
Copy Link

added 1m of time spent

added 1m of time spent
jon_nfc (Migrated from gitlab.com) closed this pull request 2024-07-06 03:31:38 +00:00
jasonpage.tas commented 2024-07-08 02:02:31 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit d59f20077e

mentioned in commit d59f20077ecbb58eab4a7abf17d2cb39ff442120
jasonpage.tas commented 2024-07-08 02:02:31 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 23808704ae

mentioned in commit 23808704aefc1594bbfccf8562115dc1923c7fb8

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
v1.0.0
Version that is affected
v1.0.1
Version that is affected
v1.1.0
Version that is affected
v1.1.1
Version that is affected
v1.1.2
Version that is affected
v1.10.0
Version that is affected
v1.10.1
Version that is affected
v1.10.2
Version that is affected
v1.10.3
Version that is affected
v1.11.0
Version that is affected
v1.12.0
Version that is affected
v1.13.0
Version that is affected
v1.13.1
Version that is affected
v1.13.2
Version that is affected
v1.2.0
Version that is affected
v1.3.0
Version that is affected
v1.4.0
Version that is affected
v1.5.0
Version that is affected
v1.6.0
Version that is affected
v1.7.0
Version that is affected
v1.7.1
Version that is affected
v1.7.2
Version that is affected
v1.8.0
Version that is affected
v1.8.1-a1
Version that is affected
v1.8.1-a2
Version that is affected
v1.9.0
Version that is affected
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ansible-collections/kubernetes#108
No description provided.
Delete Branch "fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?