fix(kebernetes): Apply fixes listed in issues #109
Merged
jon_nfc
merged 25 commits from 2024-07-08 02:02:30 +00:00
fixes
into development
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
v1.0.0
Version that is affected
v1.0.1
Version that is affected
v1.1.0
Version that is affected
v1.1.1
Version that is affected
v1.1.2
Version that is affected
v1.10.0
Version that is affected
v1.10.1
Version that is affected
v1.10.2
Version that is affected
v1.10.3
Version that is affected
v1.11.0
Version that is affected
v1.12.0
Version that is affected
v1.13.0
Version that is affected
v1.13.1
Version that is affected
v1.13.2
Version that is affected
v1.2.0
Version that is affected
v1.3.0
Version that is affected
v1.4.0
Version that is affected
v1.5.0
Version that is affected
v1.6.0
Version that is affected
v1.7.0
Version that is affected
v1.7.1
Version that is affected
v1.7.2
Version that is affected
v1.8.0
Version that is affected
v1.8.1-a1
Version that is affected
v1.8.1-a2
Version that is affected
v1.9.0
Version that is affected
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
Milestone
No items
No Milestone
Projects
Clear projects
No project
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: ansible-collections/kubernetes#109
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
No description provided.
Delete Branch "fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📚 Summary
🔗 Links / References
👷 Tasks
Playbook Update
This collection has a corresponding playbook that may need to be updated (Ansible Role), specifically Role Validation.
NetBox Rendered Config Update
This Collection has a NetBox Rendered Config template that may need to be updated. Specifically Section
cluster.type == 'kubernetes'
added 15m of time spent
assigned to @jasonpage.tas
requested review from @jon_nfc
mentioned in merge request !74
added 10m of time spent
approved this merge request
unapproved this merge request
added 10m of time spent
mentioned in commit
8217889910
added 1 commit
82178899
- test(kubernetes_role): set not nfc_role_kubernetes_cluster_upgraded |...Compare with previous version
mentioned in commit
536bab4ce2
added 1 commit
536bab4c
- fix(kubernetes_role): undo previous changeCompare with previous version
mentioned in commit
a8ddcad1a0
added 1 commit
a8ddcad1
- fix(kubernetes_role): remove not nfc_role_kubernetes_cluster_upgraded |...Compare with previous version
I'm going around in circles. Stopping for the day as not getting anywhere.
added 3h of time spent
mentioned in commit
6bd8d27cfd
added 1 commit
6bd8d27c
- fix(kubernetes_role): set server var -> "https://" +...Compare with previous version
mentioned in commit
8c1223769d
added 1 commit
8c122376
- fix(kubernetes_role): get prime hostnameCompare with previous version
mentioned in commit
860addad4d
added 1 commit
860addad
- fix(kubernetes_role): Change "https://" + hostvars[ns.prime_name].ansible_host...Compare with previous version
mentioned in commit
202e92a90b
added 1 commit
202e92a9
- fix(kubernetes_role): delete leftover ]Compare with previous version
@jon_nfc pipelines passed but I am unable to determine if the changes have worked. Can you code review and make any suggestions.
added 4h of time spent
dont forget to clean up the whitespace with the
-
symbolminor changes required:
added 10m of time spent
requested changes
mentioned in commit
98b6442bf8
added 1 commit
98b6442b
- fix(kubernetes_roles): clean up white spaceCompare with previous version
mentioned in commit
6275dde9e3
changed this line in version 10 of the diff
added 1 commit
6275dde9
- fix(kubernetes_roles): clean up white spaceCompare with previous version
changed this line in version 11 of the diff
mentioned in commit
6893164f90
added 1 commit
6893164f
- fix(kubernetes_roles): clean up white spaceCompare with previous version
mentioned in commit
115755ad54
changed this line in version 12 of the diff
added 1 commit
115755ad
- fix(kubernetes_roles): clean up white spaceCompare with previous version
mentioned in commit
cf63ec5543
changed this line in version 13 of the diff
added 1 commit
cf63ec55
- fix(kubernetes_roles): conditional checks for primeCompare with previous version
mentioned in commit
425e05de37
added 1 commit
425e05de
- fix(kubernetes_roles): conditional checks for primeCompare with previous version
resolved all threads
mentioned in commit
cba13dd8a3
added 1 commit
cba13dd8
- fix(kubernetes_roles): conditional checks for primeCompare with previous version
requested review from @jon_nfc
added 2m of time spent
mentioned in commit
f3f2769f0a
approved this merge request
mentioned in commit
b47b868f43