ansible-collections/kubernetes
2
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Projects Releases 28 Wiki Activity

feat(nfc_kubernetes): ability to add node labels and taints #111

Merged
jon_nfc merged 2 commits from node-labels-taints into development 2024-07-28 06:23:03 +00:00
Conversation 18 Commits 2 Files Changed 2 +26 -6
jon_nfc commented 2024-07-28 06:01:06 +00:00 (Migrated from gitlab.com)
Copy Link

📚 Summary

correct logic to new vars

🔗 Links / References

👷 Tasks

  • Add your tasks here if required (delete)
### :books: Summary <!-- your summary here emojis ref: https://github.com/yodamad/gitlab-emoji --> correct logic to new vars ### :link: Links / References <!-- using a list as any links to other references or links as required. if relevent, describe the link/reference --> ### :construction_worker: Tasks - [ ] Add your tasks here if required (delete) <!-- dont remove tasks below strike through including the checkbox by enclosing in double tidle '~~' --> - [ ] Playbook Update This collection has a [corresponding playbook](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/role.yaml) that may need to be updated (Ansible Role), specifically [Role Validation](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/tasks/role/validation/nfc_kubernetes.yaml). - [x] NetBox Rendered Config Update This Collection has a [NetBox Rendered Config template](https://gitlab.com/nofusscomputing/infrastructure/configuration-management/netbox/-/blob/development/templates/cluster.json.j2) that may need to be updated. Specifically Section `cluster.type == 'kubernetes'`
jon_nfc commented 2024-07-28 06:01:06 +00:00 (Migrated from gitlab.com)
Copy Link

added 2m of time spent

added 2m of time spent
jon_nfc commented 2024-07-28 06:01:06 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jon_nfc

assigned to @jon_nfc
jon_nfc (Migrated from gitlab.com) approved these changes 2024-07-28 06:01:06 +00:00
jon_nfc commented 2024-07-28 06:10:30 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 3c06647637

mentioned in commit 3c06647637b89b67bb330c28549314bb36efbd81
jon_nfc commented 2024-07-28 06:10:31 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 3c066476 - feat(nfc_kubernetes): prime node to always be labeled prime

Compare with previous version

added 1 commit <ul><li>3c066476 - feat(nfc_kubernetes): prime node to always be labeled prime</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/77/diffs?diff_id=1076464892&start_sha=6d26e2e0cf8d987d5c5e5007d3685ee1f37a1d6b)
jon_nfc commented 2024-07-28 06:10:50 +00:00 (Migrated from gitlab.com)
Copy Link

marked the checklist item NetBox Rendered Config Update as completed

marked the checklist item **NetBox Rendered Config Update** as completed
jon_nfc commented 2024-07-28 06:13:01 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !78

mentioned in merge request !78
jon_nfc commented 2024-07-28 06:14:14 +00:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
jon_nfc (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2024-07-28 06:14:14 +00:00
jon_nfc commented 2024-07-28 06:14:15 +00:00 (Migrated from gitlab.com)
Copy Link

added 15m of time spent

added 15m of time spent
jon_nfc commented 2024-07-28 06:23:03 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 9f3fcdc5e3

mentioned in commit 9f3fcdc5e3be3a2c801753e9db6160b6f6f3e6ce
jon_nfc (Migrated from gitlab.com) merged commit 9f3fcdc5e3 into development 2024-07-28 06:23:03 +00:00
jon_nfc commented 2024-07-28 06:26:12 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit nofusscomputing/projects/ansible/execution_environment@1fd28222daff27ebf0c038bd56e7115840396734

mentioned in commit nofusscomputing/projects/ansible/execution_environment@1fd28222daff27ebf0c038bd56e7115840396734
nfc_bot commented 2024-07-28 06:36:21 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 06f44f5c3b

mentioned in commit 06f44f5c3b2c4d1d1289848d84fa2d053d1a26df
jon_nfc commented 2024-07-28 07:57:57 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit c204539b67

mentioned in commit c204539b67a59a40ec16eba76488ba3b1c48bcd4
jon_nfc commented 2024-07-28 08:00:52 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit nofusscomputing/projects/ansible/execution_environment@25bfcf6679d64e9338873765e8598689d282b746

mentioned in commit nofusscomputing/projects/ansible/execution_environment@25bfcf6679d64e9338873765e8598689d282b746
nfc_bot commented 2024-07-28 08:11:43 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 6581056bc9

mentioned in commit 6581056bc9ed28b8e9b3702b8aadd1d2b6c03dea
jon_nfc commented 2024-07-30 05:17:35 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit ce8143f52d

mentioned in commit ce8143f52d37c61aef756fc0314523e86ce5f8ed
jon_nfc commented 2024-07-30 05:20:47 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit nofusscomputing/projects/ansible/execution_environment@67bf6c4b6a650248cc6fd40b7310fe808c262e04

mentioned in commit nofusscomputing/projects/ansible/execution_environment@67bf6c4b6a650248cc6fd40b7310fe808c262e04
nfc_bot commented 2024-07-30 05:31:01 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a6aeac42c8

mentioned in commit a6aeac42c85d72ffa394c304df3686b012ee090d
Sign in to join this conversation.
Reviewers
No Reviewers
jon_nfc
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
v1.0.0
Version that is affected
v1.0.1
Version that is affected
v1.1.0
Version that is affected
v1.1.1
Version that is affected
v1.1.2
Version that is affected
v1.10.0
Version that is affected
v1.10.1
Version that is affected
v1.10.2
Version that is affected
v1.10.3
Version that is affected
v1.11.0
Version that is affected
v1.12.0
Version that is affected
v1.13.0
Version that is affected
v1.13.1
Version that is affected
v1.13.2
Version that is affected
v1.2.0
Version that is affected
v1.3.0
Version that is affected
v1.4.0
Version that is affected
v1.5.0
Version that is affected
v1.6.0
Version that is affected
v1.7.0
Version that is affected
v1.7.1
Version that is affected
v1.7.2
Version that is affected
v1.8.0
Version that is affected
v1.8.1-a1
Version that is affected
v1.8.1-a2
Version that is affected
v1.9.0
Version that is affected
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
v1.12.0
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ansible-collections/kubernetes#111
No description provided.
Delete Branch "node-labels-taints"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?