fix: "migrate role for Ansible Upgrade 2.14.5->2.16.1" #49

2023-12-08T11:20:50Z

jon_nfc commented

2023-12-08 11:20:50 +00:00

(Migrated from gitlab.com)

related #16

jon_nfc commented

2023-12-08 11:20:51 +00:00

(Migrated from gitlab.com)

assigned to @jon_nfc

jon_nfc commented

2023-12-08 11:21:26 +00:00

(Migrated from gitlab.com)

mentioned in merge request nofusscomputing/infrastructure/configuration-management/project-production!17

jon_nfc commented

2023-12-08 11:30:39 +00:00

(Migrated from gitlab.com)

wrong var - investigate

TASK [Expand and add Kubernetes template manifest files] ********************************************************************************************************************************************************
task path: /home/sysadmin/git/project-production/playbooks/kubernetes/master.yaml:137
skipping: [oracle] => {"changed": false, "skipped_reason": "No items in the list"}
NOTIFIED HANDLER nfc_firewall : Configure Firewall rules for oracle
NOTIFIED HANDLER nfc_firewall : Configure Firewall access rules for oracle
NOTIFIED HANDLER nfc_firewall : Configure_fail2ban for oracle
NOTIFIED HANDLER nfc_kubernetes : Restart Kubernetes for oracle

RUNNING HANDLER [nfc_kubernetes : Restart Kubernetes] ***********************************************************************************************************************************************************
task path: /home/sysadmin/aa-shits-and-gigs/ansible-roles-repo/nfc_kubernetes/handlers/main.yml:17
skipping: [oracle] => {"changed": false, "false_condition": "kubernetes_config.cluster.prime.name != inventory_hostname", "skip_reason": "Conditional result was False"}

RUNNING HANDLER [nfc_firewall : Configure_fail2ban]

the skip result var "kubernetes_config.cluster.prime.name != inventory_hostname" downt exist on the handler

# wrong var - investigate ``` bash TASK [Expand and add Kubernetes template manifest files] ******************************************************************************************************************************************************** task path: /home/sysadmin/git/project-production/playbooks/kubernetes/master.yaml:137 skipping: [oracle] => {"changed": false, "skipped_reason": "No items in the list"} NOTIFIED HANDLER nfc_firewall : Configure Firewall rules for oracle NOTIFIED HANDLER nfc_firewall : Configure Firewall access rules for oracle NOTIFIED HANDLER nfc_firewall : Configure_fail2ban for oracle NOTIFIED HANDLER nfc_kubernetes : Restart Kubernetes for oracle RUNNING HANDLER [nfc_kubernetes : Restart Kubernetes] *********************************************************************************************************************************************************** task path: /home/sysadmin/aa-shits-and-gigs/ansible-roles-repo/nfc_kubernetes/handlers/main.yml:17 skipping: [oracle] => {"changed": false, "false_condition": "kubernetes_config.cluster.prime.name != inventory_hostname", "skip_reason": "Conditional result was False"} RUNNING HANDLER [nfc_firewall : Configure_fail2ban] ``` the skip result var `"kubernetes_config.cluster.prime.name != inventory_hostname"` downt exist on the handler

jon_nfc commented

2023-12-08 11:30:39 +00:00

(Migrated from gitlab.com)

added 10m of time spent

jon_nfc commented

2023-12-08 11:46:40 +00:00

(Migrated from gitlab.com)

in the same play run the non-prime node is correct

RUNNING HANDLER [nfc_kubernetes : Restart Kubernetes] ***********************************************************************************************************************************************************
task path: /home/sysadmin/aa-shits-and-gigs/ansible-roles-repo/nfc_kubernetes/handlers/main.yml:17
skipping: [host] => {"changed": false, "false_condition": "not (\n  nfc_kubernetes_no_restart\n    or\n  (\n    inventory_hostname in kubernetes_master\n      and\n    nfc_kubernetes_no_restart_master\n  )\n    or\n  (\n    inventory_hostname == kubernetes_config.config.prime.name\n      and\n    nfc_kubernetes_no_restart_prime\n  )\n    or\n  (\n    inventory_hostname in kubernetes_worker\n      and\n    nfc_kubernetes_no_restart_slave\n  )\n)", "skip_reason": "Conditional result was False"}

in the same play run the non-prime node is correct ``` bash RUNNING HANDLER [nfc_kubernetes : Restart Kubernetes] *********************************************************************************************************************************************************** task path: /home/sysadmin/aa-shits-and-gigs/ansible-roles-repo/nfc_kubernetes/handlers/main.yml:17 skipping: [host] => {"changed": false, "false_condition": "not (\n nfc_kubernetes_no_restart\n or\n (\n inventory_hostname in kubernetes_master\n and\n nfc_kubernetes_no_restart_master\n )\n or\n (\n inventory_hostname == kubernetes_config.config.prime.name\n and\n nfc_kubernetes_no_restart_prime\n )\n or\n (\n inventory_hostname in kubernetes_worker\n and\n nfc_kubernetes_no_restart_slave\n )\n)", "skip_reason": "Conditional result was False"} ```

jon_nfc commented

2023-12-08 12:20:49 +00:00

(Migrated from gitlab.com)

mentioned in commit c04b12a714

mentioned in commit c04b12a714a998dbe50256fb4f7f0c7f54f56536

jon_nfc commented

2023-12-08 12:20:49 +00:00

(Migrated from gitlab.com)

mentioned in commit 26120c3e98

mentioned in commit 26120c3e9846c11c45f5c8d2257cf29e63be86a6

jon_nfc commented

2023-12-08 12:20:49 +00:00

(Migrated from gitlab.com)

added 2 commits

26120c3e - fix(handler): kubernetes restart when clause corrected
c04b12a7 - refactor(tasks): ensure module FQCN is used

Compare with previous version

added 2 commits <ul><li>26120c3e - fix(handler): kubernetes restart when clause corrected</li><li>c04b12a7 - refactor(tasks): ensure module FQCN is used</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/kubernetes/-/merge_requests/15/diffs?diff_id=867282066&start_sha=f2c833893f7ae13ba60c55f59b877c4db871fbdf)

jon_nfc commented

2023-12-08 12:21:53 +00:00

(Migrated from gitlab.com)

going to let this play out and resolve thread as complete as running the role multiple times yields no difference in results.

jon_nfc commented

2023-12-08 12:21:54 +00:00

(Migrated from gitlab.com)

resolved all threads

jon_nfc commented

2023-12-08 12:22:24 +00:00

(Migrated from gitlab.com)

added 52m of time spent

jon_nfc (Migrated from gitlab.com) merged commit 8e3217d1bd into development

2023-12-08 12:22:26 +00:00

jon_nfc commented

2023-12-08 12:22:27 +00:00

(Migrated from gitlab.com)

mentioned in commit 8e3217d1bd

mentioned in commit 8e3217d1bd7e7f1cf5bad428f732cc45c6f21c5e

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: ansible-collections/kubernetes#49