fix: Dont rush to release next time jon #76

added 2 commits <ul><li>dec65ed5 - fix(install): use correct var type for packages</li><li>622338e4 - fix: add missing dependency ansible.posix</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952700400&start_sha=71d1dd884efadec649a75aeb56ca57f87c837580)

jon_nfc commented

2024-03-13 15:03:35 +00:00

(Migrated from gitlab.com)

fix


TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Intial required templates] *********************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master'
failed: [localhost] (item={'src': 'k3s-config.yaml.j2', 'dest': '/etc/rancher/k3s/config.yaml', 'notify': 'kubernetes_restart'}) => {"ansible_loop_var": "item", "changed": false, "item": {"dest": "/etc/rancher/k3s/config.yaml", "notify": "kubernetes_restart", "src": "k3s-config.yaml.j2"}, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master'"}

# fix ``` bash TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Intial required templates] ********************************************************************************************************************************* An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master' failed: [localhost] (item={'src': 'k3s-config.yaml.j2', 'dest': '/etc/rancher/k3s/config.yaml', 'notify': 'kubernetes_restart'}) => {"ansible_loop_var": "item", "changed": false, "item": {"dest": "/etc/rancher/k3s/config.yaml", "notify": "kubernetes_restart", "src": "k3s-config.yaml.j2"}, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master'"} ```

jon_nfc commented

2024-03-13 15:13:44 +00:00

(Migrated from gitlab.com)

mentioned in commit c9961973e1

mentioned in commit c9961973e12a1dd60dff1dfc5d5be99a4cde36e9

jon_nfc commented

2024-03-13 15:13:45 +00:00

(Migrated from gitlab.com)

added 1 commit

c9961973 - fix: limit the use of master group

Compare with previous version

added 1 commit <ul><li>c9961973 - fix: limit the use of master group</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952717184&start_sha=622338e4971e7a1fe416a34cec3e4487d916a381)

jon_nfc commented

2024-03-13 15:15:38 +00:00

(Migrated from gitlab.com)

fix

TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Intial required templates] *********************************************************************************************************************************
--- before: /etc/rancher/k3s/config.yaml
+++ after: /root/.ansible/tmp/ansible-local-335170hmiqhmzc/tmpbbunio5w/k3s-config.yaml.j2
@@ -21,5 +21,5 @@
 kubelet-arg:
 - system-reserved=cpu=450m,memory=512Mi,ephemeral-storage=8Gi
 node-ip: 192.168.122.97
-node-name: vm-test
+node-name: localhost
 service-cidr: 172.16.244.0/22

when inventory_hostname == localhost use hostname -f for node name

# fix ``` bash TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Intial required templates] ********************************************************************************************************************************* --- before: /etc/rancher/k3s/config.yaml +++ after: /root/.ansible/tmp/ansible-local-335170hmiqhmzc/tmpbbunio5w/k3s-config.yaml.j2 @@ -21,5 +21,5 @@ kubelet-arg: - system-reserved=cpu=450m,memory=512Mi,ephemeral-storage=8Gi node-ip: 192.168.122.97 -node-name: vm-test +node-name: localhost service-cidr: 172.16.244.0/22 ``` when inventory_hostname == localhost use hostname -f for node name

jon_nfc commented

2024-03-13 15:15:59 +00:00

(Migrated from gitlab.com)

fixed in c9961973e1

fixed in c9961973e12a1dd60dff1dfc5d5be99a4cde36e9

jon_nfc commented

2024-03-13 15:18:19 +00:00

(Migrated from gitlab.com)

fix


RUNNING HANDLER [nofusscomputing.kubernetes.nfc_kubernetes : Restart Kubernetes] **********************************************************************************************************************************
fatal: [localhost]: FAILED! => {"msg": "The conditional check 'not (
  nfc_kubernetes_no_restart
    or
  (
    inventory_hostname in groups['kubernetes_master']
      and
    nfc_kubernetes_no_restart_master
  )
    or
  (
    inventory_hostname == kubernetes_config.cluster.prime.name
      and
    nfc_kubernetes_no_restart_prime
  )
    or
  (
    inventory_hostname in groups['kubernetes_worker']
      and
    nfc_kubernetes_no_restart_slave
  )
)' failed. The error was: error while evaluating conditional (not (
  nfc_kubernetes_no_restart
    or
  (
    inventory_hostname in groups['kubernetes_master']
      and
    nfc_kubernetes_no_restart_master
  )
    or
  (
    inventory_hostname == kubernetes_config.cluster.prime.name
      and
    nfc_kubernetes_no_restart_prime
  )
    or
  (
    inventory_hostname in groups['kubernetes_worker']
      and
    nfc_kubernetes_no_restart_slave
  )
)): 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master'

The error appears to be in '/root/.ansible/collections/ansible_collections/nofusscomputing/kubernetes/roles/nfc_kubernetes/handlers/main.yml': line 17, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


- name: Restart Kubernetes
  ^ here
"}

# fix ``` bash RUNNING HANDLER [nofusscomputing.kubernetes.nfc_kubernetes : Restart Kubernetes] ********************************************************************************************************************************** fatal: [localhost]: FAILED! => {"msg": "The conditional check 'not ( nfc_kubernetes_no_restart or ( inventory_hostname in groups['kubernetes_master'] and nfc_kubernetes_no_restart_master ) or ( inventory_hostname == kubernetes_config.cluster.prime.name and nfc_kubernetes_no_restart_prime ) or ( inventory_hostname in groups['kubernetes_worker'] and nfc_kubernetes_no_restart_slave ) )' failed. The error was: error while evaluating conditional (not ( nfc_kubernetes_no_restart or ( inventory_hostname in groups['kubernetes_master'] and nfc_kubernetes_no_restart_master ) or ( inventory_hostname == kubernetes_config.cluster.prime.name and nfc_kubernetes_no_restart_prime ) or ( inventory_hostname in groups['kubernetes_worker'] and nfc_kubernetes_no_restart_slave ) )): 'dict object' has no attribute 'kubernetes_master'. 'dict object' has no attribute 'kubernetes_master' The error appears to be in '/root/.ansible/collections/ansible_collections/nofusscomputing/kubernetes/roles/nfc_kubernetes/handlers/main.yml': line 17, column 3, but may be elsewhere in the file depending on the exact syntax problem. The offending line appears to be: - name: Restart Kubernetes ^ here "} ```

jon_nfc commented

2024-03-13 15:21:44 +00:00

(Migrated from gitlab.com)

mentioned in commit b4ad0a4e61

mentioned in commit b4ad0a4e617f8a7fc58c02ca594441f2905a7cd1

jon_nfc commented

2024-03-13 15:21:45 +00:00

(Migrated from gitlab.com)

added 1 commit

b4ad0a4e - fix(config): if hostname=localhost use hostname command to fetch hostname

Compare with previous version

added 1 commit <ul><li>b4ad0a4e - fix(config): if hostname=localhost use hostname command to fetch hostname</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952729687&start_sha=c9961973e12a1dd60dff1dfc5d5be99a4cde36e9)

jon_nfc commented

2024-03-13 15:21:56 +00:00

(Migrated from gitlab.com)

b4ad0a4e61

b4ad0a4e617f8a7fc58c02ca594441f2905a7cd1

jon_nfc commented

2024-03-13 15:26:28 +00:00

(Migrated from gitlab.com)

mentioned in commit 5444f583e5

mentioned in commit 5444f583e5da0c6989fc6cbd151425bebdd67b31

jon_nfc commented

2024-03-13 15:26:36 +00:00

(Migrated from gitlab.com)

added 1 commit

5444f583 - fix(handler): kubernetes restart handler now using updated node type vars

Compare with previous version

added 1 commit <ul><li>5444f583 - fix(handler): kubernetes restart handler now using updated node type vars</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952737362&start_sha=b4ad0a4e617f8a7fc58c02ca594441f2905a7cd1)

jon_nfc commented

2024-03-13 15:30:27 +00:00

(Migrated from gitlab.com)

mentioned in commit a23bc5e9ee

mentioned in commit a23bc5e9eee67de6f54cd3ed98245aafb2f9c43c

jon_nfc commented

2024-03-13 15:30:29 +00:00

(Migrated from gitlab.com)

added 1 commit

a23bc5e9 - fix(handler): remove old k8s code causing handler to fail

Compare with previous version

added 1 commit <ul><li>a23bc5e9 - fix(handler): remove old k8s code causing handler to fail</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952743147&start_sha=5444f583e5da0c6989fc6cbd151425bebdd67b31)

jon_nfc commented

2024-03-13 15:32:38 +00:00

(Migrated from gitlab.com)

- 5444f583e5da0c6989fc6cbd151425bebdd67b31 - a23bc5e9eee67de6f54cd3ed98245aafb2f9c43c

jon_nfc commented

2024-03-13 15:33:54 +00:00

(Migrated from gitlab.com)

resolved all threads

jon_nfc commented

2024-03-13 15:41:23 +00:00

(Migrated from gitlab.com)

fix

firewall install optional

TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Templates] *************************************************************************************************************************************************
changed: [localhost] => (item={'src': 'kubernetes-manifest-rbac.yaml.j2', 'dest': '/var/lib/rancher/k3s/server/manifests/rbac-authorization-common.yaml', 'when': True})
ok: [localhost] => (item={'src': 'iptables-kubernetes.rules.j2', 'dest': '/etc/iptables.rules.d/iptables-kubernetes.rules', 'notify': 'firewall_reloader', 'when': True})
ERROR! The requested handler 'firewall_reloader' was not found in either the main handlers list nor in the listening handlers list

# fix firewall install optional ``` bash TASK [nofusscomputing.kubernetes.nfc_kubernetes : Copy Templates] ************************************************************************************************************************************************* changed: [localhost] => (item={'src': 'kubernetes-manifest-rbac.yaml.j2', 'dest': '/var/lib/rancher/k3s/server/manifests/rbac-authorization-common.yaml', 'when': True}) ok: [localhost] => (item={'src': 'iptables-kubernetes.rules.j2', 'dest': '/etc/iptables.rules.d/iptables-kubernetes.rules', 'notify': 'firewall_reloader', 'when': True}) ERROR! The requested handler 'firewall_reloader' was not found in either the main handlers list nor in the listening handlers list ```

jon_nfc commented

2024-03-13 15:45:16 +00:00

(Migrated from gitlab.com)

mentioned in commit 536c6e7b26

mentioned in commit 536c6e7b260eae835094f3b3ca10b8a587b071a7

jon_nfc commented

2024-03-13 15:45:16 +00:00

(Migrated from gitlab.com)

added 1 commit

536c6e7b - fix(configure): dont attempt to configure firewall if install=false

Compare with previous version

added 1 commit <ul><li>536c6e7b - fix(configure): dont attempt to configure firewall if install=false</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952765385&start_sha=a23bc5e9eee67de6f54cd3ed98245aafb2f9c43c)

jon_nfc commented

2024-03-13 15:45:27 +00:00

(Migrated from gitlab.com)

536c6e7b26

536c6e7b260eae835094f3b3ca10b8a587b071a7

jon_nfc commented

2024-03-13 15:55:22 +00:00

(Migrated from gitlab.com)

resolved all threads

jon_nfc commented

2024-03-13 15:55:56 +00:00

(Migrated from gitlab.com)

fix

the collection build contains extra files

# fix the collection build contains extra files

jon_nfc commented

2024-03-13 16:08:26 +00:00

(Migrated from gitlab.com)

mentioned in commit f0f5d686fa

mentioned in commit f0f5d686fa8eec10ea155b0e05d5f87f5ce8fff8

jon_nfc commented

2024-03-13 16:08:26 +00:00

(Migrated from gitlab.com)

mentioned in commit 173c840121

mentioned in commit 173c840121bb3decf3275993d2e74f4c664014c0

jon_nfc commented

2024-03-13 16:08:27 +00:00

(Migrated from gitlab.com)

added 2 commits

f0f5d686 - chore: correct galaxy build ignores
173c8401 - fix(readme): update gitlab links to new loc

Compare with previous version

added 2 commits <ul><li>f0f5d686 - chore: correct galaxy build ignores</li><li>173c8401 - fix(readme): update gitlab links to new loc</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/42/diffs?diff_id=952799417&start_sha=536c6e7b260eae835094f3b3ca10b8a587b071a7)

jon_nfc commented

2024-03-13 16:09:00 +00:00

(Migrated from gitlab.com)

f0f5d686fa

f0f5d686fa8eec10ea155b0e05d5f87f5ce8fff8

jon_nfc commented

2024-03-13 16:09:04 +00:00

(Migrated from gitlab.com)

resolved all threads

jon_nfc commented

2024-03-13 16:09:14 +00:00

(Migrated from gitlab.com)