ansible-collections/kubernetes
2
0
Fork 0
Code Issues 8 Pull Requests 1 Actions Projects Releases 28 Wiki Activity

fix: logic #99

Merged
jon_nfc merged 7 commits from 28-29-logic-fixes into development 2024-05-03 18:20:29 +00:00
Conversation 24 Commits 7 Files Changed 5 +54 -22
jon_nfc commented 2024-05-03 15:51:20 +00:00 (Migrated from gitlab.com)
Copy Link

📚 Summary

fixes for #28 and #29

🔗 Links / References

👷 Tasks

  • Add your tasks here if required (delete)
### :books: Summary <!-- your summary here emojis ref: https://github.com/yodamad/gitlab-emoji --> fixes for #28 and #29 ### :link: Links / References <!-- using a list as any links to other references or links as required. if relevent, describe the link/reference --> ### :construction_worker: Tasks - [ ] Add your tasks here if required (delete) <!-- dont remove tasks below strike through including the checkbox by enclosing in double tidle '~~' --> - [x] Playbook Update This collection has a [corresponding playbook](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/role.yaml) that may need to be updated (Ansible Role), specifically [Role Validation](https://gitlab.com/nofusscomputing/projects/ansible/ansible_playbooks/-/blob/development/tasks/role/validation/nfc_kubernetes.yaml). - [x] NetBox Rendered Config Update This Collection has a [NetBox Rendered Config template](https://gitlab.com/nofusscomputing/infrastructure/configuration-management/netbox/-/blob/development/templates/cluster.json.j2) that may need to be updated. Specifically Section `cluster.type == 'kubernetes'`
jon_nfc commented 2024-05-03 15:51:35 +00:00 (Migrated from gitlab.com)
Copy Link

added 10m of time spent

added 10m of time spent
jon_nfc commented 2024-05-03 15:51:36 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jon_nfc

assigned to @jon_nfc
jon_nfc commented 2024-05-03 16:18:08 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 310d7a1c48

mentioned in commit 310d7a1c4838873f8083a1662352ead3e3e8dcc9
jon_nfc commented 2024-05-03 16:18:08 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 2ebeb805e8

mentioned in commit 2ebeb805e81b676e097e5f23fcd186520eeeafb9
jon_nfc commented 2024-05-03 16:18:08 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit ece10c7ee0

mentioned in commit ece10c7ee03209f2c0f0efe8c39d3d5524584229
jon_nfc commented 2024-05-03 16:18:08 +00:00 (Migrated from gitlab.com)
Copy Link

added 5 commits

  • 2ebeb805 - fix(nfc_kubernetes): ensure correct node type selection for installation
  • 310d7a1c - fix(nfc_kubernetes): only run tasks on prime node
  • 43ddb13b - fix(nfc_kubernetes): only run tasks on master nodes
  • cbd2ec7e - refactor(nfc_kubernetes): remove usage of prime node name over is_prime var
  • ece10c7e - feat(nfc_kubernetes): new variable 'nfc_role_kubernetes_node_prime' to denote...

Compare with previous version

added 5 commits <ul><li>2ebeb805 - fix(nfc_kubernetes): ensure correct node type selection for installation</li><li>310d7a1c - fix(nfc_kubernetes): only run tasks on prime node</li><li>43ddb13b - fix(nfc_kubernetes): only run tasks on master nodes</li><li>cbd2ec7e - refactor(nfc_kubernetes): remove usage of prime node name over is_prime var</li><li>ece10c7e - feat(nfc_kubernetes): new variable &#39;nfc_role_kubernetes_node_prime&#39; to denote...</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/65/diffs?diff_id=999566972&start_sha=0d0d1862cc62e3eee1500452a23e034aac7dfad4)
jon_nfc commented 2024-05-03 16:18:09 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit cbd2ec7ef8

mentioned in commit cbd2ec7ef832a22537b0b857ee7d72e061a0ab50
jon_nfc commented 2024-05-03 16:18:09 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 43ddb13bdd

mentioned in commit 43ddb13bddecbefd0835abf04050193549fba52b
jon_nfc commented 2024-05-03 16:28:41 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request nofusscomputing/infrastructure/configuration-management/netbox!3

mentioned in merge request nofusscomputing/infrastructure/configuration-management/netbox!3
jon_nfc commented 2024-05-03 16:28:50 +00:00 (Migrated from gitlab.com)
Copy Link

added 36m of time spent

added 36m of time spent
jon_nfc commented 2024-05-03 17:53:34 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit e002ff3749

mentioned in commit e002ff37496014c9a08b6962d7ada20451e9ec09
jon_nfc commented 2024-05-03 17:53:35 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • e002ff37 - fix(nfc_kubernetes): correct 'Create Required directories' when logic

Compare with previous version

added 1 commit <ul><li>e002ff37 - fix(nfc_kubernetes): correct &#39;Create Required directories&#39; when logic</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/65/diffs?diff_id=999635594&start_sha=ece10c7ee03209f2c0f0efe8c39d3d5524584229)
jon_nfc commented 2024-05-03 17:54:16 +00:00 (Migrated from gitlab.com)
Copy Link

marked the checklist item NetBox Rendered Config Update as completed

marked the checklist item **NetBox Rendered Config Update** as completed
jon_nfc commented 2024-05-03 18:06:08 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a01af004a7

mentioned in commit a01af004a72a4bae0d6e36ca4cd379df2a7f61fe
jon_nfc commented 2024-05-03 18:06:10 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • a01af004 - ci(test): add two apt updates in an attempt to correct apt-key random errors

Compare with previous version

added 1 commit <ul><li>a01af004 - ci(test): add two apt updates in an attempt to correct apt-key random errors</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/kubernetes/-/merge_requests/65/diffs?diff_id=999644291&start_sha=e002ff37496014c9a08b6962d7ada20451e9ec09)
jon_nfc commented 2024-05-03 18:06:22 +00:00 (Migrated from gitlab.com)
Copy Link

added 20m of time spent

added 20m of time spent
jon_nfc commented 2024-05-03 18:17:21 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit nofusscomputing/projects/ansible/ansible_playbooks@f98805e4293ed1ff6431e100acd77d40cb5164f7

mentioned in commit nofusscomputing/projects/ansible/ansible_playbooks@f98805e4293ed1ff6431e100acd77d40cb5164f7
jon_nfc commented 2024-05-03 18:17:25 +00:00 (Migrated from gitlab.com)
Copy Link

marked the checklist item Playbook Update as completed

marked the checklist item **Playbook Update** as completed
jon_nfc commented 2024-05-03 18:20:28 +00:00 (Migrated from gitlab.com)
Copy Link

added 14m of time spent

added 14m of time spent
jon_nfc commented 2024-05-03 18:20:29 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 1f90af4eac

mentioned in commit 1f90af4eac349599991656a989a50f39584d57cc
jon_nfc (Migrated from gitlab.com) merged commit 1f90af4eac into development 2024-05-03 18:20:29 +00:00
jon_nfc commented 2024-05-03 18:21:54 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request nofusscomputing/projects/ansible/execution_environment!256

mentioned in merge request nofusscomputing/projects/ansible/execution_environment!256
jon_nfc commented 2024-05-03 18:23:11 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request !66

mentioned in merge request !66
nfc_bot commented 2024-05-03 18:33:43 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit c2c0a9fe7d

mentioned in commit c2c0a9fe7de948b08fc77fbcf9447ec54ddf291d
jon_nfc commented 2024-05-03 18:39:36 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit nofusscomputing/projects/ansible/execution_environment@7be77a2a9b29abf62565e6819ea5cf6f8b567c0f

mentioned in commit nofusscomputing/projects/ansible/execution_environment@7be77a2a9b29abf62565e6819ea5cf6f8b567c0f
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
v1.0.0
Version that is affected
v1.0.1
Version that is affected
v1.1.0
Version that is affected
v1.1.1
Version that is affected
v1.1.2
Version that is affected
v1.10.0
Version that is affected
v1.10.1
Version that is affected
v1.10.2
Version that is affected
v1.10.3
Version that is affected
v1.11.0
Version that is affected
v1.12.0
Version that is affected
v1.13.0
Version that is affected
v1.13.1
Version that is affected
v1.13.2
Version that is affected
v1.2.0
Version that is affected
v1.3.0
Version that is affected
v1.4.0
Version that is affected
v1.5.0
Version that is affected
v1.6.0
Version that is affected
v1.7.0
Version that is affected
v1.7.1
Version that is affected
v1.7.2
Version that is affected
v1.8.0
Version that is affected
v1.8.1-a1
Version that is affected
v1.8.1-a2
Version that is affected
v1.9.0
Version that is affected
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
difficulty::Good First Issue
impact::0
priority::5
type::feature
v1.9.0
Milestone
No items
No Milestone nfc_kubernetes Production Ready
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ansible-collections/kubernetes#99
No description provided.
Delete Branch "28-29-logic-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?