ansible-collections/phpipam_scan_agent
2
0
Fork 0
Code Issues 10 Pull Requests Actions Projects Releases 7 Wiki Activity

fix: Initial bug fixes #28

Merged
jon_nfc merged 12 commits from initial-bug-fixes into development 2024-02-22 12:06:30 +00:00
Conversation 40 Commits 12 Files Changed 8 +77 -35
jon_nfc commented 2024-02-22 05:07:38 +00:00 (Migrated from gitlab.com)
Copy Link

Tasks

## Tasks - #9
jon_nfc commented 2024-02-22 05:11:04 +00:00 (Migrated from gitlab.com)
Copy Link

Log 0.1.2-a1

ansible-galaxy collection install --force-with-deps --pre     /tmp/collection/.;     rm -Rf /tmp/collection;   fi;   chmod +x /etc/cron.d/*;
#36 0.105 specified
#36 4.600 ERROR! You must specify a collection name or a requirements file.
# Log 0.1.2-a1 ``` log ansible-galaxy collection install --force-with-deps --pre /tmp/collection/.; rm -Rf /tmp/collection; fi; chmod +x /etc/cron.d/*; #36 0.105 specified #36 4.600 ERROR! You must specify a collection name or a requirements file. ```
jon_nfc commented 2024-02-22 05:16:58 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 634eff3b3a

mentioned in commit 634eff3b3aa6a5762b9620fa779042bc7a6e1f56
jon_nfc commented 2024-02-22 05:17:00 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 634eff3b - fix(docker): ensure correct variable used to install package

Compare with previous version

added 1 commit <ul><li>634eff3b - fix(docker): ensure correct variable used to install package</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932429121&start_sha=d0ef68c54dd66629b0864e3aba745a2ec5b8baf7)
jon_nfc commented 2024-02-22 05:57:55 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit a2444087a8

mentioned in commit a2444087a8c2426d8090a03ee8fe2ca9aecd5625
jon_nfc commented 2024-02-22 05:57:55 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 661c7bcc89bd4716fab9540f9e94e823dfeda5ff

mentioned in commit 661c7bcc89bd4716fab9540f9e94e823dfeda5ff
jon_nfc commented 2024-02-22 05:57:55 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 9920fdb0b4

mentioned in commit 9920fdb0b4c7a696202659191fb9e61578846bb4
jon_nfc commented 2024-02-22 05:57:55 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 785ae77510

mentioned in commit 785ae77510c8c82134f92171ae221a4f045c9cd6
jon_nfc commented 2024-02-22 05:57:55 +00:00 (Migrated from gitlab.com)
Copy Link

added 4 commits

  • 9920fdb0 - fix(agent): cater for api call that returns nothing
  • a2444087 - refactor(api_call): use var name that makes more sense
  • 785ae775 - feat(api_call): before returning check if cached file exists
  • 661c7bcc - fix(agent): only attempt to scan subnet if subnetes were returned

Compare with previous version

added 4 commits <ul><li>9920fdb0 - fix(agent): cater for api call that returns nothing</li><li>a2444087 - refactor(api_call): use var name that makes more sense</li><li>785ae775 - feat(api_call): before returning check if cached file exists</li><li>661c7bcc - fix(agent): only attempt to scan subnet if subnetes were returned</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932447291&start_sha=634eff3b3aa6a5762b9620fa779042bc7a6e1f56)
jon_nfc commented 2024-02-22 06:08:57 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in merge request nofusscomputing/projects/gitlab-ci!77

mentioned in merge request nofusscomputing/projects/gitlab-ci!77
jon_nfc commented 2024-02-22 07:41:10 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 2186a85abf

mentioned in commit 2186a85abfec49e3d2202b370d86586cb134e2c4
jon_nfc commented 2024-02-22 07:41:13 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 2186a85a - fix(agent): only attempt to scan subnet if subnets were returned

Compare with previous version

added 1 commit <ul><li>2186a85a - fix(agent): only attempt to scan subnet if subnets were returned</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932522319&start_sha=661c7bcc89bd4716fab9540f9e94e823dfeda5ff)
jon_nfc commented 2024-02-22 08:56:41 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit b3e911efcd

mentioned in commit b3e911efcdbe4d1f6cf6c2665206a3ead3e8a4a7
jon_nfc commented 2024-02-22 08:56:42 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 058781709c

mentioned in commit 058781709ca51fcc1315a9c7b02a00a37c70c232
jon_nfc commented 2024-02-22 08:56:42 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 05878170 - feat(server): show ip address in logs when updating an ip address
  • b3e911ef - ci: add submodule update job

Compare with previous version

added 2 commits <ul><li>05878170 - feat(server): show ip address in logs when updating an ip address</li><li>b3e911ef - ci: add submodule update job</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932611935&start_sha=2186a85abfec49e3d2202b370d86586cb134e2c4)
jon_nfc commented 2024-02-22 09:08:30 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit f8bdccd122

mentioned in commit f8bdccd122580987bf10d0864d48205d4ff2b1b2
jon_nfc commented 2024-02-22 09:08:32 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • f8bdccd1 - feat(agent): showsubnet address in logs when conducting subnet actions

Compare with previous version

added 1 commit <ul><li>f8bdccd1 - feat(agent): showsubnet address in logs when conducting subnet actions</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932629311&start_sha=b3e911efcdbe4d1f6cf6c2665206a3ead3e8a4a7)
jon_nfc commented 2024-02-22 10:50:27 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit eacec03cf3c65d3436176946ee9c85b0ed5e8765

mentioned in commit eacec03cf3c65d3436176946ee9c85b0ed5e8765
jon_nfc commented 2024-02-22 10:50:27 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit eb03028239815b61600971803c20df968ce23ab2

mentioned in commit eb03028239815b61600971803c20df968ce23ab2
jon_nfc commented 2024-02-22 10:50:29 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • eb030282 - feat(agent): if hostname present in nmap scan report, add to report for server
  • eacec03c - feat(server): if hostname in scan report, update the database

Compare with previous version

added 2 commits <ul><li>eb030282 - feat(agent): if hostname present in nmap scan report, add to report for server</li><li>eacec03c - feat(server): if hostname in scan report, update the database</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932788392&start_sha=f8bdccd122580987bf10d0864d48205d4ff2b1b2)
jon_nfc commented 2024-02-22 10:53:28 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7d7a77b3fb

mentioned in commit 7d7a77b3fbdb6997a9dd98fdf720932e28e173b0
jon_nfc commented 2024-02-22 10:53:28 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 4c631c67f9

mentioned in commit 4c631c67f94a208ff60641df4fe1f8912cb3512b
jon_nfc commented 2024-02-22 10:53:29 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 4c631c67 - feat(agent): if hostname present in nmap scan report, add to report for server
  • 7d7a77b3 - feat(server): if hostname in scan report, update the database

Compare with previous version

added 2 commits <ul><li>4c631c67 - feat(agent): if hostname present in nmap scan report, add to report for server</li><li>7d7a77b3 - feat(server): if hostname in scan report, update the database</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932793014&start_sha=eacec03cf3c65d3436176946ee9c85b0ed5e8765)
jon_nfc commented 2024-02-22 10:55:28 +00:00 (Migrated from gitlab.com)
Copy Link

some work from #4 done as part of this mr

some work from #4 done as part of this mr
jon_nfc commented 2024-02-22 11:34:40 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 3ab1936a0a

mentioned in commit 3ab1936a0a4818bebb182521cc7b3a12924ddf2a
jon_nfc commented 2024-02-22 11:34:41 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 3ab1936a - chore(ci): update ci template repo to current head

Compare with previous version

added 1 commit <ul><li>3ab1936a - chore(ci): update ci template repo to current head</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932853064&start_sha=7d7a77b3fbdb6997a9dd98fdf720932e28e173b0)
jon_nfc commented 2024-02-22 11:35:05 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jon_nfc

assigned to @jon_nfc
jon_nfc commented 2024-02-22 11:35:39 +00:00 (Migrated from gitlab.com)
Copy Link

added 6h 28m of time spent

added 6h 28m of time spent
jon_nfc commented 2024-02-22 11:35:54 +00:00 (Migrated from gitlab.com)
Copy Link

resolved all threads

resolved all threads
jon_nfc (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2024-02-22 11:36:01 +00:00
jon_nfc (Migrated from gitlab.com) canceled auto merging this pull request when all checks succeed 2024-02-22 11:38:45 +00:00
jon_nfc commented 2024-02-22 11:46:18 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 98317f48 - fix(server): use correct sql syntax to insert ipaddress

Compare with previous version

added 1 commit <ul><li>98317f48 - fix(server): use correct sql syntax to insert ipaddress</li></ul> [Compare with previous version](/nofusscomputing/projects/ansible/collections/phpipam_scan_agent/-/merge_requests/8/diffs?diff_id=932867852&start_sha=3ab1936a0a4818bebb182521cc7b3a12924ddf2a)
jon_nfc commented 2024-02-22 11:46:18 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 98317f4831

mentioned in commit 98317f4831c4c1b5d86f348106d90ae99b58c379
jon_nfc (Migrated from gitlab.com) scheduled this pull request to auto merge when all checks succeed 2024-02-22 11:51:01 +00:00
jon_nfc commented 2024-02-22 11:51:19 +00:00 (Migrated from gitlab.com)
Copy Link

added 16m of time spent

added 16m of time spent
jon_nfc commented 2024-02-22 12:06:30 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 999d3fbc6a

mentioned in commit 999d3fbc6a54572c9b49bfa322c8a359e1ef84fa
jon_nfc (Migrated from gitlab.com) merged commit 999d3fbc6a into development 2024-02-22 12:06:30 +00:00
nfc_bot commented 2024-02-22 12:08:54 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 99513f6d65

mentioned in commit 99513f6d656419b18f916712b3b8f35cfc9396b8
jon_nfc commented 2024-02-23 03:54:41 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 8b723487a3

mentioned in commit 8b723487a3ed0e57a5206aeb180ae62b33a28818
jon_nfc commented 2024-02-23 04:16:53 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit df464acaef

mentioned in commit df464acaef0e764702f31236cbfbb72fd42ac22c
jon_nfc commented 2024-02-23 04:31:30 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 859d8047aced63bc3226b75da5453bd85009666e

mentioned in commit 859d8047aced63bc3226b75da5453bd85009666e
jon_nfc commented 2024-02-23 04:52:19 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 83bfe939a110204db1d029387220bb4aa0873eb7

mentioned in commit 83bfe939a110204db1d029387220bb4aa0873eb7
jon_nfc commented 2024-02-23 05:45:47 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit de7752cfcf

mentioned in commit de7752cfcfad58c234e3897f2654faa4451b85f3
jon_nfc commented 2024-02-23 05:45:47 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7df863416e

mentioned in commit 7df863416e30e4de661998847779f87891977502
jon_nfc commented 2024-02-23 06:36:06 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 87b90bffa0

mentioned in commit 87b90bffa020dd3690b95987e559062ffa3c8fbc
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
v0.1.0
phpIPAM Version that is affected
v0.1.1
phpIPAM Version that is affected
v0.1.2-a1
phpIPAM Version that is affected
v0.2.0
Version that is affected
v0.2.0-a1
Version that is affected
v0.2.0-a2
Version that is affected
v0.2.0-a3
Version that is affected
v0.3.0
Version that is affected
v0.4.0
Version that is affected
vALL
The version affected
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
impact::5
priority::5
type::bug
v0.1.0
v0.1.1
v0.1.2-a1
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ansible-collections/phpipam_scan_agent#28
No description provided.
Delete Branch "initial-bug-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?