infrastructure/gitlab-ci
2
0
Fork 0
Code Issues 17 Pull Requests 1 Actions Projects Releases 21 Wiki Activity

feat: Markdown linting and mkdocs build #65

Merged
jon_nfc merged 36 commits from 12-15-mkdocs-build-markdown-linting into development 2022-01-24 05:45:46 +00:00
Conversation 134 Commits 36 Files Changed 10 +277
jon_nfc commented 2022-01-22 08:31:57 +00:00 (Migrated from gitlab.com)
Copy Link

🔗 References

✅ Tasks

  • #12 closed in commit message

  • #15 closed in commit message

### :link: References - closes #12 - closes #15 - required for nofusscomputing/ops#41 ### :white_check_mark: Tasks - [x] #12 closed in commit message - [x] #15 closed in commit message
jon_nfc commented 2022-01-22 08:31:57 +00:00 (Migrated from gitlab.com)
Copy Link

requested review from @jon_nfc

requested review from @jon_nfc
jon_nfc (Migrated from gitlab.com) changed target branch from master to development 2022-01-22 08:32:22 +00:00
jon_nfc commented 2022-01-22 08:35:38 +00:00 (Migrated from gitlab.com)
Copy Link

assigned to @jon_nfc

assigned to @jon_nfc
jon_nfc commented 2022-01-23 00:16:10 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 06fdfa72 - chore: initial add of build and validation jobs for mkdocs and markdown linting

Compare with previous version

added 1 commit <ul><li>06fdfa72 - chore: initial add of build and validation jobs for mkdocs and markdown linting</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316608164&start_sha=1ef6c41818c40183f8019ea5cde48b4278e4d694)
jon_nfc commented 2022-01-23 00:24:18 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • bc67e939 - chore: initial add of build and validation jobs for mkdocs and markdown linting

Compare with previous version

added 1 commit <ul><li>bc67e939 - chore: initial add of build and validation jobs for mkdocs and markdown linting</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316609462&start_sha=06fdfa72ec335e599b09a34acf4ffd655ff1f309)
jon_nfc commented 2022-01-23 01:04:12 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 954aa28d - feat(validation): Added a Markdown linting validation job.
  • 50b5e854 - feat(build): initial add of mkdocs build job

Compare with previous version

added 2 commits <ul><li>954aa28d - feat(validation): Added a Markdown linting validation job.</li><li>50b5e854 - feat(build): initial add of mkdocs build job</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316612682&start_sha=bc67e939faf0b3d2eac05eae7edf297c81e55739)
jon_nfc commented 2022-01-23 01:27:50 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 6383cde3 - docs(markdown_lint): initial adding of the docs
  • 5c05ed76 - docs(mkdocs): initial adding of mkdocs build readme.

Compare with previous version

added 2 commits <ul><li>6383cde3 - docs(markdown_lint): initial adding of the docs</li><li>5c05ed76 - docs(mkdocs): initial adding of mkdocs build readme.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316614572&start_sha=50b5e8542b827e6b6cf70f3f4c26b4c1737fe0c1)
jon_nfc commented 2022-01-23 01:40:45 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 6363ea37 - docs(markdown_lint): completed the job docs.
  • 1ef0e224 - docs(mkdocs): Completed the mkdocs build readme

Compare with previous version

added 2 commits <ul><li>6363ea37 - docs(markdown_lint): completed the job docs.</li><li>1ef0e224 - docs(mkdocs): Completed the mkdocs build readme</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316615198&start_sha=5c05ed7605ddbecb1a3c7046716afa07829c264f)
jon_nfc commented 2022-01-23 01:42:18 +00:00 (Migrated from gitlab.com)
Copy Link

marked the checklist item #12 closed in commit message as completed

marked the checklist item **#12 closed in commit message** as completed
jon_nfc commented 2022-01-23 01:42:20 +00:00 (Migrated from gitlab.com)
Copy Link

marked the checklist item #15 closed in commit message as completed

marked the checklist item **#15 closed in commit message** as completed
jon_nfc commented 2022-01-23 01:43:51 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue #15

mentioned in issue #15
jon_nfc commented 2022-01-23 01:44:29 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue #12

mentioned in issue #12
jon_nfc commented 2022-01-23 01:46:43 +00:00 (Migrated from gitlab.com)
Copy Link

issues #12 and #15 marked as ~"workflow::complete"

issues #12 and #15 marked as ~"workflow::complete"
jon_nfc commented 2022-01-23 01:46:43 +00:00 (Migrated from gitlab.com)
Copy Link

added 2h 46m of time spent

added 2h 46m of time spent
jon_nfc commented 2022-01-23 01:51:12 +00:00 (Migrated from gitlab.com)
Copy Link

set build artifacts to expire after 24 hours

set build artifacts to expire after 24 hours
jon_nfc commented 2022-01-23 01:52:56 +00:00 (Migrated from gitlab.com)
Copy Link

figure out how to use package json so that versions can be checked by ci

figure out how to use package json so that versions can be checked by ci
jon_nfc commented 2022-01-23 03:16:42 +00:00 (Migrated from gitlab.com)
Copy Link
    expire_in: 24 hrs
    paths:
```suggestion:-0+0 expire_in: 24 hrs paths: ```
jon_nfc commented 2022-01-23 03:16:42 +00:00 (Migrated from gitlab.com)
Copy Link
    expire_in: 24 hrs
```suggestion:-0+0 expire_in: 24 hrs ```
jon_nfc commented 2022-01-23 03:16:42 +00:00 (Migrated from gitlab.com)
Copy Link

Consider adding mkdocs to a requirements file for version checking ci job

Consider adding mkdocs to a requirements file for version checking ci job
jon_nfc commented 2022-01-23 03:16:43 +00:00 (Migrated from gitlab.com)
Copy Link
stages:

Cleanup, not required

```suggestion:-3+0 stages: ``` Cleanup, not required
jon_nfc commented 2022-01-23 03:16:43 +00:00 (Migrated from gitlab.com)
Copy Link

Check this post https://stackoverflow.com/a/38902183 as it provides an example.

and

How to specify path npm --prefix /path/to/project. Idea is that it will have the deps for the job for a version check to be included

Check this post https://stackoverflow.com/a/38902183 as it provides an example. and How to specify path npm --prefix /path/to/project. Idea is that it will have the deps for the job for a version check to be included
jon_nfc commented 2022-01-23 03:16:43 +00:00 (Migrated from gitlab.com)
Copy Link
Markdown Linting:
```suggestion:-0+0 Markdown Linting: ```
jon_nfc commented 2022-01-23 03:16:43 +00:00 (Migrated from gitlab.com)
Copy Link
  variables:
    MKDOCS_BUILD_PATH: "build"
  extends:
```suggestion:-0+0 variables: MKDOCS_BUILD_PATH: "build" extends: ```
jon_nfc commented 2022-01-23 03:17:29 +00:00 (Migrated from gitlab.com)
Copy Link

added 30m of time spent

added 30m of time spent
jon_nfc commented 2022-01-23 03:18:36 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 347597e3 - docs(mkdocs_build): include mandatory vars in template ci file.

Compare with previous version

added 1 commit <ul><li>347597e3 - docs(mkdocs_build): include mandatory vars in template ci file.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316621590&start_sha=1ef0e2245facffb760ba2ad9a57af1d6178a2d1a)
jon_nfc commented 2022-01-23 03:20:00 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 7 of the diff

changed this line in [version 7 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316621635&start_sha=347597e3c1cb20eaa32d1e1cbb2d9d13661a663a#a53bd1da98392c7f0a1ad7bc405f4c6eac785002_17_17)
jon_nfc commented 2022-01-23 03:20:01 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • e0d8885d - ci(artifacts): markdown lint and mkdocs build artifacts to expire after 24 hours

Compare with previous version

added 1 commit <ul><li>e0d8885d - ci(artifacts): markdown lint and mkdocs build artifacts to expire after 24 hours</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316621635&start_sha=347597e3c1cb20eaa32d1e1cbb2d9d13661a663a)
jon_nfc commented 2022-01-23 03:21:44 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 8 of the diff

changed this line in [version 8 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316621694&start_sha=e0d8885d52319a6188c779e80c2064b773721184#3da1405315555c98432363c34b0c6b79f05a9a86_25_25)
jon_nfc commented 2022-01-23 03:21:45 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>21159643 - chore: review fixes. </li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316621694&start_sha=e0d8885d52319a6188c779e80c2064b773721184)
jon_nfc commented 2022-01-23 03:42:34 +00:00 (Migrated from gitlab.com)
Copy Link

dependency scanning

Add to .gitlab-ci.yml

include:
  - template: Security/Dependency-Scanning.gitlab-ci.yml
# dependency scanning Add to .gitlab-ci.yml ``` yaml include: - template: Security/Dependency-Scanning.gitlab-ci.yml ```
jon_nfc commented 2022-01-23 03:43:05 +00:00 (Migrated from gitlab.com)
Copy Link

added 25m of time spent

added 25m of time spent
jon_nfc commented 2022-01-23 03:59:38 +00:00 (Migrated from gitlab.com)
Copy Link

licence scanning

include:
  - template: Security/License-Scanning.gitlab-ci.yml
# licence scanning ```yaml include: - template: Security/License-Scanning.gitlab-ci.yml ```
jon_nfc commented 2022-01-23 04:01:04 +00:00 (Migrated from gitlab.com)
Copy Link

Needs a test stage

Needs a test stage
jon_nfc commented 2022-01-23 04:01:18 +00:00 (Migrated from gitlab.com)
Copy Link

needs a test stage

needs a test stage
jon_nfc commented 2022-01-23 04:02:10 +00:00 (Migrated from gitlab.com)
Copy Link

added 15m of time spent

added 15m of time spent
jon_nfc commented 2022-01-23 04:10:05 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 5c872f16 - ci: Added a test stage for gitlab specific tests.

Compare with previous version

added 1 commit <ul><li>5c872f16 - ci: Added a test stage for gitlab specific tests.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316624925&start_sha=21159643176249cbc33df3a655df90267d64bc3b)
jon_nfc commented 2022-01-23 04:14:15 +00:00 (Migrated from gitlab.com)
Copy Link

Add new jobs here

include:
  - local: $JOB_ROOT_DIR/yaml_lint/.gitlab-ci.yml
  - local: $JOB_ROOT_DIR/conventional_commits/.gitlab-ci.yml
  - local: $JOB_ROOT_DIR/git_push_mirror/.gitlab-ci.yml
  - local: $JOB_ROOT_DIR/gitlab_release/.gitlab-ci.yml
  - local: $JOB_ROOT_DIR/python/.gitlab-ci.yml
  - template: Security/Dependency-Scanning.gitlab-ci.yml
  - template: Security/License-Scanning.gitlab-ci.yml
Add new jobs here ```suggestion:-5+0 include: - local: $JOB_ROOT_DIR/yaml_lint/.gitlab-ci.yml - local: $JOB_ROOT_DIR/conventional_commits/.gitlab-ci.yml - local: $JOB_ROOT_DIR/git_push_mirror/.gitlab-ci.yml - local: $JOB_ROOT_DIR/gitlab_release/.gitlab-ci.yml - local: $JOB_ROOT_DIR/python/.gitlab-ci.yml - template: Security/Dependency-Scanning.gitlab-ci.yml - template: Security/License-Scanning.gitlab-ci.yml ```
jon_nfc commented 2022-01-23 04:16:36 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • fc816192 - ci(scanners): Added dependency and licence scanners

Compare with previous version

added 1 commit <ul><li>fc816192 - ci(scanners): Added dependency and licence scanners</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316625343&start_sha=5c872f163e4de5834efd74a78e3e948d242916ec)
jon_nfc commented 2022-01-23 04:16:47 +00:00 (Migrated from gitlab.com)
Copy Link

Added

Added
jon_nfc commented 2022-01-23 04:17:15 +00:00 (Migrated from gitlab.com)
Copy Link

Added

Added
jon_nfc commented 2022-01-23 04:22:40 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 7665e512 - chore: add mkdocs dir for pip file.

Compare with previous version

added 1 commit <ul><li>7665e512 - chore: add mkdocs dir for pip file.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316625642&start_sha=fc816192be680f64ee1b4b96cccd0d605c529b86)
jon_nfc commented 2022-01-23 04:25:37 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 5a41962a - feat(mkdocs_build): move ci job dependencies to a pip file so that the ci...

Compare with previous version

added 1 commit <ul><li>5a41962a - feat(mkdocs_build): move ci job dependencies to a pip file so that the ci...</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316625757&start_sha=7665e512a5d6e5aab3f8c0a8241d4182f3362442)
jon_nfc commented 2022-01-23 05:01:17 +00:00 (Migrated from gitlab.com)
Copy Link
    MY_PROJECT_ID: "28543717"
    LICENSE_FINDER_CLI_OPTS: '--recursive'
```suggestion:-0+0 MY_PROJECT_ID: "28543717" LICENSE_FINDER_CLI_OPTS: '--recursive' ```
jon_nfc commented 2022-01-23 05:02:55 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 83cce72a - ci(licence_finder): set to recursive scan so all licence's can be detected.

Compare with previous version

added 1 commit <ul><li>83cce72a - ci(licence_finder): set to recursive scan so all licence&#39;s can be detected.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316627320&start_sha=5a41962a994a54d99a3e7ab1bc0d7379ea14c1c2)
jon_nfc commented 2022-01-23 05:18:28 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628073&start_sha=83cce72af22b09bd8a245af99e9134d3be129eac#9ed4cdc47669d7cb8bf4042272bf1dbae7674098_20_0)
jon_nfc commented 2022-01-23 05:18:29 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628073&start_sha=83cce72af22b09bd8a245af99e9134d3be129eac#9ed4cdc47669d7cb8bf4042272bf1dbae7674098_12_0)
jon_nfc commented 2022-01-23 05:18:29 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628073&start_sha=83cce72af22b09bd8a245af99e9134d3be129eac#6839fd14d0ecb1b557dcea668f86bfb6c063fb4d_16_0)
jon_nfc commented 2022-01-23 05:18:29 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 14 of the diff

changed this line in [version 14 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628073&start_sha=83cce72af22b09bd8a245af99e9134d3be129eac#6839fd14d0ecb1b557dcea668f86bfb6c063fb4d_25_0)
jon_nfc commented 2022-01-23 05:18:29 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 18c2e231 - chore(mkdocs): move mkdocs jobs to its own directory.

Compare with previous version

added 1 commit <ul><li>18c2e231 - chore(mkdocs): move mkdocs jobs to its own directory.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628073&start_sha=83cce72af22b09bd8a245af99e9134d3be129eac)
jon_nfc commented 2022-01-23 05:28:57 +00:00 (Migrated from gitlab.com)
Copy Link
    MKDOCS_SOURCE_PATH: pages
    DEFAULT_ROOT_DIR: './gitlab-ci'
```suggestion:-0+0 MKDOCS_SOURCE_PATH: pages DEFAULT_ROOT_DIR: './gitlab-ci' ```
jon_nfc commented 2022-01-23 05:28:58 +00:00 (Migrated from gitlab.com)
Copy Link
    - if [ "0$JOB_ROOT_DIR" == "0" ]; then ROOT_DIR=$DEFAULT_ROOT_DIR; else ROOT_DIR=$JOB_ROOT_DIR ; fi
    - echo "[DEBUG] ROOT_DIR[$ROOT_DIR]"
    - if [ ! -f "requirements.txt" ]; then pip install --upgrade pip -r $ROOT_DIR/mkdocs/requirements.txt; fi
    - if [ -f "requirements.txt" ]; then pip install --upgrade pip -r $ROOT_DIR/mkdocs/requirements.txt; pip install -r requirements.txt; fi
```suggestion:-1+0 - if [ "0$JOB_ROOT_DIR" == "0" ]; then ROOT_DIR=$DEFAULT_ROOT_DIR; else ROOT_DIR=$JOB_ROOT_DIR ; fi - echo "[DEBUG] ROOT_DIR[$ROOT_DIR]" - if [ ! -f "requirements.txt" ]; then pip install --upgrade pip -r $ROOT_DIR/mkdocs/requirements.txt; fi - if [ -f "requirements.txt" ]; then pip install --upgrade pip -r $ROOT_DIR/mkdocs/requirements.txt; pip install -r requirements.txt; fi ```
jon_nfc commented 2022-01-23 05:28:58 +00:00 (Migrated from gitlab.com)
Copy Link
```suggestion:-0+0 ```
jon_nfc commented 2022-01-23 05:28:58 +00:00 (Migrated from gitlab.com)
Copy Link
```suggestion:-0+0 ```
jon_nfc commented 2022-01-23 05:29:21 +00:00 (Migrated from gitlab.com)
Copy Link

Done

Done
jon_nfc commented 2022-01-23 05:31:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628596&start_sha=18c2e2312896aa0ba07050d28155c7aaca2aee5c#a522c80ee36c344f16981e0e19c3ac5e592b1b6e_12_11)
jon_nfc commented 2022-01-23 05:31:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628596&start_sha=18c2e2312896aa0ba07050d28155c7aaca2aee5c#a522c80ee36c344f16981e0e19c3ac5e592b1b6e_6_6)
jon_nfc commented 2022-01-23 05:31:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 15 of the diff

changed this line in [version 15 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628596&start_sha=18c2e2312896aa0ba07050d28155c7aaca2aee5c#ae7acce86f25438f3649e7bef72180414fc1993f_34_34)
jon_nfc commented 2022-01-23 05:31:09 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 906f09e2 - feat(mkdocs_build): use a pip file for job so that licence scanning can function.

Compare with previous version

added 1 commit <ul><li>906f09e2 - feat(mkdocs_build): use a pip file for job so that licence scanning can function.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316628596&start_sha=18c2e2312896aa0ba07050d28155c7aaca2aee5c)
jon_nfc commented 2022-01-23 05:36:52 +00:00 (Migrated from gitlab.com)
Copy Link

added 1h 5m of time spent

added 1h 5m of time spent
jon_nfc commented 2022-01-23 05:46:34 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • e1894ec0 - fix(dependency_scanning): upgraded versions from vulnerability scan.

Compare with previous version

added 1 commit <ul><li>e1894ec0 - fix(dependency_scanning): upgraded versions from vulnerability scan.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316629147&start_sha=906f09e2d3285681bd982d65eda3f56cf5a5169e)
jon_nfc commented 2022-01-23 05:49:05 +00:00 (Migrated from gitlab.com)
Copy Link

added 12m of time spent

added 12m of time spent
jon_nfc commented 2022-01-23 05:57:13 +00:00 (Migrated from gitlab.com)
Copy Link

Typo for pillow

Pillow>=9.0.0
numpy>=1.22.0
pipenv>=2022.1.8
Typo for pillow ```suggestion:-0+0 Pillow>=9.0.0 numpy>=1.22.0 pipenv>=2022.1.8 ```
jon_nfc commented 2022-01-23 05:57:45 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 484d9879 - fix(ansible): fix typo in job pip file

Compare with previous version

added 1 commit <ul><li>484d9879 - fix(ansible): fix typo in job pip file</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316629722&start_sha=e1894ec0c4fe7504901682f008c2ff0db7e351fe)
jon_nfc commented 2022-01-23 05:58:16 +00:00 (Migrated from gitlab.com)
Copy Link

added 10m of time spent

added 10m of time spent
jon_nfc commented 2022-01-23 06:11:35 +00:00 (Migrated from gitlab.com)
Copy Link
```suggestion:-1+0 ```
jon_nfc commented 2022-01-23 06:12:37 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 18 of the diff

changed this line in [version 18 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316630436&start_sha=484d98792a27c9d967331e9d3cd1afdca435bdd6#92afd006c2b68435b0063198e35441643b71533f_2_1)
jon_nfc commented 2022-01-23 06:12:37 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 0df60b12 - fix(ansible): remove duplicate lines that last code review didn't remove.

Compare with previous version

added 1 commit <ul><li>0df60b12 - fix(ansible): remove duplicate lines that last code review didn&#39;t remove.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316630436&start_sha=484d98792a27c9d967331e9d3cd1afdca435bdd6)
jon_nfc commented 2022-01-23 06:19:48 +00:00 (Migrated from gitlab.com)
Copy Link

Figure out why lines 1-3 make the check job fail

Figure out why lines 1-3 make the check job fail
jon_nfc commented 2022-01-23 06:21:06 +00:00 (Migrated from gitlab.com)
Copy Link

added 10m of time spent

added 10m of time spent
jon_nfc commented 2022-01-23 06:39:25 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • e46dc57b - chore(markdown_lint): add empty junit test file.

Compare with previous version

added 1 commit <ul><li>e46dc57b - chore(markdown_lint): add empty junit test file.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316631696&start_sha=0df60b12dbfff983ca3a671b90ab1be126597e52)
jon_nfc commented 2022-01-23 06:41:23 +00:00 (Migrated from gitlab.com)
Copy Link
{
  "outputFormatters": [
    [ "markdownlint-cli2-formatter-junit", { "name": "markdown.junit.xml" } ]
  ]
}
```suggestion:-2+0 { "outputFormatters": [ [ "markdownlint-cli2-formatter-junit", { "name": "markdown.junit.xml" } ] ] } ```
jon_nfc commented 2022-01-23 06:46:47 +00:00 (Migrated from gitlab.com)
Copy Link
    MDLINT_EXCLUDE_PATHS: '"!gitlab-ci"'
    DEFAULT_ROOT_DIR: './gitlab-ci'
```suggestion:-0+0 MDLINT_EXCLUDE_PATHS: '"!gitlab-ci"' DEFAULT_ROOT_DIR: './gitlab-ci' ```
jon_nfc commented 2022-01-23 06:46:47 +00:00 (Migrated from gitlab.com)
Copy Link
    - mkdir -p "$CI_PROJECT_DIR/artifacts/$CI_JOB_STAGE/tests"
    - if [ "0$JOB_ROOT_DIR" == "0" ]; then ROOT_DIR=$DEFAULT_ROOT_DIR; else ROOT_DIR=$JOB_ROOT_DIR ; fi
    - echo "[DEBUG] ROOT_DIR[$ROOT_DIR]"
    - cp -f "$CI_PROJECT_DIR/validation/.markdownlint-cli2.jsonc" "$CI_PROJECT_DIR/.markdownlint-cli2.jsonc"
```suggestion:-0+0 - mkdir -p "$CI_PROJECT_DIR/artifacts/$CI_JOB_STAGE/tests" - if [ "0$JOB_ROOT_DIR" == "0" ]; then ROOT_DIR=$DEFAULT_ROOT_DIR; else ROOT_DIR=$JOB_ROOT_DIR ; fi - echo "[DEBUG] ROOT_DIR[$ROOT_DIR]" - cp -f "$CI_PROJECT_DIR/validation/.markdownlint-cli2.jsonc" "$CI_PROJECT_DIR/.markdownlint-cli2.jsonc" ```
jon_nfc commented 2022-01-23 06:46:47 +00:00 (Migrated from gitlab.com)
Copy Link
    - rm "$CI_PROJECT_DIR/.markdownlint-cli2.jsonc"
    - mv *.junit.xml $CI_PROJECT_DIR/artifacts/$CI_JOB_STAGE/tests/markdown.junit.xml
```suggestion:-0+0 - rm "$CI_PROJECT_DIR/.markdownlint-cli2.jsonc" - mv *.junit.xml $CI_PROJECT_DIR/artifacts/$CI_JOB_STAGE/tests/markdown.junit.xml ```
jon_nfc commented 2022-01-23 06:48:46 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 9ab336fb - feat(markdown_lint): include junit configuration file '.markdownlint-cli2.jsonc' in ci job.

Compare with previous version

added 1 commit <ul><li>9ab336fb - feat(markdown_lint): include junit configuration file &#39;.markdownlint-cli2.jsonc&#39; in ci job.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316632124&start_sha=e46dc57b1643d6fd7c393bcf8b7d1d77bd2096c8)
jon_nfc commented 2022-01-23 06:53:13 +00:00 (Migrated from gitlab.com)
Copy Link

You can include your linting rules in `.markdownlint.json` which should be within the root of your repository. for the available rules please see the [docs](https://github.com/DavidAnson/markdownlint/blob/main/README.md#rules--aliases).
```suggestion:-0+0 You can include your linting rules in `.markdownlint.json` which should be within the root of your repository. for the available rules please see the [docs](https://github.com/DavidAnson/markdownlint/blob/main/README.md#rules--aliases). ```
jon_nfc commented 2022-01-23 06:53:59 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • fd48316a - docs(markdown_lint): updated docs on how to use and view rules.

Compare with previous version

added 1 commit <ul><li>fd48316a - docs(markdown_lint): updated docs on how to use and view rules.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316632451&start_sha=9ab336fbddd6cba1d29c5a001ab52772ed4554b6)
jon_nfc commented 2022-01-23 06:54:49 +00:00 (Migrated from gitlab.com)
Copy Link

added 33m of time spent

added 33m of time spent
jon_nfc commented 2022-01-23 07:14:01 +00:00 (Migrated from gitlab.com)
Copy Link
Pillow==9.0.0
numpy==1.22.0
pipenv==2022.1.8
```suggestion:-3+0 Pillow==9.0.0 numpy==1.22.0 pipenv==2022.1.8 ```
jon_nfc commented 2022-01-23 07:14:33 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 22 of the diff

changed this line in [version 22 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316633813&start_sha=fd48316ae763282fc106b7da184c05b35d9ae052#92afd006c2b68435b0063198e35441643b71533f_3_1)
jon_nfc commented 2022-01-23 07:14:34 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 6668c2fb - refactor: test specifying must equal.

Compare with previous version

added 1 commit <ul><li>6668c2fb - refactor: test specifying must equal.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316633813&start_sha=fd48316ae763282fc106b7da184c05b35d9ae052)
jon_nfc commented 2022-01-23 07:35:12 +00:00 (Migrated from gitlab.com)
Copy Link
# Scanner doesn't Pickup multiple pip files. Disable and specify jobs with pip file.
gemnasium-python-dependency_scanning:
  rules:
    - when: never

# source: https://gitlab.com/gitlab-org/gitlab/-/blob/2f33a8cb4dcea7b875e360d4cd9e016e027d2973/lib/gitlab/ci/templates/Security/Dependency-Scanning.gitlab-ci.yml
.gemnasium-python-dependency_scanning:
  extends: .ds-analyzer
  image:
    name: "$DS_ANALYZER_IMAGE"
  variables:
    # DS_ANALYZER_IMAGE is an undocumented variable used internally to allow QA to
    # override the analyzer image with a custom value. This may be subject to change or
    # breakage across GitLab releases.
    DS_ANALYZER_IMAGE: "$SECURE_ANALYZERS_PREFIX/gemnasium-python:$DS_MAJOR_VERSION"
    # Stop reporting Pipenv and Setuptools as "pip".
    # See https://gitlab.com/gitlab-org/gitlab/-/issues/338252
    DS_REPORT_PACKAGE_MANAGER_PIP_WHEN_PYTHON: "false"
  rules:
    - if: $DEPENDENCY_SCANNING_DISABLED
      when: never
    - if: $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/
      when: never
    - if: $CI_COMMIT_BRANCH &&
          $GITLAB_FEATURES =~ /\bdependency_scanning\b/ &&
          $DS_DEFAULT_ANALYZERS =~ /gemnasium-python/
      exists:
        - '{requirements.txt,*/requirements.txt,*/*/requirements.txt}'
        - '{requirements.pip,*/requirements.pip,*/*/requirements.pip}'
        - '{Pipfile,*/Pipfile,*/*/Pipfile}'
        - '{requires.txt,*/requires.txt,*/*/requires.txt}'
        - '{setup.py,*/setup.py,*/*/setup.py}'
        # Support passing of $PIP_REQUIREMENTS_FILE
        # See https://docs.gitlab.com/ee/user/application_security/dependency_scanning/#configuring-specific-analyzers-used-by-dependency-scanning
    - if: $CI_COMMIT_BRANCH &&
          $GITLAB_FEATURES =~ /\bdependency_scanning\b/ &&
          $DS_DEFAULT_ANALYZERS =~ /gemnasium-python/ &&
          $PIP_REQUIREMENTS_FILE

Ansible Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: ansible/requirements.txt


conventional_commits Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: conventional_commits/requirements.txt


gitlab_release Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: gitlab_release/requirements.txt


mkdocs Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: mkdocs/requirements.txt


python Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: python/requirements.txt


yaml_lint Dependencies:
  extends: .gemnasium-python-dependency_scanning
  variables:
    PIP_REQUIREMENTS_FILE: yaml_lint/requirements.txt
```suggestion:-0+0 # Scanner doesn't Pickup multiple pip files. Disable and specify jobs with pip file. gemnasium-python-dependency_scanning: rules: - when: never # source: https://gitlab.com/gitlab-org/gitlab/-/blob/2f33a8cb4dcea7b875e360d4cd9e016e027d2973/lib/gitlab/ci/templates/Security/Dependency-Scanning.gitlab-ci.yml .gemnasium-python-dependency_scanning: extends: .ds-analyzer image: name: "$DS_ANALYZER_IMAGE" variables: # DS_ANALYZER_IMAGE is an undocumented variable used internally to allow QA to # override the analyzer image with a custom value. This may be subject to change or # breakage across GitLab releases. DS_ANALYZER_IMAGE: "$SECURE_ANALYZERS_PREFIX/gemnasium-python:$DS_MAJOR_VERSION" # Stop reporting Pipenv and Setuptools as "pip". # See https://gitlab.com/gitlab-org/gitlab/-/issues/338252 DS_REPORT_PACKAGE_MANAGER_PIP_WHEN_PYTHON: "false" rules: - if: $DEPENDENCY_SCANNING_DISABLED when: never - if: $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/ when: never - if: $CI_COMMIT_BRANCH && $GITLAB_FEATURES =~ /\bdependency_scanning\b/ && $DS_DEFAULT_ANALYZERS =~ /gemnasium-python/ exists: - '{requirements.txt,*/requirements.txt,*/*/requirements.txt}' - '{requirements.pip,*/requirements.pip,*/*/requirements.pip}' - '{Pipfile,*/Pipfile,*/*/Pipfile}' - '{requires.txt,*/requires.txt,*/*/requires.txt}' - '{setup.py,*/setup.py,*/*/setup.py}' # Support passing of $PIP_REQUIREMENTS_FILE # See https://docs.gitlab.com/ee/user/application_security/dependency_scanning/#configuring-specific-analyzers-used-by-dependency-scanning - if: $CI_COMMIT_BRANCH && $GITLAB_FEATURES =~ /\bdependency_scanning\b/ && $DS_DEFAULT_ANALYZERS =~ /gemnasium-python/ && $PIP_REQUIREMENTS_FILE Ansible Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: ansible/requirements.txt conventional_commits Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: conventional_commits/requirements.txt gitlab_release Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: gitlab_release/requirements.txt mkdocs Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: mkdocs/requirements.txt python Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: python/requirements.txt yaml_lint Dependencies: extends: .gemnasium-python-dependency_scanning variables: PIP_REQUIREMENTS_FILE: yaml_lint/requirements.txt ```
jon_nfc commented 2022-01-23 07:36:52 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 2fffa866 - ci(python_dependency_scan): disabled main job and manual setup for all ci jobs.

Compare with previous version

added 1 commit <ul><li>2fffa866 - ci(python_dependency_scan): disabled main job and manual setup for all ci jobs.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316635178&start_sha=6668c2fb8d7545b4f9052ad3065e58f00d11be62)
jon_nfc commented 2022-01-23 07:44:30 +00:00 (Migrated from gitlab.com)
Copy Link

Not needed

```suggestion:-10+0 ``` Not needed
jon_nfc commented 2022-01-23 07:50:04 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 24 of the diff

changed this line in [version 24 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316635947&start_sha=2fffa866d84f460893c8d9711bc21a74908edb3e#587d266bb27a4dc3022bbed44dfa19849df3044c_53_43)
jon_nfc commented 2022-01-23 07:50:04 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 41c5e0ca - chore: remove dependency scan rules not required

Compare with previous version

added 1 commit <ul><li>41c5e0ca - chore: remove dependency scan rules not required</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316635947&start_sha=2fffa866d84f460893c8d9711bc21a74908edb3e)
jon_nfc commented 2022-01-23 07:55:12 +00:00 (Migrated from gitlab.com)
Copy Link
    PIP_REQUIREMENTS_FILE: "conventional_commits/requirements.txt"
```suggestion:-0+0 PIP_REQUIREMENTS_FILE: "conventional_commits/requirements.txt" ```
jon_nfc commented 2022-01-23 07:55:12 +00:00 (Migrated from gitlab.com)
Copy Link
    PIP_REQUIREMENTS_FILE: ./gitlab_release/requirements.txt
```suggestion:-0+0 PIP_REQUIREMENTS_FILE: ./gitlab_release/requirements.txt ```
jon_nfc commented 2022-01-23 07:55:12 +00:00 (Migrated from gitlab.com)
Copy Link
    PIP_REQUIREMENTS_FILE: "./mkdocs/requirements.txt"
```suggestion:-0+0 PIP_REQUIREMENTS_FILE: "./mkdocs/requirements.txt" ```
jon_nfc commented 2022-01-23 07:56:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316636285&start_sha=41c5e0ca823941de9d37e99710c6ba95710e5a2c#587d266bb27a4dc3022bbed44dfa19849df3044c_59_59)
jon_nfc commented 2022-01-23 07:56:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316636285&start_sha=41c5e0ca823941de9d37e99710c6ba95710e5a2c#587d266bb27a4dc3022bbed44dfa19849df3044c_65_65)
jon_nfc commented 2022-01-23 07:56:08 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 25 of the diff

changed this line in [version 25 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316636285&start_sha=41c5e0ca823941de9d37e99710c6ba95710e5a2c#587d266bb27a4dc3022bbed44dfa19849df3044c_71_71)
jon_nfc commented 2022-01-23 07:56:08 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • b8440832 - chore: test wich path works for specifying pip file.

Compare with previous version

added 1 commit <ul><li>b8440832 - chore: test wich path works for specifying pip file.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316636285&start_sha=41c5e0ca823941de9d37e99710c6ba95710e5a2c)
jon_nfc commented 2022-01-23 08:39:24 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in issue gitlab-org/gitlab#350949

mentioned in issue gitlab-org/gitlab#350949
jon_nfc commented 2022-01-23 08:52:20 +00:00 (Migrated from gitlab.com)
Copy Link

Failed dep scan jobs bug reported at gitlab-org/gitlab#350949

Failed dep scan jobs bug reported at gitlab-org/gitlab#350949
jon_nfc commented 2022-01-23 08:56:19 +00:00 (Migrated from gitlab.com)
Copy Link
    JOB_ROOT_DIR: '.'
    SECURE_LOG_LEVEL: debug
```suggestion:-0+0 JOB_ROOT_DIR: '.' SECURE_LOG_LEVEL: debug ```
jon_nfc commented 2022-01-23 08:57:01 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 725bfaf8 - ci: debug logging for dep scanning

Compare with previous version

added 1 commit <ul><li>725bfaf8 - ci: debug logging for dep scanning</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316640768&start_sha=b8440832070eb1e66ad4ebfea1eacfccf276a988)
jon_nfc commented 2022-01-24 03:46:21 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 5ba5c578 - ci(dependency_scanning): scanner set to use python 3.6

Compare with previous version

added 1 commit <ul><li>5ba5c578 - ci(dependency_scanning): scanner set to use python 3.6</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316773396&start_sha=725bfaf829069002e3b2cb944556d2ce5facb426)
jon_nfc commented 2022-01-24 03:49:20 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 996ee64a - ci(dependency_scanning): scanner set to use python 3.6

Compare with previous version

added 1 commit <ul><li>996ee64a - ci(dependency_scanning): scanner set to use python 3.6</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316774058&start_sha=5ba5c578993b6793979edc6c2e516beeb1857de0)
jon_nfc commented 2022-01-24 03:54:33 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 7153f9b4 - ci(dependency_scanning): check python version as pillow 9.0 reported as not found.

Compare with previous version

added 1 commit <ul><li>7153f9b4 - ci(dependency_scanning): check python version as pillow 9.0 reported as not found.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316775174&start_sha=996ee64ab43f926ca52ab3154ab43e20b6d48fcb)
jon_nfc commented 2022-01-24 03:57:18 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • a6afa766 - ci(dependency_scanning): increase python version to 3.7

Compare with previous version

added 1 commit <ul><li>a6afa766 - ci(dependency_scanning): increase python version to 3.7</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316775791&start_sha=7153f9b42591e177112d279d2134fc0db1f5a14d)
jon_nfc commented 2022-01-24 04:05:24 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 7033ade0 - ci(dependency_scanning): python 3.7 not available for dependecy scanning.

Compare with previous version

added 1 commit <ul><li>7033ade0 - ci(dependency_scanning): python 3.7 not available for dependecy scanning.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316777700&start_sha=a6afa76600e07d40e8b94fa2d8385ad78634e3b0)
jon_nfc commented 2022-01-24 04:29:38 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 4e1da5e8 - ci(dependency_scanning): python 3.7 not available for dependecy scanning.
  • 23615856 - ci(dependency_scanning): delete all python 'requirements.txt' files that are...

Compare with previous version

added 2 commits <ul><li>4e1da5e8 - ci(dependency_scanning): python 3.7 not available for dependecy scanning.</li><li>23615856 - ci(dependency_scanning): delete all python &#39;requirements.txt&#39; files that are...</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316783878&start_sha=7033ade04e02756eb19934cf45cf65221a933030)
jon_nfc commented 2022-01-24 04:41:09 +00:00 (Migrated from gitlab.com)
Copy Link

added 2 commits

  • 39a76a08 - ci(dependency_scanning): delete all python 'requirements.txt' files that are...
  • a2d705de - ci(mkdcos): mkdocs requirements.txt had a '\n' in the filename. renamed.

Compare with previous version

added 2 commits <ul><li>39a76a08 - ci(dependency_scanning): delete all python &#39;requirements.txt&#39; files that are...</li><li>a2d705de - ci(mkdcos): mkdocs requirements.txt had a &#39;\n&#39; in the filename. renamed.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316786747&start_sha=2361585650f46022996d2dd2bb5d4b8ae5740c76)
jon_nfc commented 2022-01-24 05:08:04 +00:00 (Migrated from gitlab.com)
Copy Link

didnt work. scrap idea until npm is learned.

didnt work. scrap idea until npm is learned.
jon_nfc commented 2022-01-24 05:08:42 +00:00 (Migrated from gitlab.com)
Copy Link

update issue with workaround.

update issue with workaround.
jon_nfc commented 2022-01-24 05:08:43 +00:00 (Migrated from gitlab.com)
Copy Link

added 2h 37m of time spent

added 2h 37m of time spent
jon_nfc commented 2022-01-24 05:14:01 +00:00 (Migrated from gitlab.com)
Copy Link

disabled due to gitlab-org/gitlab#350949

disabled due to gitlab-org/gitlab#350949
jon_nfc commented 2022-01-24 05:14:01 +00:00 (Migrated from gitlab.com)
Copy Link

no longer required as it's included in the ci job to copy to root of the repository.

```suggestion:-1+0 ``` no longer required as it's included in the ci job to copy to root of the repository.
jon_nfc commented 2022-01-24 05:14:57 +00:00 (Migrated from gitlab.com)
Copy Link

changed this line in version 34 of the diff

changed this line in [version 34 of the diff](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316795358&start_sha=a2d705deb1f3898b6d5fa4d55bd995b1a7ad4b68#3da1405315555c98432363c34b0c6b79f05a9a86_14_14)
jon_nfc commented 2022-01-24 05:14:58 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • b6dcb47b - docs(markdown_lint): removed no longer needed requirement.

Compare with previous version

added 1 commit <ul><li>b6dcb47b - docs(markdown_lint): removed no longer needed requirement.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316795358&start_sha=a2d705deb1f3898b6d5fa4d55bd995b1a7ad4b68)
jon_nfc commented 2022-01-24 05:19:53 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 4d5fa247 - ci(markdown_lint): Added Linting of Markdown for files in this repository.

Compare with previous version

added 1 commit <ul><li>4d5fa247 - ci(markdown_lint): Added Linting of Markdown for files in this repository.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316796627&start_sha=b6dcb47b1d1831784d36f482fd99c0ce5e56f088)
jon_nfc commented 2022-01-24 05:21:14 +00:00 (Migrated from gitlab.com)
Copy Link

added 1 commit

  • 3096d7ee - ci(markdown_lint): Added Linting of Markdown for files in this repository.

Compare with previous version

added 1 commit <ul><li>3096d7ee - ci(markdown_lint): Added Linting of Markdown for files in this repository.</li></ul> [Compare with previous version](/nofusscomputing/projects/gitlab-ci/-/merge_requests/15/diffs?diff_id=316796966&start_sha=4d5fa2473644b08436f15e6525f579aac8b5b235)
jon_nfc commented 2022-01-24 05:44:36 +00:00 (Migrated from gitlab.com)
Copy Link

done https://gitlab.com/gitlab-org/gitlab/-/issues/350949#note_819013439

done https://gitlab.com/gitlab-org/gitlab/-/issues/350949#note_819013439
jon_nfc commented 2022-01-24 05:44:37 +00:00 (Migrated from gitlab.com)
Copy Link

resolved all threads

resolved all threads
jon_nfc commented 2022-01-24 05:44:57 +00:00 (Migrated from gitlab.com)
Copy Link

added 27m of time spent

added 27m of time spent
jon_nfc commented 2022-01-24 05:45:05 +00:00 (Migrated from gitlab.com)
Copy Link

added 10m of time spent

added 10m of time spent
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit e0d8885d52

mentioned in commit e0d8885d52319a6188c779e80c2064b773721184
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit fc816192be

mentioned in commit fc816192be680f64ee1b4b96cccd0d605c529b86
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 347597e3c1

mentioned in commit 347597e3c1cb20eaa32d1e1cbb2d9d13661a663a
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 7665e512a5

mentioned in commit 7665e512a5d6e5aab3f8c0a8241d4182f3362442
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5c872f163e

mentioned in commit 5c872f163e4de5834efd74a78e3e948d242916ec
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 6383cde3bf

mentioned in commit 6383cde3bf9985b2cb43908bc2486d1dc67b7026
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5c05ed7605

mentioned in commit 5c05ed7605ddbecb1a3c7046716afa07829c264f
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 954aa28dbf

mentioned in commit 954aa28dbf1073be05a3dd6d13da818a0bc7cb4e
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 50b5e8542b

mentioned in commit 50b5e8542b827e6b6cf70f3f4c26b4c1737fe0c1
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 1ef0e2245f

mentioned in commit 1ef0e2245facffb760ba2ad9a57af1d6178a2d1a
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit bc67e939fa

mentioned in commit bc67e939faf0b3d2eac05eae7edf297c81e55739
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 5a41962a99

mentioned in commit 5a41962a994a54d99a3e7ab1bc0d7379ea14c1c2
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 83cce72af2

mentioned in commit 83cce72af22b09bd8a245af99e9134d3be129eac
jon_nfc commented 2022-01-24 05:45:46 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 906f09e2d3

mentioned in commit 906f09e2d3285681bd982d65eda3f56cf5a5169e
jon_nfc (Migrated from gitlab.com) merged commit d71def2f2a into development 2022-01-24 05:45:46 +00:00
jon_nfc commented 2022-01-24 05:45:47 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit d71def2f2a

mentioned in commit d71def2f2a08367f4c4297dc1e4de931cfda8b7b
jon_nfc commented 2022-01-24 06:27:31 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 484d98792a

mentioned in commit 484d98792a27c9d967331e9d3cd1afdca435bdd6
jon_nfc commented 2022-01-24 06:27:31 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit e1894ec0c4

mentioned in commit e1894ec0c4fe7504901682f008c2ff0db7e351fe
jon_nfc commented 2022-01-24 06:27:32 +00:00 (Migrated from gitlab.com)
Copy Link

mentioned in commit 0df60b12db

mentioned in commit 0df60b12dbfff983ca3a671b90ab1be126597e52
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Bug
Used in discussion about a bug in comments or commits
CVE-2023-5764
Denotes items related to the CVE
CodeReview
Used in comments (issues/MR/commits) to denote code review related items
Documentation
Documentation items
Feature
Used in discussion about a Feature in comments or commits
Lint
Used in comments (issues/MR/commits) to denote lint tasks todo, done, fixed
Privacy
Used in comments (issues/MR/commits) to denote privacy related items
Security
Used in comments (issues/MR/commits) to denote Security related items
breaking-change
label used to denote that the issue/Merge Request does/will introduce a breaking change
bug::reproducable
Given to an issue when the bug has been confirmed as re-producable. Can also be used in comments and commits.
bug::unable to reproduce
Given to an issue when the bug that is not able to be reproduced. Can also be used in comments and commits.
code review::complete
code review::not started
code review::rejected
code review::underway
difficulty::Full Development
Level 3. Difficulty representing that the task to complete must be planned and created.
difficulty::Good First Issue
Level 1. Difficulty representing that the task is very simple and with limited knowledge can be completed.
difficulty::Prior Knowledge
Level 2. Difficulty representing that the task requires some prior knowledge of either the technology or the project for task completion.
documentation::complete
Issues, Merge Requests
documentation::no change required
Issues, Merge Requests and used to denote no documentation changes required
documentation::not started
Issues, Merge Requests
documentation::stalled
Issues, Merge Requests
documentation::underway
Issues, Merge Requests
impact::0
impact::1
impact::2
impact::3
impact::4
impact::5
ops::ansible-roles
OPS project tag
ops::automation
ops::gitlab-ci
OPS project tag
ops::marcas
OPS project tag
ops::python-gitlab-management
OPS project tag
ops::website
priority::0
priority::1
priority::2
priority::3
priority::4
priority::5
stage::Ready for Development
stage::develop
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::feedback required
stage::planning
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stage::test
Stage for use in Issues and Merge Requests. Can also be used in discussion in comments and commits
stale
Label given to issues/merge requests that are considered stale due to no collaboration and is a mark for closure.
triage
Tag given to issues/merge requests requiring triaging by the team.
triage::not_confidential
This tag is given by the triage bot so that URLs can be added to an issue/comment. A triage policy for NFC wide should remove this label.
type::CI / CD
type::automation
This type is used to denote an automation job
type::bug
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::compliance
type::discussion
Type for Issues. Can also be used in discussion in comments.
type::documentation
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::feature
type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::invalid
label given to tickets that require no action or are deem as invalid.
type::quality assurance
Type for Issues and Merge Requests. Can also be used in discussion in comments and commits
type::question
Type for Issues. Can also be used in discussion in comments.
type::security
Type for Issues and Merge Requests.
type::specification
Design specification
workflow::complete
Issues, Merge Requests
workflow::not ready
workflow::not ready::blocked
workflow::not started
Issues, Merge Requests
workflow::ready to commence
Issues, Merge Requests
workflow::stalled
Label given to issues/merge requests where no work has occured in x days iaw triage policy.
workflow::underway
Issues, Merge Requests
workflow::underway::develop
Area/CI-CD
Documentation changes
Area/Documentation
Documentation changes
Area/Security
This is security issue
Area/Testing
Issue or pull request related to testing
Bug
Failure to Confirm
Bug exists due to not confirming/testing code
Bug
Regression
THe bug is a regression of a feature
Bug
To be Confirmed
This bug is not confirmed
Bug
Unable to Reproduce
A developer can not re-create/re-produce the bug
Compat/Breaking
Breaking change that won't be backward compatible
Impact
Critical
1
The impact is critical in that it is blocking or prevents usage.
Impact
High
2
The impact requires that changes be made for continuted usage.
Impact
Low
4
The impact requires the user approach from a different angle for continued usage.
Impact
Medium
3
The impact requires a workaround for continued usage.
Impact
Very Low
5
The impact has a slight effect on usage.
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Priority
Very High
1
The priority is critical
Priority
Very Low
5
The priority is very low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Type
Bug
Something is not working
Type
Epic
Epic User Story
Type
Feature
Feature / Module
Type
Incident
Something occured related to a service
Type
RFE
Request for Enhancement
Type
Task
A work item that must be done
Urgency
Low
4
Prioritize this amoungst your list of things to do.
Urgency
Major
1
Urgency is so high it should have been dealt with last week.
Urgency
Medium
3
Start as soon as possible.
Urgency
Very High
2
Urgency is high enough to warrant near immediate commencement.
Urgency
Very Low
5
Add this to your list of things to do.
No Label
impact::0
priority::3
stage::develop
type::feature
Milestone
No items
No Milestone v1.0.0
Projects
Clear projects
No project
Assignees
Clear assignees
jason jon
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infrastructure/gitlab-ci#65
No description provided.
Delete Branch "12-15-mkdocs-build-markdown-linting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?