refactor(project_management): Serializer Unit Test Suite re-written to Pytest for model ProjectState

ref: #938 #936

app/project_management/tests/functional/project_state/test_project_state_serializer.py

@@ -1,83 +0,0 @@
-import pytest
-
-from django.test import TestCase
-
-from rest_framework.exceptions import ValidationError
-
-from access.models.tenant import Tenant as Organization
-
-from centurion.tests.abstract.mock_view import MockView, User
-
-from project_management.serializers.project_states import (
-    ProjectState,
-    ProjectStateModelSerializer
-)
-
-
-
-class ProjectStateValidationAPI(
-    TestCase,
-):
-
-    model = ProjectState
-
-    @classmethod
-    def setUpTestData(self):
-        """Setup Test
-
-        1. Create an org
-        2. Create an item
-        """
-
-        organization = Organization.objects.create(name='test_org')
-
-        self.user = User.objects.create_user(username="test_user_view", password="password")
-
-        self.organization = organization
-
-        self.mock_view = MockView( user = self.user )
-
-
-
-    def test_serializer_validation_can_create(self):
-        """Serializer Validation Check
-
-        Ensure that a valid item can be creates
-        """
-
-        serializer = ProjectStateModelSerializer(
-            context = {
-                'request': self.mock_view.request,
-                'view': self.mock_view,
-            },
-            data={
-                "organization": self.organization.id,
-                "name": 'a project'
-            }
-        )
-
-        assert serializer.is_valid(raise_exception = True)
-
-
-
-    def test_serializer_validation_no_name(self):
-        """Serializer Validation Check
-
-        Ensure that if creating and no name is provided a validation error occurs
-        """
-
-        with pytest.raises(ValidationError) as err:
-
-            serializer = ProjectStateModelSerializer(
-                context = {
-                    'request': self.mock_view.request,
-                    'view': self.mock_view,
-                },
-                data={
-                    "organization": self.organization.id,
-                },
-            )
-
-            serializer.is_valid(raise_exception = True)
-
-        assert err.value.get_codes()['name'][0] == 'required'

app/project_management/tests/unit/project_state/test_unit_project_state_serializer.py

@@ -0,0 +1,68 @@
+import pytest
+
+from django.db import models
+
+from rest_framework.exceptions import ValidationError
+
+from api.tests.unit.test_unit_serializer import (
+    SerializerTestCases
+)
+
+from centurion.tests.abstract.mock_view import MockView
+# from project_management.serializers.project import (
+#     ProjectState,
+# )
+
+
+
+@pytest.mark.model_projectstate
+class ProjectStateSerializerTestCases(
+    SerializerTestCases
+):
+
+
+    def test_serializer_validation_no_name(self,
+        kwargs_api_create, model, model_serializer, request_user
+    ):
+        """Serializer Validation Check
+
+        Ensure that if creating and no name is provided a validation error occurs
+        """
+
+        mock_view = MockView(
+            user = request_user,
+            model = model,
+            action = 'create',
+        )
+
+        kwargs = kwargs_api_create.copy()
+        del kwargs['name']
+
+        with pytest.raises(ValidationError) as err:
+
+            serializer = model_serializer['model'](
+                context = {
+                    'request': mock_view.request,
+                    'view': mock_view,
+                },
+                data = kwargs,
+            )
+
+            serializer.is_valid(raise_exception = True)
+
+        assert err.value.get_codes()['name'][0] == 'required'
+
+
+
+class ProjectStateSerializerInheritedCases(
+    ProjectStateSerializerTestCases
+):
+    pass
+
+
+
+@pytest.mark.module_project_management
+class ProjectStateSerializerPyTest(
+    ProjectStateSerializerTestCases
+):
+    pass

app/tests/fixtures/__init__.py

@@ -248,6 +248,7 @@ from .model_projectmilestone import (
 from .model_projectstate import (
     kwargs_projectstate,
     model_projectstate,
+    serializer_projectstate,
 )
 
 from .model_projecttype import (

app/tests/fixtures/model_knowledgebase.py

@@ -1,6 +1,8 @@
 import datetime
 import pytest
 
+from django.db import models
+
 from assistance.models.knowledge_base import KnowledgeBase
 from assistance.serializers.knowledge_base import (
     KnowledgeBaseBaseSerializer,
@@ -66,10 +68,14 @@ def kwargs_knowledgebase(django_db_blocker,
         try:
 
             user.delete()
-        except:
+        except models.deletion.ProtectedError:
+            pass
+
+        try:
+            category.delete()
+        except models.deletion.ProtectedError:
             pass
 
-        category.delete()
 
 
 @pytest.fixture( scope = 'class')

app/tests/fixtures/model_projectstate.py

@@ -1,8 +1,14 @@
 import datetime
 import pytest
 
-from project_management.models.project_states import ProjectState
+from django.db import models
 
+from project_management.models.project_states import ProjectState
+from project_management.serializers.project_states import (
+    ProjectStateBaseSerializer,
+    ProjectStateModelSerializer,
+    ProjectStateViewSerializer,
+)
 
 
 @pytest.fixture( scope = 'class')
@@ -12,18 +18,47 @@ def model_projectstate():
 
 
 @pytest.fixture( scope = 'class')
-def kwargs_projectstate(kwargs_centurionmodel):
+def kwargs_projectstate(kwargs_centurionmodel, django_db_blocker,
+    model_knowledgebase, kwargs_knowledgebase,
+):
 
     random_str = str(datetime.datetime.now(tz=datetime.timezone.utc))
     random_str = str(random_str).replace(
             ' ', '').replace(':', '').replace('+', '').replace('.', '')
 
+    with django_db_blocker.unblock():
+
+        kwargs = kwargs_knowledgebase
+        team = kwargs['target_team']
+        del kwargs['target_team']
+
+        runbook = model_knowledgebase.objects.create( **kwargs )
+
+        runbook.target_team.add( team[0] )
+
     kwargs = kwargs_centurionmodel.copy()
-    del kwargs['model_notes']
 
     kwargs = {
         **kwargs,
         'name': 'projectstate_' + random_str,
+        'runbook': runbook,
     }
 
     yield kwargs.copy()
+
+    with django_db_blocker.unblock():
+
+        try:
+            runbook.delete()
+        except models.deletion.ProtectedError:
+            pass
+
+
+@pytest.fixture( scope = 'class')
+def serializer_projectstate():
+
+    yield {
+        'base': ProjectStateBaseSerializer,
+        'model': ProjectStateModelSerializer,
+        'view': ProjectStateViewSerializer
+    }