refactor(itim): Serializer Unit Test Suite re-written to Pytest for model Cluster

ref: #932 #928

app/itim/tests/functional/cluster/test_cluster_serializer.py

@@ -1,89 +0,0 @@
-import pytest
-
-from django.test import TestCase
-
-from rest_framework.exceptions import ValidationError
-
-from access.models.tenant import Tenant as Organization
-
-from centurion.tests.abstract.mock_view import MockView, User
-
-from itim.serializers.cluster import Cluster, ClusterModelSerializer
-
-
-
-class ClusterValidationAPI(
-    TestCase,
-):
-
-    model = Cluster
-
-    @classmethod
-    def setUpTestData(self):
-        """Setup Test
-
-        1. Create an org
-        2. Create an item
-        """
-
-        organization = Organization.objects.create(name='test_org')
-
-        self.user = User.objects.create_user(username="test_user_view", password="password")
-
-        self.organization = organization
-
-        self.item = self.model.objects.create(
-            organization=organization,
-            name = 'os name',
-        )
-
-        self.mock_view = MockView( user = self.user )
-
-
-
-    def test_serializer_validation_no_name(self):
-        """Serializer Validation Check
-
-        Ensure that if creating and no name is provided a validation error occurs
-        """
-
-        with pytest.raises(ValidationError) as err:
-
-            serializer = ClusterModelSerializer(
-                context = {
-                    'request': self.mock_view.request,
-                    'view': self.mock_view,
-                },
-                data={
-                "organization": self.organization.id,
-            })
-
-            serializer.is_valid(raise_exception = True)
-
-        assert err.value.get_codes()['name'][0] == 'required'
-
-
-
-    def test_serializer_validation_self_not_parent(self):
-        """Serializer Validation Check
-
-        Ensure that if assiging itself as parent a validation error occurs
-        """
-
-        with pytest.raises(ValidationError) as err:
-
-            serializer = ClusterModelSerializer(
-                self.item,
-                context = {
-                    'request': self.mock_view.request,
-                    'view': self.mock_view,
-                },
-                data={
-                    "parent_cluster": self.item.id,
-                },
-                partial = True
-            )
-
-            serializer.is_valid(raise_exception = True)
-
-        assert err.value.get_codes()['parent_cluster'] == 'parent_not_self'

app/itim/tests/unit/cluster/conftest.py

@@ -17,3 +17,9 @@ def model_kwargs(request, kwargs_cluster):
 
     if hasattr(request.cls, 'kwargs_create_item'):
         del request.cls.kwargs_create_item
+
+
+@pytest.fixture( scope = 'class')
+def model_serializer(serializer_cluster):
+
+    yield serializer_cluster

app/itim/tests/unit/cluster/test_unit_cluster_serializer.py

@@ -0,0 +1,142 @@
+import pytest
+
+from django.db import models
+
+from rest_framework.exceptions import ValidationError
+
+from api.tests.unit.test_unit_serializer import (
+    SerializerTestCases
+)
+
+from centurion.tests.abstract.mock_view import MockView
+
+
+
+@pytest.mark.model_cluster
+class ClusterSerializerTestCases(
+    SerializerTestCases
+):
+
+
+    @pytest.fixture( scope = 'function' )
+    def created_model(self, django_db_blocker, model, model_kwargs):
+
+        with django_db_blocker.unblock():
+
+            kwargs_many_to_many = {}
+
+            kwargs = {}
+
+            for key, value in model_kwargs.items():
+
+                field = model._meta.get_field(key)
+
+                if isinstance(field, models.ManyToManyField):
+
+                    kwargs_many_to_many.update({
+                        key: value
+                    })
+
+                else:
+
+                    kwargs.update({
+                        key: value
+                    })
+
+
+            item = model.objects.create( **kwargs )
+
+            for key, value in kwargs_many_to_many.items():
+
+                field = getattr(item, key)
+
+                for entry in value:
+
+                    field.add(entry)
+
+            yield item
+
+            item.delete()
+
+
+
+    def test_serializer_validation_no_name(self,
+        kwargs_api_create, model, model_serializer, request_user
+    ):
+        """Serializer Validation Check
+
+        Ensure that if creating and no name is provided a validation error occurs
+        """
+
+        mock_view = MockView(
+            user = request_user,
+            model = model,
+            action = 'create',
+        )
+
+        kwargs = kwargs_api_create.copy()
+        del kwargs['name']
+
+        with pytest.raises(ValidationError) as err:
+
+            serializer = model_serializer['model'](
+                context = {
+                    'request': mock_view.request,
+                    'view': mock_view,
+                },
+                data = kwargs,
+            )
+
+            serializer.is_valid(raise_exception = True)
+
+        assert err.value.get_codes()['name'][0] == 'required'
+
+
+
+    def test_serializer_validation_self_not_parent(self,
+        created_model,
+        kwargs_api_create, model, model_serializer, request_user
+    ):
+        """Serializer Validation Check
+
+        Ensure that if assiging itself as parent a validation error occurs
+        """
+
+        mock_view = MockView(
+            user = request_user,
+            model = model,
+            action = 'create',
+        )
+
+        with pytest.raises(ValidationError) as err:
+
+            serializer = model_serializer['model'](
+                created_model,
+                context = {
+                    'request': mock_view.request,
+                    'view': mock_view,
+                },
+                data={
+                    "parent_cluster":created_model.id,
+                },
+                partial = True
+            )
+
+            serializer.is_valid(raise_exception = True)
+
+        assert err.value.get_codes()['parent_cluster'] == 'parent_not_self'
+
+
+
+class ClusterSerializerInheritedCases(
+    ClusterSerializerTestCases
+):
+    pass
+
+
+
+@pytest.mark.module_itim
+class ClusterSerializerPyTest(
+    ClusterSerializerTestCases
+):
+    pass

app/tests/fixtures/__init__.py

@@ -61,6 +61,7 @@ from .model_checkin import (
 from .model_cluster import (
     kwargs_cluster,
     model_cluster,
+    serializer_cluster,
 )
 
 from .model_clustertype import (

app/tests/fixtures/model_cluster.py

@@ -2,6 +2,11 @@ import datetime
 import pytest
 
 from itim.models.clusters import Cluster
+from itim.serializers.cluster import (
+    ClusterBaseSerializer,
+    ClusterModelSerializer,
+    ClusterViewSerializer
+)
 
 
 
@@ -12,15 +17,43 @@ def model_cluster():
 
 
 @pytest.fixture( scope = 'class')
-def kwargs_cluster(kwargs_centurionmodel):
+def kwargs_cluster(kwargs_centurionmodel, django_db_blocker,
+    model_device, kwargs_device,
+    model_clustertype, kwargs_clustertype
+):
 
     random_str = str(datetime.datetime.now(tz=datetime.timezone.utc))
     random_str = str(random_str).replace(
             ' ', '').replace(':', '').replace('+', '').replace('.', '')
 
+    with django_db_blocker.unblock():
+
+        node = model_device.objects.create( **kwargs_device )
+        cluster_type = model_clustertype.objects.create( **kwargs_clustertype )
+
     kwargs = {
         **kwargs_centurionmodel.copy(),
         'name': 'cluster_' + random_str,
+        'nodes': [ node ],
+        'cluster_type': cluster_type,
+        'config': { 'config_key_1': 'config_value_1' }
     }
 
     yield kwargs.copy()
+
+
+    with django_db_blocker.unblock():
+
+        node.delete()
+        cluster_type.delete()
+
+
+
+@pytest.fixture( scope = 'class')
+def serializer_cluster():
+
+    yield {
+        'base': ClusterBaseSerializer,
+        'model': ClusterModelSerializer,
+        'view': ClusterViewSerializer
+    }