nofusscomputing/centurion_erp
1
0
Fork 0
Code Issues Wiki Activity

test(config_management): ViewSet Unit Test Suite re-written to pytest for model ConfigGroup

Browse Source 
ref: #908 #905
This commit is contained in:
Jon Lockwood
2025-07-30 08:27:02 +09:30
parent 98891be181
commit 6f58f2985c
8 changed files with 131 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/api/tests/unit/test_unit_common_viewset.py
View File

@ -377,6 +377,7 @@ class CommonViewSetTestCases(
)
view_set.request = request
view_set.kwargs = {}
yield view_set

3
app/assistance/tests/unit/knowledge_base/test_unit_knowledge_base_serializer.py
View File

@ -61,7 +61,8 @@ class KnowledgeBaseSerializerTestCases(
def test_serializer_validation_no_title(self,
kwargs_api_create, model, model_serializer, request_user):
kwargs_api_create, model, model_serializer, request_user
):
"""Serializer Validation Check
Ensure that if creating and no title is provided a validation error occurs

6
app/config_management/tests/unit/config_groups/conftest.py
View File

@ -17,3 +17,9 @@ def model_kwargs(request, kwargs_configgroups):
if hasattr(request.cls, 'kwargs_create_item'):
del request.cls.kwargs_create_item
@pytest.fixture( scope = 'class')
def model_serializer(serializer_configgroups):
yield serializer_configgroups

99
app/config_management/tests/unit/config_groups/test_unit_config_groups_viewset.py Normal file
View File

@ -0,0 +1,99 @@
import pytest
from api.tests.unit.test_unit_common_viewset import ModelViewSetInheritedCases
from config_management.viewsets.config_group import (
ConfigGroups,
ViewSet,
)
@pytest.mark.model_configgroups
class ViewsetTestCases(
ModelViewSetInheritedCases,
):
@pytest.fixture( scope = 'function' )
def viewset(self):
return ViewSet
@property
def parameterized_class_attributes(self):
return {
'_model_documentation': {
'type': type(None),
},
'back_url': {
'type': type(None),
},
'documentation': {
'type': type(None),
'value': None
},
'filterset_fields': {
'value': [
'organization',
'parent'
]
},
'model': {
'value': ConfigGroups
},
'model_documentation': {
'type': type(None),
},
'queryset': {
'type': type(None),
},
'serializer_class': {
'type': type(None),
},
'search_fields': {
'value': [
'name',
'config'
]
},
'view_description': {
'value': 'Configuration Groups'
},
'view_name': {
'type': type(None),
},
'view_serializer_name': {
'type': type(None),
}
}
def test_view_func_get_queryset_cache_result_used(self, mocker, viewset, viewset_mock_request):
qs = mocker.spy(viewset_mock_request.model, 'objects')
viewset_mock_request.get_queryset() # Initial QuerySet fetch/filter and cache
assert len(qs.method_calls) == 1 # one call to .all()
assert len(qs.mock_calls) == 3 # calls = .all(), all().filter()
viewset_mock_request.get_queryset() # Use Cached results, dont re-fetch QuerySet
assert len(qs.method_calls) == 1
assert len(qs.mock_calls) == 3
class KnowledgeBaseViewsetInheritedCases(
ViewsetTestCases,
):
pass
@pytest.mark.module_config_management
class KnowledgeBaseViewsetPyTest(
ViewsetTestCases,
):
pass

42
app/config_management/tests/unit/config_groups/unit_config_groups_viewset.py
View File

@ -1,42 +0,0 @@
from django.test import Client, TestCase
from rest_framework.reverse import reverse
from api.tests.unit.test_unit_common_viewset import ModelViewSetInheritedCases
from config_management.viewsets.config_group import ViewSet
@pytest.mark.skip(reason = 'see #895, tests being refactored')
class ConfigGroupsViewsetList(
ModelViewSetInheritedCases,
TestCase,
):
viewset = ViewSet
route_name = 'v2:_api_configgroups'
@classmethod
def setUpTestData(self):
"""Setup Test
1. make list request
"""
super().setUpTestData()
client = Client()
url = reverse(
self.route_name + '-list',
kwargs = self.kwargs
)
client.force_login(self.view_user)
self.http_options_response_list = client.options(url)

11
app/config_management/viewsets/config_group.py
View File

@ -74,7 +74,7 @@ class ViewSet( ModelViewSet ):
model = ConfigGroups
view_description = 'Information Management Knowledge Base Article(s)'
view_description = 'Configuration Groups'
def get_queryset(self):
@ -94,7 +94,7 @@ class ViewSet( ModelViewSet ):
else:
self.queryset = super().get_queryset().filter( parent = None )
return self.queryset
@ -105,12 +105,13 @@ class ViewSet( ModelViewSet ):
or self.action == 'retrieve'
):
self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
self.serializer_class = globals()[str(
self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
else:
self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
self.serializer_class = globals()[str(
self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
return self.serializer_class

1
app/tests/fixtures/__init__.py vendored
View File

@ -77,6 +77,7 @@ from .model_company import (
from .model_configgroup import (
kwargs_configgroups,
model_configgroups,
serializer_configgroups,
)
from .model_configgrouphost import (

16
app/tests/fixtures/model_configgroup.py vendored
View File

@ -2,6 +2,12 @@ import datetime
import pytest
from config_management.models.groups import ConfigGroups
from config_management.serializers.config_group import (
ConfigGroupBaseSerializer,
ConfigGroupModelSerializer,
ConfigGroupViewSerializer,
)
@pytest.fixture( scope = 'class')
@ -25,3 +31,13 @@ def kwargs_configgroups(django_db_blocker,
}
yield kwargs.copy()
@pytest.fixture( scope = 'class')
def serializer_configgroups():
yield {
'base': ConfigGroupBaseSerializer,
'model': ConfigGroupModelSerializer,
'view': ConfigGroupViewSerializer
}