refactor(itam): ViewSet Unit Test Suite re-written to Pytest for model DeviceModel
ref: #920 closes #916
This commit is contained in:
@ -1,160 +0,0 @@
|
||||
import django
|
||||
import pytest
|
||||
import unittest
|
||||
|
||||
from django.contrib.auth.models import Permission
|
||||
from django.contrib.contenttypes.models import ContentType
|
||||
from django.shortcuts import reverse
|
||||
from django.test import Client, TestCase
|
||||
|
||||
from rest_framework.relations import Hyperlink
|
||||
|
||||
from access.models.tenant import Tenant as Organization
|
||||
from access.models.team import Team
|
||||
from access.models.team_user import TeamUsers
|
||||
|
||||
from api.tests.abstract.api_fields import APITenancyObject
|
||||
|
||||
from core.models.manufacturer import Manufacturer
|
||||
|
||||
from itam.models.device import DeviceModel
|
||||
|
||||
User = django.contrib.auth.get_user_model()
|
||||
|
||||
|
||||
|
||||
class DeviceModelAPI(
|
||||
TestCase,
|
||||
APITenancyObject
|
||||
):
|
||||
|
||||
model = DeviceModel
|
||||
|
||||
@classmethod
|
||||
def setUpTestData(self):
|
||||
"""Setup Test
|
||||
|
||||
1. Create an organization for user and item
|
||||
2. Create an item
|
||||
|
||||
"""
|
||||
|
||||
self.organization = Organization.objects.create(name='test_org')
|
||||
|
||||
manufacturer = Manufacturer.objects.create(
|
||||
organization = self.organization,
|
||||
name = 'a manufacturer'
|
||||
)
|
||||
|
||||
self.item = self.model.objects.create(
|
||||
organization = self.organization,
|
||||
name = 'a model',
|
||||
manufacturer = manufacturer,
|
||||
model_notes = 'a note',
|
||||
)
|
||||
|
||||
self.url_view_kwargs = {'pk': self.item.id}
|
||||
|
||||
view_permissions = Permission.objects.get(
|
||||
codename = 'view_' + self.model._meta.model_name,
|
||||
content_type = ContentType.objects.get(
|
||||
app_label = self.model._meta.app_label,
|
||||
model = self.model._meta.model_name,
|
||||
)
|
||||
)
|
||||
|
||||
view_team = Team.objects.create(
|
||||
team_name = 'view_team',
|
||||
organization = self.organization,
|
||||
)
|
||||
|
||||
view_team.permissions.set([view_permissions])
|
||||
|
||||
self.view_user = User.objects.create_user(username="test_user_view", password="password")
|
||||
teamuser = TeamUsers.objects.create(
|
||||
team = view_team,
|
||||
user = self.view_user
|
||||
)
|
||||
|
||||
client = Client()
|
||||
url = reverse('v2:_api_devicemodel-detail', kwargs=self.url_view_kwargs)
|
||||
|
||||
|
||||
client.force_login(self.view_user)
|
||||
response = client.get(url)
|
||||
|
||||
self.api_data = response.data
|
||||
|
||||
|
||||
|
||||
def test_api_field_exists_manufacturer(self):
|
||||
""" Test for existance of API Field
|
||||
|
||||
manufacturer field must exist
|
||||
"""
|
||||
|
||||
assert 'manufacturer' in self.api_data
|
||||
|
||||
|
||||
def test_api_field_type_manufacturer(self):
|
||||
""" Test for type for API Field
|
||||
|
||||
manufacturer field must be dict
|
||||
"""
|
||||
|
||||
assert type(self.api_data['manufacturer']) is dict
|
||||
|
||||
|
||||
def test_api_field_exists_manufacturer_id(self):
|
||||
""" Test for existance of API Field
|
||||
|
||||
manufacturer.id field must exist
|
||||
"""
|
||||
|
||||
assert 'id' in self.api_data['manufacturer']
|
||||
|
||||
|
||||
def test_api_field_type_manufacturer_id(self):
|
||||
""" Test for type for API Field
|
||||
|
||||
manufacturer.id field must be int
|
||||
"""
|
||||
|
||||
assert type(self.api_data['manufacturer']['id']) is int
|
||||
|
||||
|
||||
def test_api_field_exists_manufacturer_display_name(self):
|
||||
""" Test for existance of API Field
|
||||
|
||||
manufacturer.display_name field must exist
|
||||
"""
|
||||
|
||||
assert 'display_name' in self.api_data['manufacturer']
|
||||
|
||||
|
||||
def test_api_field_type_manufacturer_display_name(self):
|
||||
""" Test for type for API Field
|
||||
|
||||
manufacturer.display_name field must be str
|
||||
"""
|
||||
|
||||
assert type(self.api_data['manufacturer']['display_name']) is str
|
||||
|
||||
|
||||
def test_api_field_exists_manufacturer_url(self):
|
||||
""" Test for existance of API Field
|
||||
|
||||
manufacturer.url field must exist
|
||||
"""
|
||||
|
||||
assert 'url' in self.api_data['manufacturer']
|
||||
|
||||
|
||||
def test_api_field_type_manufacturer_url(self):
|
||||
""" Test for type for API Field
|
||||
|
||||
manufacturer.url field must be Hyperlink
|
||||
"""
|
||||
|
||||
assert type(self.api_data['manufacturer']['url']) is Hyperlink
|
||||
|
@ -17,7 +17,7 @@ class DeviceModelModelTestCases(
|
||||
|
||||
@property
|
||||
def parameterized_class_attributes(self):
|
||||
|
||||
|
||||
return {
|
||||
'model_tag': {
|
||||
'type': str,
|
||||
@ -28,12 +28,12 @@ class DeviceModelModelTestCases(
|
||||
|
||||
@property
|
||||
def parameterized_model_fields(self):
|
||||
|
||||
|
||||
return {
|
||||
'name': {
|
||||
'blank': False,
|
||||
'default': models.fields.NOT_PROVIDED,
|
||||
'field_type': models.IntegerField,
|
||||
'field_type': models.CharField,
|
||||
'length': 50,
|
||||
'null': False,
|
||||
'unique': True,
|
||||
|
@ -1,44 +1,85 @@
|
||||
import pytest
|
||||
|
||||
from django.test import Client, TestCase
|
||||
|
||||
from rest_framework.reverse import reverse
|
||||
|
||||
from api.tests.unit.test_unit_common_viewset import ModelViewSetInheritedCases
|
||||
|
||||
from itam.viewsets.device_model import ViewSet
|
||||
from itam.viewsets.device_model import (
|
||||
DeviceModel,
|
||||
ViewSet,
|
||||
)
|
||||
|
||||
|
||||
|
||||
@pytest.mark.skip(reason = 'see #895, tests being refactored')
|
||||
class DeviceModelViewsetList(
|
||||
@pytest.mark.model_devicemodel
|
||||
class ViewsetTestCases(
|
||||
ModelViewSetInheritedCases,
|
||||
TestCase,
|
||||
):
|
||||
|
||||
viewset = ViewSet
|
||||
|
||||
route_name = 'v2:_api_devicemodel'
|
||||
@pytest.fixture( scope = 'function' )
|
||||
def viewset(self):
|
||||
return ViewSet
|
||||
|
||||
|
||||
@classmethod
|
||||
def setUpTestData(self):
|
||||
"""Setup Test
|
||||
|
||||
1. make list request
|
||||
"""
|
||||
@property
|
||||
def parameterized_class_attributes(self):
|
||||
return {
|
||||
'_model_documentation': {
|
||||
'type': type(None),
|
||||
},
|
||||
'back_url': {
|
||||
'type': type(None),
|
||||
},
|
||||
'documentation': {
|
||||
'type': type(None),
|
||||
'value': None
|
||||
},
|
||||
'filterset_fields': {
|
||||
'value': [
|
||||
'name',
|
||||
'manufacturer',
|
||||
'organization'
|
||||
]
|
||||
},
|
||||
'model': {
|
||||
'value': DeviceModel
|
||||
},
|
||||
'model_documentation': {
|
||||
'type': type(None),
|
||||
},
|
||||
'queryset': {
|
||||
'type': type(None),
|
||||
},
|
||||
'serializer_class': {
|
||||
'type': type(None),
|
||||
},
|
||||
'search_fields': {
|
||||
'value': [
|
||||
'name'
|
||||
]
|
||||
},
|
||||
'view_description': {
|
||||
'value': 'Device Models'
|
||||
},
|
||||
'view_name': {
|
||||
'type': type(None),
|
||||
},
|
||||
'view_serializer_name': {
|
||||
'type': type(None),
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
super().setUpTestData()
|
||||
|
||||
class DeviceModelViewsetInheritedCases(
|
||||
ViewsetTestCases,
|
||||
):
|
||||
pass
|
||||
|
||||
|
||||
client = Client()
|
||||
|
||||
url = reverse(
|
||||
self.route_name + '-list',
|
||||
kwargs = self.kwargs
|
||||
)
|
||||
|
||||
client.force_login(self.view_user)
|
||||
@pytest.mark.module_itam
|
||||
class DeviceModelViewsetPyTest(
|
||||
ViewsetTestCases,
|
||||
):
|
||||
|
||||
self.http_options_response_list = client.options(url)
|
||||
pass
|
||||
|
9
app/tests/fixtures/model_device.py
vendored
9
app/tests/fixtures/model_device.py
vendored
@ -1,4 +1,3 @@
|
||||
import datetime
|
||||
import pytest
|
||||
import random
|
||||
|
||||
@ -23,8 +22,6 @@ def kwargs_device(django_db_blocker, kwargs_centurionmodel,
|
||||
model_devicetype, kwargs_devicetype,
|
||||
):
|
||||
|
||||
random_str = str(datetime.datetime.now(tz=datetime.timezone.utc))
|
||||
|
||||
with django_db_blocker.unblock():
|
||||
|
||||
device_model = model_devicemodel.objects.create( **kwargs_devicemodel )
|
||||
@ -33,10 +30,8 @@ def kwargs_device(django_db_blocker, kwargs_centurionmodel,
|
||||
|
||||
kwargs = {
|
||||
**kwargs_centurionmodel.copy(),
|
||||
'name': 'dev' + str(random_str).replace(
|
||||
' ', '').replace(':', '').replace('+', '').replace('.', ''),
|
||||
'serial_number': str(random_str).replace(
|
||||
' ', '').replace(':', '').replace('+', '').replace('.', ''),
|
||||
'name': 'dev-' + str( random.randint(10000, 99999) ),
|
||||
'serial_number': 'dev-' + str( random.randint(1, 99999) ),
|
||||
'uuid': '7318f7cc-e3e8-4680-a3bf-29d77ce' + str( random.randint(10000, 99999) ),
|
||||
'device_model': device_model,
|
||||
'device_type': device_type,
|
||||
|
18
app/tests/fixtures/model_devicemodel.py
vendored
18
app/tests/fixtures/model_devicemodel.py
vendored
@ -2,6 +2,11 @@ import datetime
|
||||
import pytest
|
||||
|
||||
from itam.models.device import DeviceModel
|
||||
from itam.serializers.device_model import (
|
||||
DeviceModelBaseSerializer,
|
||||
DeviceModelModelSerializer,
|
||||
DeviceModelViewSerializer,
|
||||
)
|
||||
|
||||
|
||||
|
||||
@ -12,18 +17,29 @@ def model_devicemodel():
|
||||
|
||||
|
||||
@pytest.fixture( scope = 'class')
|
||||
def kwargs_devicemodel(kwargs_centurionmodel):
|
||||
def kwargs_devicemodel(kwargs_centurionmodel, django_db_blocker,
|
||||
model_manufacturer, kwargs_manufacturer,
|
||||
):
|
||||
|
||||
random_str = str(datetime.datetime.now(tz=datetime.timezone.utc))
|
||||
|
||||
with django_db_blocker.unblock():
|
||||
|
||||
manufacturer = model_manufacturer.objects.create( **kwargs_manufacturer )
|
||||
|
||||
kwargs = {
|
||||
**kwargs_centurionmodel.copy(),
|
||||
'name': 'dev' + str(random_str).replace(
|
||||
' ', '').replace(':', '').replace('+', '').replace('.', ''),
|
||||
'manufacturer': manufacturer,
|
||||
}
|
||||
|
||||
yield kwargs.copy()
|
||||
|
||||
with django_db_blocker.unblock():
|
||||
|
||||
manufacturer.delete()
|
||||
|
||||
|
||||
@pytest.fixture( scope = 'class')
|
||||
def serializer_devicemodel():
|
||||
|
Reference in New Issue
Block a user