nofusscomputing/centurion_erp
1
0
Fork 0
Code Issues Wiki Activity

fix(devops): After fetching feature flags dont attempt to access results unless status=200

Browse Source 
ref: #688 #687
This commit is contained in:
Jon Lockwood
2025-03-17 12:52:10 +09:30
parent bf973d3765
commit becb1eef26
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/centurion_feature_flag/lib/feature_flag.py
View File

@ -258,16 +258,21 @@ class CenturionFeatureFlagging:
self._response = response self._response = response
fetched_flags += resp.json()['results']
if resp.status_code == 304: # Nothing has changed, exit the loop if resp.status_code == 304: # Nothing has changed, exit the loop
url = None url = None
else: # Fetch next page of results elif resp.ok: # Fetch next page of results
fetched_flags += resp.json()['results']
url = resp.json()['next'] url = resp.json()['next']
else:
url = None
except requests.exceptions.ConnectionError as err: except requests.exceptions.ConnectionError as err:
print(f'Error Connecting to {url}') print(f'Error Connecting to {url}')