chore: correct pylint errors

ref: #765

app/access/fields.py

@@ -1,6 +1,5 @@
 from django.db import models
 from django.utils.timezone import now
-from django.template.defaultfilters import slugify
 
 class AutoCreatedField(models.DateTimeField):
     """

app/access/middleware/request.py

@@ -1,10 +1,5 @@
 import django
 
-from django.contrib.auth.middleware import (
-    AuthenticationMiddleware,
-    SimpleLazyObject,
-    partial,
-)
 from django.contrib.auth.models import Group
 from django.utils.deprecation import MiddlewareMixin
 

app/access/mixin.py

@@ -1,5 +1,5 @@
 
-from django.contrib.auth.mixins import AccessMixin, PermissionRequiredMixin
+from django.contrib.auth.mixins import AccessMixin
 from django.contrib.auth.models import Group
 from django.core.exceptions import PermissionDenied
 from django.utils.functional import cached_property

app/access/mixins/organization.py

@@ -1,10 +1,8 @@
 import django
 
-from django.contrib.auth.models import Group
 from django.db import models
 
 from access.models.tenant import Tenant as Organization
-from access.models.team import Team
 
 User = django.contrib.auth.get_user_model()
 

app/access/mixins/permissions.py

@@ -1,8 +1,5 @@
 import traceback
 
-from django.core.exceptions import ObjectDoesNotExist
-
-from rest_framework import exceptions
 from rest_framework.permissions import DjangoObjectPermissions
 
 from access.models.tenancy import Tenant, TenancyObject

app/access/models/__init__.py

@@ -1,4 +1,4 @@
-from . import contact
-from . import company_base
-from . import person
-from . import role
+from . import contact    # pylint: disable=W0611:unused-import
+from . import company_base    # pylint: disable=W0611:unused-import
+from . import person    # pylint: disable=W0611:unused-import
+from . import role    # pylint: disable=W0611:unused-import

app/access/models/entity.py

@@ -5,8 +5,6 @@ from rest_framework.reverse import reverse
 from access.fields import AutoCreatedField, AutoLastModifiedField
 from access.models.tenancy import TenancyObject
 
-from core.lib.feature_not_used import FeatureNotUsed
-
 
 
 class Entity(
@@ -107,7 +105,6 @@ class Entity(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/access/models/entity_history.py

@@ -4,7 +4,6 @@ from access.models.entity import Entity
 
 from core.models.model_history import ModelHistory
 
-from devops.models.feature_flag import FeatureFlag
 
 
 

app/access/models/organization.py

@@ -1 +1 @@
-from .tenant import Tenant as Organization
+from .tenant import Tenant as Organization    # pylint: disable=W0611:unused-import

app/access/models/tenancy.py

@@ -1,4 +1,3 @@
-import django
 import logging
 
 from django.db import models

app/access/serializers/organization_notes.py

@@ -1,13 +1,6 @@
-from rest_framework import serializers
-
 from access.models.organization_notes import OrganizationNotes
 
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/access/serializers/role_notes.py

@@ -1,13 +1,6 @@
-from rest_framework import serializers
-
 from access.models.role_notes import RoleNotes
 
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/access/serializers/team_notes.py

@@ -1,13 +1,6 @@
-from rest_framework import serializers
-
 from access.models.team_notes import TeamNotes
 
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/access/serializers/team_user.py

@@ -1,5 +1,3 @@
-from rest_framework.reverse import reverse
-
 from rest_framework import serializers
 
 from access.models.team_user import TeamUsers

app/access/serializers/teams.py

@@ -9,7 +9,7 @@ from api.serializers import common
 from access.functions.permissions import permission_queryset
 from access.serializers.organization import TenantBaseSerializer
 
-from centurion.serializers.permission import Permission, PermissionBaseSerializer
+from centurion.serializers.permission import PermissionBaseSerializer
 
 from core import fields as centurion_field
 

app/access/urls.py

@@ -1,6 +1,5 @@
 from django.urls import path
 
-from . import views
 from .views import team, organization, user
 
 app_name = "Access"

app/access/viewsets/organization.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from access.models.organization_history import OrganizationHistory    # pylint: disable=W0611:unused-import
-from access.serializers.organization import (
+from access.serializers.organization import (    # pylint: disable=W0611:unused-import
     Tenant,
     TenantModelSerializer,
     TenantViewSerializer

app/access/viewsets/team.py

@@ -3,7 +3,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiPara
 from access.models.tenant import Tenant as Organization
 # THis import only exists so that the migrations can be created
 from access.models.team_history import TeamHistory    # pylint: disable=W0611:unused-import
-from access.serializers.teams import (
+from access.serializers.teams import (    # pylint: disable=W0611:unused-import
     Team,
     TeamModelSerializer,
     TeamViewSerializer

app/access/viewsets/team_user.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiPara
 
 from access.models.team import Team
 
-from access.serializers.team_user import (
+from access.serializers.team_user import (    # pylint: disable=W0611:unused-import
     TeamUsers,
     TeamUserModelSerializer,
     TeamUserViewSerializer

app/accounting/models/__init__.py

@@ -1 +1 @@
-from .asset_base_history import AssetBaseHistory
+from .asset_base_history import AssetBaseHistory    # pylint: disable=W0611:unused-import

app/accounting/models/asset_base.py

@@ -6,8 +6,6 @@ from rest_framework.reverse import reverse
 from access.fields import AutoCreatedField, AutoLastModifiedField
 from access.models.tenancy import TenancyObject
 
-from core.lib.feature_not_used import FeatureNotUsed
-
 
 
 class AssetBase(
@@ -257,7 +255,6 @@ class AssetBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/api/models/__init__.py

@@ -1 +1 @@
-from . import tokens
+from . import tokens    # pylint: disable=W0611:unused-import

app/api/react_ui_metadata.py

@@ -3,11 +3,8 @@ import re
 from django.conf import settings
 from django.utils.encoding import force_str
 
-from django.contrib.auth.models import ContentType, Permission
-
 from rest_framework import serializers
 from rest_framework_json_api.metadata import JSONAPIMetadata
-from rest_framework.request import clone_request
 from rest_framework.reverse import reverse
 from rest_framework.utils.field_mapping import ClassLookupDict
 

app/api/serializers/access.py

@@ -1,4 +1,4 @@
-from rest_framework import serializers, request
+from rest_framework import serializers
 from rest_framework.reverse import reverse
 
 from access.models.tenant import Tenant as Organization

app/api/serializers/common.py

@@ -4,8 +4,6 @@ from rest_framework.reverse import reverse
 
 from access.serializers.organization import Tenant
 
-from assistance.models.model_knowledge_base_article import all_models
-
 from core import fields as centurion_field
 from core.lib.feature_not_used import FeatureNotUsed
 

app/api/serializers/core/ticket.py

@@ -3,8 +3,6 @@ from django.urls import reverse
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from api.serializers.core.ticket_comment import TicketCommentSerializer
-
 from core import exceptions as centurion_exception
 from core.forms.validate_ticket import TicketValidation
 from core.models.ticket.ticket import Ticket

app/api/serializers/core/ticket_category.py

@@ -1,11 +1,6 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from api.serializers.core.ticket_comment import TicketCommentSerializer
-
-from core.forms.validate_ticket import TicketValidation
 from core.models.ticket.ticket_category import TicketCategory
 
 

app/api/serializers/core/ticket_comment_category.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/itam/device.py

@@ -2,8 +2,6 @@ from django.urls import reverse
 
 from rest_framework import serializers
 
-from api.serializers.config import ParentGroupSerializer
-
 from config_management.models.groups import ConfigGroups
 
 from itam.models.device import Device

app/api/serializers/itam/inventory.py

@@ -1,6 +1,3 @@
-from django.urls import reverse
-
-from itam.models.device import Device
 from rest_framework import serializers
 
 

app/api/serializers/project_management/project_state.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/project_management/project_type.py

@@ -1,5 +1,3 @@
-from django.urls import reverse
-
 from rest_framework import serializers
 from rest_framework.fields import empty
 

app/api/serializers/project_management/projects.py

@@ -1,7 +1,6 @@
 from django.urls import reverse
 
 from rest_framework import serializers
-from rest_framework.fields import empty
 
 from project_management.models.projects import Project
 

app/api/viewsets/common.py

@@ -12,7 +12,6 @@ from rest_framework.response import Response
 from access.mixins.organization import OrganizationMixin
 from access.mixins.permissions import OrganizationPermissionMixin
 
-from api.auth import TokenScheme
 from api.react_ui_metadata import ReactUIMetadata
 
 

app/assistance/models/knowledge_base.py

@@ -1,6 +1,5 @@
 import django
 from django.db import models
-from django.forms import ValidationError
 
 from access.fields import *
 from access.models.team import Team

app/assistance/models/model_knowledge_base_article.py

@@ -2,9 +2,6 @@ import importlib
 
 from django.apps import apps
 from django.db import models
-from django.forms import ValidationError
-
-from rest_framework.reverse import reverse
 
 from access.fields import *
 from access.models.tenancy import TenancyObject

app/assistance/serializers/knowledge_base_category.py

@@ -1,7 +1,7 @@
 from rest_framework.reverse import reverse
 
 from rest_framework import serializers
-from rest_framework.exceptions import ParseError, ValidationError
+from rest_framework.exceptions import ValidationError
 
 
 from access.serializers.organization import TenantBaseSerializer

app/assistance/serializers/knowledge_base_category_notes.py

@@ -1,13 +1,6 @@
-from rest_framework import serializers
-
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from assistance.models.knowledge_base_category_notes import KnowledgeCategoryBaseNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/assistance/serializers/knowledge_base_notes.py

@@ -1,13 +1,6 @@
-from rest_framework import serializers
-
 from assistance.models.knowledge_base_notes import KnowledgeBaseNotes
 
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/assistance/serializers/model_knowledge_base_article.py

@@ -1,7 +1,4 @@
-from django.apps import apps
-
 from rest_framework import serializers
-from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer
 

app/assistance/serializers/request.py

@@ -1,7 +1,5 @@
 from rest_framework import serializers
 
-from centurion.serializers.user import UserBaseSerializer
-
 from core.models.ticket.ticket_category import TicketCategory
 from core.serializers.ticket_depreciated import (
     Ticket,

app/assistance/viewsets/knowledge_base.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from assistance.serializers.knowledge_base import (
+from assistance.serializers.knowledge_base import (    # pylint: disable=W0611:unused-import
     KnowledgeBase,
     KnowledgeBaseModelSerializer,
     KnowledgeBaseViewSerializer

app/assistance/viewsets/knowledge_base_category.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from assistance.serializers.knowledge_base_category import (
+from assistance.serializers.knowledge_base_category import (    # pylint: disable=W0611:unused-import
     KnowledgeBaseCategory,
     KnowledgeBaseCategoryModelSerializer,
     KnowledgeBaseCategoryViewSerializer

app/assistance/viewsets/model_knowledge_base_article.py

@@ -4,7 +4,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from assistance.serializers.model_knowledge_base_article import (
+from assistance.serializers.model_knowledge_base_article import (    # pylint: disable=W0611:unused-import
     all_models,
     ModelKnowledgeBaseArticle,
     ModelKnowledgeBaseArticleModelSerializer,

app/assistance/viewsets/request.py

@@ -5,7 +5,7 @@ from drf_spectacular.utils import (
     PolymorphicProxySerializer,
 )
 
-from assistance.serializers.request import (
+from assistance.serializers.request import (    # pylint: disable=W0611:unused-import
     RequestAddTicketModelSerializer,
     RequestChangeTicketModelSerializer,
     RequestTriageTicketModelSerializer,
@@ -16,8 +16,6 @@ from assistance.serializers.request import (
 
 from core.viewsets.ticket_depreciated import TicketViewSet
 
-from settings.models.user_settings import UserSettings
-
 
 
 @extend_schema_view(

app/centurion_feature_flag/urls/django.py

@@ -1,6 +1,6 @@
-from django.urls.conf import (
+from django.urls.conf import (    # pylint: disable=W0611:unused-import
     _path as _django_path,
-    include,    # pylint: disable=W0611:unused-import
+    include,
     partial,
     RegexPattern as DjangoRegexPattern,
     RoutePattern as DjangoRoutePattern,

app/centurion_feature_flag/views/disabled.py

@@ -1,4 +1,4 @@
-from django.shortcuts import Http404, HttpResponse #, redirect, render
+from django.shortcuts import Http404
 from django.views.generic import View
 
 

app/config_management/serializers/config_group.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer

app/config_management/serializers/config_group_notes.py

@@ -1,11 +1,4 @@
-from rest_framework import serializers
-
-from api.serializers import common
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/config_management/serializers/config_group_software.py

@@ -1,5 +1,4 @@
 from rest_framework import serializers
-from rest_framework.fields import empty
 from rest_framework.reverse import reverse
 
 from access.serializers.organization import TenantBaseSerializer

app/config_management/viewsets/config_group.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.serializers.config_group import (
+from config_management.serializers.config_group import (    # pylint: disable=W0611:unused-import
     ConfigGroups,
     ConfigGroupModelSerializer,
     ConfigGroupViewSerializer

app/config_management/viewsets/config_group_software.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.serializers.config_group_software import (
+from config_management.serializers.config_group_software import (    # pylint: disable=W0611:unused-import
     ConfigGroupSoftware,
     ConfigGroupSoftwareModelSerializer,
     ConfigGroupSoftwareViewSerializer

app/core/exceptions.py

@@ -1,11 +1,11 @@
-from django.core.exceptions import (
+from django.core.exceptions import (    # pylint: disable=W0611:unused-import
     ObjectDoesNotExist
 )
 
-from django.http import Http404
+from django.http import Http404    # pylint: disable=W0611:unused-import
 
 from rest_framework import exceptions, status
-from rest_framework.exceptions import (
+from rest_framework.exceptions import (    # pylint: disable=W0611:unused-import
     MethodNotAllowed,
     NotFound,
     NotAuthenticated,

app/core/fields/__init__.py

@@ -1,2 +1,2 @@
-from .char import CharField
-from .markdown import MarkdownField
+from .char import CharField    # pylint: disable=W0611:unused-import
+from .markdown import MarkdownField    # pylint: disable=W0611:unused-import

app/core/fields/badge.py

@@ -3,8 +3,6 @@ from rest_framework.fields import empty
 
 from core.classes.badge import Badge
 
-from core.fields.icon import Icon, IconField
-
 
 
 class BadgeField(serializers.DictField):

app/core/fields/markdown.py

@@ -1,5 +1,3 @@
-from rest_framework import serializers
-
 from core.fields import CharField
 
 

app/core/lib/markdown_plugins/model_reference.py

@@ -2,7 +2,6 @@
 import re
 
 from django.template import Context, Template
-from django.template.loader import render_to_string
 from django.urls import reverse
 
 from markdown_it import MarkdownIt

app/core/lib/slash_commands/duration.py

@@ -1,4 +1,4 @@
-import re
+
 
 
 class Duration:

app/core/management/commands/manufacturer.py

@@ -1,6 +1,5 @@
 from django.core.management.base import BaseCommand
 from django.db.models import Q
-from django.utils import timezone
 
 from core.models.manufacturer import Manufacturer
 

app/core/models/__init__.py

@@ -1,4 +1,4 @@
-from .history import History
-from . import ticket_comment_action
-from . import ticket_comment_base
-from . import ticket_comment_solution
+from .history import History    # pylint: disable=W0611:unused-import
+from . import ticket_comment_action    # pylint: disable=W0611:unused-import
+from . import ticket_comment_base    # pylint: disable=W0611:unused-import
+from . import ticket_comment_solution    # pylint: disable=W0611:unused-import

app/core/models/model_history.py

@@ -1,3 +1,3 @@
-from core.models.audit import (
+from core.models.audit import (    # pylint: disable=W0611:unused-import
     ModelHistory
 )

app/core/models/model_notes.py

@@ -4,21 +4,11 @@ from django.conf import settings
 from django.contrib.auth.models import ContentType
 from django.db import models
 
-from rest_framework.reverse import reverse
-
 from access.fields import *
 from access.models.tenancy import TenancyObject
 
-from config_management.models.groups import ConfigGroups
-
 from core.lib.feature_not_used import FeatureNotUsed
 
-from itam.models.device import Device
-from itam.models.software import Software
-from itam.models.operating_system import OperatingSystem
-
-from itim.models.services import Service
-
 User = django.contrib.auth.get_user_model()
 
 

app/core/models/ticket/ticket.py

@@ -18,7 +18,7 @@ from core import exceptions as centurion_exceptions
 from core.lib.feature_not_used import FeatureNotUsed
 from core.lib.slash_commands import SlashCommands
 from core.middleware.get_request import get_request
-from core.models.ticket.ticket_category import TicketCategory, KnowledgeBase
+from core.models.ticket.ticket_category import TicketCategory
 
 from project_management.models.project_milestone import Project, ProjectMilestone
 
@@ -1529,12 +1529,6 @@ class RelatedTickets(TenancyObject):
         return FeatureNotUsed
 
 
-    def __str__(self):
-
-        # return '#' + str( self.id )
-
-        return '#'
-
 
     @property
     def parent_object(self):

app/core/models/ticket/ticket_category.py

@@ -1,7 +1,6 @@
 from django.db import models
 
 from access.fields import AutoCreatedField, AutoLastModifiedField
-from access.models.team import Team
 from access.models.tenancy import TenancyObject
 
 from assistance.models.knowledge_base import KnowledgeBase

app/core/models/ticket/ticket_comment_category.py

@@ -1,7 +1,6 @@
 from django.db import models
 
 from access.fields import AutoCreatedField, AutoLastModifiedField
-from access.models.team import Team
 from access.models.tenancy import TenancyObject
 
 from assistance.models.knowledge_base import KnowledgeBase

app/core/models/ticket/ticket_linked_items.py

@@ -5,13 +5,13 @@ from django.dispatch import receiver
 
 from rest_framework.reverse import reverse
 
-from .ticket_enum_values import TicketValues
-
 from access.models.tenancy import TenancyObject
 
+from assistance.models.knowledge_base import KnowledgeBase
+
 from core.lib.feature_not_used import FeatureNotUsed
 from core.middleware.get_request import get_request
-from core.models.ticket.ticket import Ticket, KnowledgeBase
+from core.models.ticket.ticket import Ticket
 
 deleted_model = dispatch.Signal()
 

app/core/models/ticket_base.py

@@ -780,7 +780,6 @@ class TicketBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/core/models/ticket_comment_action.py

@@ -1,7 +1,3 @@
-import datetime
-
-
-from core import exceptions as centurion_exception
 from core.models.ticket_comment_base import TicketCommentBase
 
 

app/core/models/ticket_comment_base.py

@@ -335,7 +335,6 @@ class TicketCommentBase(
                 ):
 
                     return related_object.name
-                    break
 
 
         return ''

app/core/serializers/celery_log.py

@@ -1,14 +1,8 @@
-import json
-
 from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from django_celery_results.models import TaskResult
 
-from access.serializers.organization import TenantBaseSerializer
-
-from centurion.serializers.user import UserBaseSerializer
-
 from core import fields as centurion_field
 
 

app/core/serializers/manufacturer.py

@@ -1,10 +1,7 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
-from centurion.serializers.user import UserBaseSerializer
-
 from api.serializers import common
 
 from core.models.manufacturer import Manufacturer

app/core/serializers/manufacturer_notes.py

@@ -1,7 +1,6 @@
 from core.models.manufacturer_notes import ManufacturerNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/model_notes.py

@@ -1,5 +1,4 @@
 from django.contrib.auth.models import ContentType
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/core/serializers/ticket_category.py

@@ -1,4 +1,3 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer

app/core/serializers/ticket_category_notes.py

@@ -1,7 +1,6 @@
 from core.models.ticket.ticket_category_notes import TicketCategoryNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/ticket_comment.py

@@ -1,5 +1,3 @@
-import datetime
-
 from rest_framework.reverse import reverse
 
 from rest_framework import serializers

app/core/serializers/ticket_comment_category.py

@@ -1,10 +1,7 @@
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
-from centurion.serializers.user import UserBaseSerializer
-
 from api.serializers import common
 
 from core.models.ticket.ticket_comment_category import TicketCommentCategory

app/core/serializers/ticket_comment_category_notes.py

@@ -1,7 +1,6 @@
 from core.models.ticket.ticket_comment_category_notes import TicketCommentCategoryNotes
 
 from core.serializers.model_notes import (
-    ModelNotes,
     ModelNoteBaseSerializer,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer

app/core/serializers/ticket_comment_depreciated.py

@@ -3,7 +3,7 @@ from rest_framework.reverse import reverse
 from rest_framework import serializers
 from rest_framework.fields import empty
 
-from access.serializers.organization import Organization, TenantBaseSerializer
+from access.serializers.organization import TenantBaseSerializer
 from access.serializers.teams import TeamBaseSerializer
 
 from api.serializers import common

app/core/serializers/ticket_depreciated.py

@@ -14,7 +14,7 @@ from core import exceptions as centurion_exception
 from core import fields as centurion_field
 from core.models.ticket.ticket import Ticket
 
-from core.fields.badge import Badge, BadgeField
+from core.fields.badge import BadgeField
 from core.serializers.ticket_category import TicketCategoryBaseSerializer
 
 from project_management.serializers.project import ProjectBaseSerializer
@@ -232,11 +232,10 @@ class TicketModelSerializer(
                 if self.instance.project is None:
 
                     raise centurion_exception.ValidationError(
-                        details = 'Milestones require a project',
+                        detail = 'Milestones require a project',
                         code = 'milestone_requires_project',
                     )
 
-                    return False
 
                 if self.instance.project.id == self.instance.milestone.project.id:
 

app/core/serializers/ticket_linked_item.py

@@ -1,5 +1,3 @@
-from rest_framework.fields import empty
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
@@ -7,7 +5,6 @@ from access.serializers.organization import TenantBaseSerializer
 from assistance.serializers.request import TicketBaseSerializer
 
 from core import fields as centurion_field
-from core.fields.badge import BadgeField
 from core.models.ticket.ticket import Ticket
 from core.models.ticket.ticket_linked_items import TicketLinkedItem
 

app/core/serializers/ticket_related.py

@@ -1,12 +1,10 @@
-from rest_framework.fields import empty
-from rest_framework.reverse import reverse
 from rest_framework import serializers
 
 from access.serializers.organization import TenantBaseSerializer
 
 from api.serializers import common
 
-from core.serializers.ticket_depreciated import Ticket, TicketBaseSerializer
+from core.serializers.ticket_depreciated import TicketBaseSerializer
 
 from core import exceptions as centurion_exceptions
 from core import fields as centurion_field

app/core/tests/functional/related_ticket/test_related_ticket_serializer.py

@@ -9,8 +9,8 @@ from access.models.tenant import Tenant as Organization
 
 from centurion.tests.abstract.mock_view import MockView
 
+from core.models.ticket.ticket import Ticket
 from core.serializers.ticket_related import (
-    Ticket,
     RelatedTickets,
     RelatedTicketModelSerializer,
 )

app/core/viewsets/celery_log.py

@@ -1,6 +1,6 @@
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
 
-from core.serializers.celery_log import (
+from core.serializers.celery_log import (    # pylint: disable=W0611:unused-import
     TaskResult,
     TaskResultModelSerializer,
     TaskResultViewSerializer

app/core/viewsets/manufacturer.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from core.models.manufacturer_history import ManufacturerHistory    # pylint: disable=W0611:unused-import
-from core.serializers.manufacturer import (
+from core.serializers.manufacturer import (    # pylint: disable=W0611:unused-import
     Manufacturer,
     ManufacturerModelSerializer,
     ManufacturerViewSerializer

app/core/viewsets/model_notes.py

@@ -1,8 +1,6 @@
 from django.contrib.auth.models import ContentType
 
-from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResponse
-
-from core.serializers.model_notes import (
+from core.serializers.model_notes import (    # pylint: disable=W0611:unused-import
     ModelNotes,
     ModelNoteModelSerializer,
     ModelNoteViewSerializer
@@ -10,14 +8,6 @@ from core.serializers.model_notes import (
 
 from api.viewsets.common import ModelViewSet
 
-from config_management.models.groups import ConfigGroups
-
-from itam.models.device import Device
-from itam.models.operating_system import OperatingSystem
-from itam.models.software import Software
-
-from itim.models.services import Service
-
 
 
 class ModelNoteViewSet(ModelViewSet):

app/core/viewsets/related_ticket.py

@@ -2,12 +2,10 @@ from django.db.models import Q
 
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from access.mixin import OrganizationMixin
-
 from api.viewsets.common import ModelListRetrieveDeleteViewSet
 
-from core.serializers.ticket_related import (
-    Ticket,
+from core.models.ticket.ticket import Ticket
+from core.serializers.ticket_related import (    # pylint: disable=W0611:unused-import
     RelatedTickets,
     RelatedTicketModelSerializer,
     RelatedTicketViewSerializer,

app/core/viewsets/ticket_category.py

@@ -4,7 +4,7 @@ from api.viewsets.common import ModelViewSet
 
 # THis import only exists so that the migrations can be created
 from core.models.ticket.ticket_category_history import TicketCategoryHistory    # pylint: disable=W0611:unused-import
-from core.serializers.ticket_category import (
+from core.serializers.ticket_category import (    # pylint: disable=W0611:unused-import
     TicketCategory,
     TicketCategoryModelSerializer,
     TicketCategoryViewSerializer

app/core/viewsets/ticket_comment_category.py

@@ -2,7 +2,7 @@ from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiResp
 
 # THis import only exists so that the migrations can be created
 from core.models.ticket.ticket_comment_category_history import TicketCommentCategoryHistory    # pylint: disable=W0611:unused-import
-from core.serializers.ticket_comment_category import (
+from core.serializers.ticket_comment_category import (    # pylint: disable=W0611:unused-import
     TicketCommentCategory,
     TicketCommentCategoryModelSerializer,
     TicketCommentCategoryViewSerializer

app/core/viewsets/ticket_comment_depreciated.py

@@ -1,18 +1,9 @@
-from django.db.models import Q
-from django.shortcuts import get_object_or_404
-
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse, PolymorphicProxySerializer
 
-from rest_framework import generics, viewsets
-from rest_framework.response import Response
-
-from access.mixin import OrganizationMixin
-
-from api.views.mixin import OrganizationPermissionAPI
 from api.viewsets.common import ModelViewSet
 
 from core import exceptions as centurion_exceptions
-from core.serializers.ticket_comment_depreciated import (
+from core.serializers.ticket_comment_depreciated import (    # pylint: disable=W0611:unused-import
     Ticket,
     TicketComment,
     TicketCommentImportModelSerializer,
@@ -35,8 +26,6 @@ from core.serializers.ticket_comment_depreciated import (
     TicketCommentViewSerializer
 )
 
-from settings.models.user_settings import UserSettings
-
 
 
 @extend_schema_view(

app/core/viewsets/ticket_depreciated.py

@@ -3,7 +3,7 @@ from api.viewsets.common import ModelViewSet
 
 from access.models.tenant import Tenant as Organization
 
-from assistance.serializers.request import (
+from assistance.serializers.request import (    # pylint: disable=W0611:unused-import
     RequestAddTicketModelSerializer,
     RequestChangeTicketModelSerializer,
     RequestTriageTicketModelSerializer,
@@ -16,7 +16,7 @@ from core.serializers.ticket_depreciated import (
     Ticket,
 )
 
-from itim.serializers.change import (
+from itim.serializers.change import (    # pylint: disable=W0611:unused-import
     ChangeAddTicketModelSerializer,
     ChangeChangeTicketModelSerializer,
     ChangeImportTicketModelSerializer,
@@ -25,7 +25,7 @@ from itim.serializers.change import (
     ChangeTicketViewSerializer,
 )
 
-from itim.serializers.incident import (
+from itim.serializers.incident import (    # pylint: disable=W0611:unused-import
     IncidentAddTicketModelSerializer,
     IncidentChangeTicketModelSerializer,
     IncidentImportTicketModelSerializer,
@@ -34,7 +34,7 @@ from itim.serializers.incident import (
     IncidentTicketViewSerializer,
 )
 
-from itim.serializers.problem import (
+from itim.serializers.problem import (    # pylint: disable=W0611:unused-import
     ProblemAddTicketModelSerializer,
     ProblemChangeTicketModelSerializer,
     ProblemImportTicketModelSerializer,
@@ -43,7 +43,7 @@ from itim.serializers.problem import (
     ProblemTicketViewSerializer,
 )
 
-from project_management.serializers.project_task import (
+from project_management.serializers.project_task import (    # pylint: disable=W0611:unused-import
     ProjectTaskAddTicketModelSerializer,
     ProjectTaskChangeTicketModelSerializer,
     ProjectTaskImportTicketModelSerializer,
@@ -52,8 +52,6 @@ from project_management.serializers.project_task import (
     ProjectTaskTicketViewSerializer,
 )
 
-from settings.models.user_settings import UserSettings
-
 
 
 class TicketViewSet(ModelViewSet):

app/core/viewsets/ticket_linked_item.py

@@ -1,6 +1,5 @@
 from drf_spectacular.utils import extend_schema, extend_schema_view, OpenApiParameter, OpenApiResponse
 
-from api.views.mixin import OrganizationPermissionAPI
 from api.viewsets.common import ModelViewSet
 
 from assistance.models.knowledge_base import KnowledgeBase
@@ -9,7 +8,7 @@ from config_management.models.groups import ConfigGroups
 
 from core.models.ticket.ticket_category import TicketCategory
 from core.models.ticket.ticket_comment_category import TicketCommentCategory
-from core.serializers.ticket_linked_item import (
+from core.serializers.ticket_linked_item import (    # pylint: disable=W0611:unused-import
     Ticket,
     TicketLinkedItem,
     TicketLinkedItemModelSerializer,

app/devops/models/__init__.py

@@ -1,5 +1,5 @@
-from . import check_ins
-from . import git_group
-from . import git_repository
-from . import feature_flag
-from . import software_enable_feature_flag
+from . import check_ins    # pylint: disable=W0611:unused-import
+from . import git_group    # pylint: disable=W0611:unused-import
+from . import git_repository    # pylint: disable=W0611:unused-import
+from . import feature_flag    # pylint: disable=W0611:unused-import
+from . import software_enable_feature_flag    # pylint: disable=W0611:unused-import

app/devops/models/git_repository/__init__.py

@@ -1,2 +1,2 @@
-from . import github
-from . import gitlab
+from . import github    # pylint: disable=W0611:unused-import
+from . import gitlab    # pylint: disable=W0611:unused-import

app/devops/models/software_enable_feature_flag.py

@@ -1,6 +1,6 @@
 import pytz
 
-from datetime import date, datetime
+from datetime import datetime
 
 from django.db import models
 

app/devops/serializers/git_repository/base.py

@@ -8,7 +8,7 @@ from api.serializers import common
 
 from core.fields.badge import BadgeField
 
-from devops.models.git_repository.base import GitRepository, GitGroup
+from devops.models.git_repository.base import GitRepository
 from devops.serializers.git_group import BaseSerializer as GitGroupBaseSerializer
 
 

app/devops/serializers/git_repository/github.py

@@ -2,11 +2,9 @@ from drf_spectacular.utils import extend_schema_serializer
 
 from rest_framework import serializers
 
-from api.serializers import common
-
 from devops.models.git_group import GitGroup
 from devops.models.git_repository.github import GitHubRepository
-from devops.serializers.git_repository.base import (
+from devops.serializers.git_repository.base import (    # pylint: disable=W0611:unused-import
     BaseSerializer,
     ModelSerializer as GitModelSerializer,
     ViewSerializer as GitViewSerializer

app/devops/serializers/git_repository/gitlab.py

@@ -2,15 +2,9 @@ from drf_spectacular.utils import extend_schema_serializer
 
 from rest_framework import serializers
 
-from access.serializers.organization import TenantBaseSerializer
-
-from api.serializers import common
-
-from core import exceptions as centurion_exceptions
-
 from devops.models.git_group import GitGroup
 from devops.models.git_repository.gitlab import GitLabRepository
-from devops.serializers.git_repository.base import (
+from devops.serializers.git_repository.base import (    # pylint: disable=W0611:unused-import
     BaseSerializer,
     ModelSerializer as GitModelSerializer,
     ViewSerializer as GitViewSerializer

app/devops/tests/unit/feature_flag/test_unit_feature_flag_history_api_v2.py

@@ -1,7 +1,6 @@
 from django.contrib.contenttypes.models import ContentType
 from django.test import TestCase
 
-from core.models.manufacturer_history import Manufacturer, ManufacturerHistory
 from core.tests.abstract.test_unit_model_history_api_v2 import PrimaryModelHistoryAPI
 
 from devops.models.feature_flag_history import FeatureFlag, FeatureFlagHistory

app/devops/urls_public.py

@@ -1,4 +1,4 @@
-from rest_framework.routers import DefaultRouter, SimpleRouter
+from rest_framework.routers import SimpleRouter
 
 from devops.viewsets import (
     feature_flag_endpoints,