nofusscomputing/centurion_erp
1
0
Fork 0
Code Issues Wiki Activity

feat(devops): Switch model FeatureFlag inheritance to CenturionModel

Browse Source 
ref: #780 #782
This commit is contained in:
Jon Lockwood
2025-05-31 06:23:01 +09:30
parent 2d1ec6a84a
commit ef294cc081
5 changed files with 288 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/centurion/tests/unit_models.py
View File

@ -99,7 +99,7 @@ class ModelTestCases(
@pytest.fixture( scope = 'class', autouse = True)
def setup_class(cls, request, model):
pass
@ -111,7 +111,7 @@ class ModelTestCases(
def test_model_field_parameter_value_blank(self,
model_instance,
model_instance,
parameterized, param_key_model_fields, param_field_name, param_blank
):
"""Test Model Field Parameter
@ -130,7 +130,7 @@ class ModelTestCases(
def test_model_field_parameter_value_default(self,
model_instance,
model_instance,
parameterized, param_key_model_fields, param_field_name, param_default
):
"""Test Model Field Parameter
@ -150,7 +150,7 @@ class ModelTestCases(
def test_model_field_parameter_value_null(self,
model_instance,
model_instance,
parameterized, param_key_model_fields, param_field_name, param_null
):
"""Test Model Field Parameter
@ -170,7 +170,7 @@ class ModelTestCases(
def test_model_field_parameter_value_unique(self,
model_instance,
model_instance,
parameterized, param_key_model_fields, param_field_name, param_unique
):
"""Test Model Field Parameter

129
app/devops/migrations/0016_alter_featureflag_description_alter_featureflag_id_and_more.py Normal file
View File

@ -0,0 +1,129 @@
# Generated by Django 5.1.9 on 2025-05-30 19:28
import access.models.tenancy_abstract
import django.db.models.deletion
from django.db import migrations, models
class Migration(migrations.Migration):
dependencies = [
("access", "0010_company_alter_entity_entity_type_alter_person_dob_and_more"),
("core", "0027_centurionmodelnote"),
("devops", "0015_gitgroupcenturionmodelnote"),
]
operations = [
migrations.AlterField(
model_name="featureflag",
name="description",
field=models.TextField(
blank=True,
help_text="Description of this feature",
max_length=300,
null=True,
verbose_name="Description",
),
),
migrations.AlterField(
model_name="featureflag",
name="id",
field=models.AutoField(
help_text="ID of the item",
primary_key=True,
serialize=False,
unique=True,
verbose_name="ID",
),
),
migrations.AlterField(
model_name="featureflag",
name="model_notes",
field=models.TextField(
blank=True,
help_text="Tid bits of information",
null=True,
verbose_name="Notes",
),
),
migrations.AlterField(
model_name="featureflag",
name="organization",
field=models.ForeignKey(
help_text="Tenant this belongs to",
on_delete=django.db.models.deletion.CASCADE,
related_name="+",
to="access.tenant",
validators=[
access.models.tenancy_abstract.TenancyAbstractModel.validatate_organization_exists
],
verbose_name="Tenant",
),
),
migrations.CreateModel(
name="FeatureFlagAuditHistory",
fields=[
(
"centurionaudit_ptr",
models.OneToOneField(
auto_created=True,
on_delete=django.db.models.deletion.CASCADE,
parent_link=True,
primary_key=True,
serialize=False,
to="core.centurionaudit",
),
),
(
"model",
models.ForeignKey(
help_text="Model this history belongs to",
on_delete=django.db.models.deletion.CASCADE,
related_name="audit_history",
to="devops.featureflag",
verbose_name="Model",
),
),
],
options={
"verbose_name": "Feature Flag History",
"verbose_name_plural": "Feature Flag Histories",
"db_table": "devops_featureflag_audithistory",
"managed": True,
},
bases=("core.centurionaudit", models.Model),
),
migrations.CreateModel(
name="FeatureFlagCenturionModelNote",
fields=[
(
"centurionmodelnote_ptr",
models.OneToOneField(
auto_created=True,
on_delete=django.db.models.deletion.CASCADE,
parent_link=True,
primary_key=True,
serialize=False,
to="core.centurionmodelnote",
),
),
(
"model",
models.ForeignKey(
help_text="Model this note belongs to",
on_delete=django.db.models.deletion.CASCADE,
related_name="+",
to="devops.featureflag",
verbose_name="Model",
),
),
],
options={
"verbose_name": "Feature Flag Note",
"verbose_name_plural": "Feature Flag Notes",
"db_table": "devops_featureflag_centurionmodelnote",
"managed": True,
},
bases=("core.centurionmodelnote", models.Model),
),
]

42
app/devops/models/feature_flag.py
View File

@ -1,17 +1,25 @@
from django.db import models
from access.fields import AutoCreatedField, AutoLastModifiedField
from access.models.tenancy import TenancyObject
from access.fields import AutoLastModifiedField
from core.models.centurion import CenturionModel
from itam.models.software import Software
class FeatureFlag(
TenancyObject
CenturionModel
):
app_namespace = 'devops'
documentation = 'devops/feature_flags'
model_tag = 'feature_flag'
class Meta:
ordering = [
@ -23,14 +31,6 @@ class FeatureFlag(
verbose_name_plural = 'Feature Flag'
id = models.AutoField(
blank=False,
help_text = 'Primary key of the entry',
primary_key=True,
unique=True,
verbose_name = 'ID'
)
software = models.ForeignKey(
Software,
blank = False,
@ -53,7 +53,6 @@ class FeatureFlag(
description = models.TextField(
blank = True,
default = None,
help_text = 'Description of this feature',
max_length = 300,
null = True,
@ -68,8 +67,6 @@ class FeatureFlag(
verbose_name = 'Enabled'
)
created = AutoCreatedField()
modified = AutoLastModifiedField()
is_global = None # Field not requied.
@ -79,10 +76,6 @@ class FeatureFlag(
return self.name
app_namespace = 'devops'
documentation = 'devops/feature_flags'
page_layout: dict = [
{
"name": "Details",
@ -131,16 +124,3 @@ class FeatureFlag(
'created',
# 'modified'
]
def save_history(self, before: dict, after: dict) -> bool:
from devops.models.feature_flag_history import FeatureFlagHistory
history = super().save_history(
before = before,
after = after,
history_model = FeatureFlagHistory
)
return history

56
app/devops/serializers/centurionaudit_featureflag.py Normal file
View File

@ -0,0 +1,56 @@
from rest_framework import serializers
from drf_spectacular.utils import extend_schema_serializer
from api.serializers import common
from centurion.models.meta import FeatureFlagAuditHistory # pylint: disable=E0401:import-error disable=E0611:no-name-in-module
from core.serializers.centurionaudit import (
BaseSerializer,
ViewSerializer as AuditHistoryViewSerializer
)
@extend_schema_serializer(component_name = 'FeatureFlagModelSerializer')
class ModelSerializer(
common.CommonModelSerializer,
BaseSerializer
):
"""Git Group Audit History Base Model"""
_urls = serializers.SerializerMethodField('get_url')
class Meta:
model = FeatureFlagAuditHistory
fields = [
'id',
'organization',
'display_name',
'content_type',
'model',
'before',
'after',
'action',
'user',
'created',
'_urls',
]
read_only_fields = fields
@extend_schema_serializer(component_name = 'FeatureFlagViewSerializer')
class ViewSerializer(
ModelSerializer,
AuditHistoryViewSerializer,
):
"""Git Group Audit History Base View Model"""
pass

87
app/devops/serializers/centurionmodelnote_featureflag.py Normal file
View File

@ -0,0 +1,87 @@
from rest_framework import serializers
from drf_spectacular.utils import extend_schema_serializer
from access.serializers.organization import (TenantBaseSerializer)
from centurion.models.meta import FeatureFlagCenturionModelNote # pylint: disable=E0401:import-error disable=E0611:no-name-in-module
from core.serializers.centurionmodelnote import ( # pylint: disable=W0611:unused-import
BaseSerializer,
ModelSerializer as BaseModelModelSerializer,
ViewSerializer as BaseModelViewSerializer
)
@extend_schema_serializer(component_name = 'FeatureFlagModelSerializer')
class ModelSerializer(
BaseModelModelSerializer,
):
_urls = serializers.SerializerMethodField('get_url')
def get_url(self, item) -> dict:
return {
'_self': item.get_url( request = self._context['view'].request ),
}
class Meta:
model = FeatureFlagCenturionModelNote
fields = [
'id',
'organization',
'display_name',
'body',
'created_by',
'modified_by',
'content_type',
'model',
'created',
'modified',
'_urls',
]
read_only_fields = [
'id',
'display_name',
'organization',
'created_by',
'modified_by',
'content_type',
'model',
'created',
'modified',
'_urls',
]
def validate(self, attrs):
is_valid = False
note_model = self.Meta.model.model.field.related_model
attrs['model'] = note_model.objects.get(
id = int( self.context['view'].kwargs['model_id'] )
)
is_valid = super().validate(attrs)
return is_valid
@extend_schema_serializer(component_name = 'FeatureFlagViewSerializer')
class ViewSerializer(
ModelSerializer,
BaseModelViewSerializer,
):
organization = TenantBaseSerializer( many = False, read_only = True )