test(functional): Move functional test cases to relevant functional test dir

ref: #15 #375 #382

.github/pull_request_template.md

@@ -32,6 +32,8 @@
 
 - [ ] :checkered_flag: Milestone assigned
 
+- [ ] :gear: :test_tube: [Functional Test(s) Written](https://nofusscomputing.com/projects/centurion_erp/development/testing/)
+
 - [ ] :test_tube: [Unit Test(s) Written](https://nofusscomputing.com/projects/centurion_erp/development/testing/)
 
     _ensure test coverage delta is not less than zero_

app/access/tests/functional/organization/test_organization_serializer.py

@@ -1,14 +1,14 @@
 import pytest
 
-# from django.contrib.auth.models import User
+from django.contrib.auth.models import User
 from django.test import TestCase
 
-# from rest_framework.exceptions import ValidationError
+from rest_framework.exceptions import ValidationError
 
-# from access.serializers.organization import (
-#     Organization,
-#     OrganizationModelSerializer
-# )
+from access.serializers.organization import (
+    Organization,
+    OrganizationModelSerializer
+)
 
 
 
@@ -16,8 +16,77 @@ class OrganizationValidationAPI(
     TestCase,
 ):
 
+    model = Organization
 
-    @pytest.mark.skip( reason = 'tests to be written' )
-    def test_dummy(self):
+    @classmethod
+    def setUpTestData(self):
+        """Setup Test
 
-        pass
+        1. Create an org
+        2. Create an item
+        """
+
+        self.user = User.objects.create(username = 'org_user', password='random password')
+
+        self.valid_data = {
+            'name': 'valid_org_data',
+            'manager': self.user.id
+        }
+
+        self.item = self.model.objects.create(
+            name = 'random title',
+        )
+
+
+
+    def test_serializer_valid_data(self):
+        """Serializer Validation Check
+
+        Ensure that if creating and no name is provided a validation error occurs
+        """
+
+        serializer = OrganizationModelSerializer(
+            data = self.valid_data
+        )
+
+        assert serializer.is_valid(raise_exception = True)
+
+
+
+    def test_serializer_validation_no_name(self):
+        """Serializer Validation Check
+
+        Ensure that if creating and no name is provided a validation error occurs
+        """
+
+        data = self.valid_data.copy()
+        
+        del data['name']
+
+        with pytest.raises(ValidationError) as err:
+
+            serializer = OrganizationModelSerializer(
+                data = data
+            )
+
+            serializer.is_valid(raise_exception = True)
+
+        assert err.value.get_codes()['name'][0] == 'required'
+
+
+
+    def test_serializer_validation_manager_optional(self):
+        """Serializer Validation Check
+
+        Ensure that if creating and no name is provided a validation error occurs
+        """
+
+        data = self.valid_data.copy()
+        
+        del data['manager']
+
+        serializer = OrganizationModelSerializer(
+            data = data
+        )
+
+        assert serializer.is_valid(raise_exception = True)

app/access/tests/unit/organization/test_organization_serializer.py

@@ -1,92 +0,0 @@
-import pytest
-
-from django.contrib.auth.models import User
-from django.test import TestCase
-
-from rest_framework.exceptions import ValidationError
-
-from access.serializers.organization import (
-    Organization,
-    OrganizationModelSerializer
-)
-
-
-
-class OrganizationValidationAPI(
-    TestCase,
-):
-
-    model = Organization
-
-    @classmethod
-    def setUpTestData(self):
-        """Setup Test
-
-        1. Create an org
-        2. Create an item
-        """
-
-        self.user = User.objects.create(username = 'org_user', password='random password')
-
-        self.valid_data = {
-            'name': 'valid_org_data',
-            'manager': self.user.id
-        }
-
-        self.item = self.model.objects.create(
-            name = 'random title',
-        )
-
-
-
-    def test_serializer_valid_data(self):
-        """Serializer Validation Check
-
-        Ensure that if creating and no name is provided a validation error occurs
-        """
-
-        serializer = OrganizationModelSerializer(
-            data = self.valid_data
-        )
-
-        assert serializer.is_valid(raise_exception = True)
-
-
-
-    def test_serializer_validation_no_name(self):
-        """Serializer Validation Check
-
-        Ensure that if creating and no name is provided a validation error occurs
-        """
-
-        data = self.valid_data.copy()
-        
-        del data['name']
-
-        with pytest.raises(ValidationError) as err:
-
-            serializer = OrganizationModelSerializer(
-                data = data
-            )
-
-            serializer.is_valid(raise_exception = True)
-
-        assert err.value.get_codes()['name'][0] == 'required'
-
-
-
-    def test_serializer_validation_manager_optional(self):
-        """Serializer Validation Check
-
-        Ensure that if creating and no name is provided a validation error occurs
-        """
-
-        data = self.valid_data.copy()
-        
-        del data['manager']
-
-        serializer = OrganizationModelSerializer(
-            data = data
-        )
-
-        assert serializer.is_valid(raise_exception = True)

docs/projects/centurion_erp/development/testing.md

@@ -6,15 +6,13 @@ template: project.html
 about: https://gitlab.com/nofusscomputing/infrastructure/configuration-management/centurion_erp
 ---
 
-Unit tests are written to aid in application stability and to assist in preventing regression bugs. As part of development the developer working on a Merge/Pull request is to ensure that tests are written. Failing to do so will more likely than not ensure that your Merge/Pull request is not merged.
+Unit and functional tests are written to aid in application stability and to assist in preventing regression bugs. As part of development the developer working on a Merge/Pull request is to ensure that tests are written. Failing to do so will more likely than not ensure that your Merge/Pull request is not merged.
 
 User Interface (UI) test are written _if applicable_ to test the user interface to ensure that it functions as it should. Changes to the UI will need to be tested.
 
 !!! note
     As of release v1.3, the UI has moved to it's [own project](https://github.com/nofusscomputing/centurion_erp_ui) with the current Django UI feature locked and depreciated.
 
-In most cases functional tests will not need to be written, however you should confirm this with a maintainer.
-
 Integration tests **will** be required if the development introduces code that interacts with an independent third-party application.
 
 

makefile

@@ -40,7 +40,17 @@ lint: markdown-mkdocs-lint
 
 test:
 	cd app
-	pytest --cov --cov-report term --cov-report xml:../artifacts/coverage.xml --cov-report html:../artifacts/coverage/ --junit-xml=../artifacts/unit.JUnit.xml **/tests/unit **/tests/functional
+	pytest --cov --cov-report term --cov-report xml:../artifacts/coverage_unit_functional.xml --cov-report html:../artifacts/coverage/unit_functional/ --junit-xml=../artifacts/unit_functional.JUnit.xml **/tests/unit **/tests/functional
+
+test-functional:
+	cd app
+	pytest --cov --cov-report term --cov-report xml:../artifacts/coverage_functional.xml --cov-report html:../artifacts/coverage/functional/ --junit-xml=../artifacts/functional.JUnit.xml **/tests/functional
+
+
+test-unit:
+	cd app
+	pytest --cov --cov-report term --cov-report xml:../artifacts/coverage_unit.xml --cov-report html:../artifacts/coverage/unit/ --junit-xml=../artifacts/unit.JUnit.xml **/tests/unit
+
 
 
 clean: